Skip to content

Automate browser based workflows with AI

revert: narrow autocomplete input triggers from #9417 (#6330)

LawyZhenge7a5356a0367
diff --git a/skyvern/webeye/utils/dom.py b/skyvern/webeye/utils/dom.py
index 6c648a696..172a5e47b 100644
--- a/skyvern/webeye/utils/dom.py
+++ b/skyvern/webeye/utils/dom.py
@@ -159,21 +159,13 @@ class SkyvernElement:
return True
autocomplete: str | None = await self.get_attr("aria-autocomplete")
- if autocomplete and autocomplete.lower() in ("list", "both", "inline"):
+ if autocomplete and autocomplete.lower() == "list":
return True
class_name: str | None = await self.get_attr("class")
if class_name and "autocomplete-input" in class_name.lower():
return True
- # Combobox inputs (role="combobox") present a list of options — treat as
- # auto-completion so the agent uses the dropdown-selection flow instead of
- # the Tab hack. This covers account-search fields in many apps that use
- # role="combobox" without setting aria-autocomplete.
- role: str | None = await self.get_attr("role")
- if role and role.lower() == "combobox":
- return True
-
# Tag inputs where typing surfaces a suggestion list to select from
if class_name:
cl = class_name.lower()
diff --git a/tests/unit/test_auto_completion_detection.py b/tests/unit/test_auto_completion_detection.py
new file mode 100644
index 000000000..a095d0c21
--- /dev/null
+++ b/tests/unit/test_auto_completion_detection.py
@@ -0,0 +1,77 @@
+"""Regression tests for autocomplete input detection.
+
+Covers direct attribute detection in is_auto_completion_input().
+"""
+
+from __future__ import annotations
+
+from unittest.mock import AsyncMock, MagicMock
+
+import pytest
+
+from skyvern.webeye.utils.dom import SkyvernElement
+
+
+def _make_element(
+ attributes: dict[str, str] | None = None,
+ *,
+ tag_name: str = "input",
+) -> tuple[SkyvernElement, MagicMock]:
+ locator = MagicMock()
+ locator.get_attribute = AsyncMock(return_value=None)
+ locator.element_handle = AsyncMock(return_value=MagicMock())
+ element = SkyvernElement(
+ locator=locator,
+ frame=MagicMock(),
+ static_element={
+ "id": "AA1",
+ "tagName": tag_name,
+ "attributes": attributes or {},
+ },
+ )
+ return element, locator
+
+
+async def test_direct_aria_autocomplete_list() -> None:
+ element, _ = _make_element({"aria-autocomplete": "list"})
+ assert await element.is_auto_completion_input() is True
+
+
[email protected]("value", ["both", "inline"])
+async def test_aria_autocomplete_both_inline_not_detected(value: str) -> None:
+ """After partial revert of #9417, only 'list' triggers autocomplete."""
+ element, _ = _make_element({"aria-autocomplete": value})
+ assert await element.is_auto_completion_input() is False
+
+
+async def test_role_combobox_not_detected() -> None:
+ """After partial revert of #9417, role=combobox alone does not trigger."""
+ element, _ = _make_element({"role": "combobox"})
+ assert await element.is_auto_completion_input() is False
+
+
+async def test_non_input_ignored() -> None:
+ element, _ = _make_element({"aria-autocomplete": "list"}, tag_name="textarea")
+ assert await element.is_auto_completion_input() is False
+
+
+async def test_plain_text_input_not_detected() -> None:
+ element, _ = _make_element({"type": "text", "autocomplete": "off"})
+ assert await element.is_auto_completion_input() is False
+
+
+async def test_autocomplete_class() -> None:
+ element, _ = _make_element({"class": "my-autocomplete-input"})
+ assert await element.is_auto_completion_input() is True
+
+
+async def test_data_x_bind_autocomplete() -> None:
+ element, _ = _make_element({"data-x-bind": "someAutocomplete"})
+ assert await element.is_auto_completion_input() is True