Skip to content

Automate browser based workflows with AI

fix download file name bug (#3163)

LawyZhenge8df79347ba0
diff --git a/skyvern/forge/sdk/api/files.py b/skyvern/forge/sdk/api/files.py
index d743b66af..bbb10b143 100644
--- a/skyvern/forge/sdk/api/files.py
+++ b/skyvern/forge/sdk/api/files.py
@@ -64,6 +64,11 @@ def extract_google_drive_file_id(url: str) -> str | None:
return None
+def is_valid_mime_type(file_path: str) -> bool:
+ mime_type, _ = mimetypes.guess_type(file_path)
+ return mime_type is not None
+
+
async def download_file(url: str, max_size_mb: int | None = None) -> str:
try:
# Check if URL is a Google Drive link
@@ -122,7 +127,7 @@ async def download_file(url: str, max_size_mb: int | None = None) -> str:
LOG.info("No file name retrieved from HTTP headers, using the file name from the URL")
file_name = os.path.basename(a.path)
- if not Path(file_name).suffix and file_suffix:
+ if not is_valid_mime_type(file_name) and file_suffix:
LOG.info("No file extension detected, adding the extension from HTTP headers")
file_name = file_name + file_suffix