Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: prevent block output from leaking across loop iterations (#SKY-8835) (#5475)
LawyZhengf76faa49ce62
diff --git a/skyvern/forge/sdk/workflow/context_manager.py b/skyvern/forge/sdk/workflow/context_manager.pyindex 945d90178..b1d277379 100644--- a/skyvern/forge/sdk/workflow/context_manager.py+++ b/skyvern/forge/sdk/workflow/context_manager.py@@ -1062,7 +1062,10 @@ class WorkflowRunContext:current_value = self.values[block_label]# only able to merge the value when the current value and the pending value are both dictsif isinstance(current_value, dict) and isinstance(block_reference_value, dict):- block_reference_value.update(current_value)+ # Merge old into new so that new values (e.g. from the latest loop+ # iteration) take precedence over stale ones.+ merged = {**current_value, **block_reference_value}+ block_reference_value = mergedelse:LOG.warning(f"Parameter {block_label} already has a value in workflow run context, overwriting")diff --git a/tests/unit/test_loop_block_output_scoping.py b/tests/unit/test_loop_block_output_scoping.pynew file mode 100644index 000000000..01facc8c6--- /dev/null+++ b/tests/unit/test_loop_block_output_scoping.py@@ -0,0 +1,109 @@+"""+Test that block output parameters are correctly scoped across loop iterations.++Verifies that when the same block runs multiple times inside a for-loop,+later iterations' extracted_information takes precedence over earlier ones.+"""++from datetime import datetime++from skyvern.forge.sdk.workflow.context_manager import WorkflowRunContext+from skyvern.forge.sdk.workflow.models.parameter import OutputParameter, ParameterType+++def _make_output_parameter(key: str) -> OutputParameter:+ return OutputParameter(+ parameter_type=ParameterType.OUTPUT,+ key=key,+ output_parameter_id="op_test",+ workflow_id="wf_test",+ created_at=datetime.now(),+ modified_at=datetime.now(),+ )+++def test_block_output_updates_across_loop_iterations():+ """+ Simulates two loop iterations where block 'extract_data' produces different+ extracted_information each time. Verifies that the second registration+ overwrites (not merges-under) the first.+ """+ ctx = WorkflowRunContext(+ workflow_title="test",+ workflow_id="wf_test",+ workflow_permanent_id="wpid_test",+ workflow_run_id="wr_test",+ aws_client=None, # type: ignore[arg-type]+ )++ param = _make_output_parameter("extract_data_output")++ # --- Iteration 1 ---+ iteration_1_value = {+ "extracted_information": {"quote": "Quote from page 1", "author": "Author 1"},+ "status": "completed",+ }+ ctx.register_block_reference_variable_from_output_parameter(param, iteration_1_value)++ assert ctx.values["extract_data"]["extracted_information"] == {+ "quote": "Quote from page 1",+ "author": "Author 1",+ }++ # --- Iteration 2 ---+ iteration_2_value = {+ "extracted_information": {"quote": "Quote from page 2", "author": "Author 2"},+ "status": "completed",+ }+ ctx.register_block_reference_variable_from_output_parameter(param, iteration_2_value)++ # After iteration 2, values must reflect iteration 2's data+ result = ctx.values["extract_data"]+ assert result["extracted_information"] == {"quote": "Quote from page 2", "author": "Author 2"}, (+ f"Iteration 2's extracted_information was overwritten by iteration 1's. Got: {result}"+ )+ # The `output` alias must also reflect the latest iteration+ assert result["output"] == {"quote": "Quote from page 2", "author": "Author 2"}+++def test_old_only_keys_preserved_across_iterations():+ """+ When iteration 1 produces keys that iteration 2 does not, those keys+ should be preserved (merge semantics), while overlapping keys use+ iteration 2's values.+ """+ ctx = WorkflowRunContext(+ workflow_title="test",+ workflow_id="wf_test",+ workflow_permanent_id="wpid_test",+ workflow_run_id="wr_test",+ aws_client=None, # type: ignore[arg-type]+ )++ param = _make_output_parameter("block_output")++ # Iteration 1 has an extra key "extra_field"+ ctx.register_block_reference_variable_from_output_parameter(+ param,+ {+ "extracted_information": {"name": "Alice"},+ "extra_field": "only_in_iter1",+ "status": "completed",+ },+ )++ # Iteration 2 does not have "extra_field"+ ctx.register_block_reference_variable_from_output_parameter(+ param,+ {+ "extracted_information": {"name": "Bob"},+ "status": "completed",+ },+ )++ result = ctx.values["block"]+ # Overlapping keys use iteration 2's values+ assert result["extracted_information"] == {"name": "Bob"}+ assert result["status"] == "completed"+ # Old-only keys are preserved+ assert result["extra_field"] == "only_in_iter1"