Skip to content

Automate browser based workflows with AI

feat(SKY-11649): studio editor uses build mode (inline collapsible blocks) (#6982)

Celal Zamanoğlufbfe3abffdf5
diff --git a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
index 8f705fc36..7bd6571eb 100644
--- a/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
@@ -92,6 +92,7 @@ import {
WorkflowBlockNode,
} from "./nodes";
import { GlobalCollapseControl } from "./collapse/GlobalCollapseControl";
+import { useNodeCollapseStore } from "./collapse/useNodeCollapseStore";
import { isHeightCollapseAnimation } from "./collapse/collapseRelayoutAnimations";
import { WorkflowScopeContext } from "./WorkflowScopeContext";
import { FitViewControl } from "./controls/FitViewControl";
@@ -2027,10 +2028,18 @@ function FlowRenderer({
return;
}
setSelectedBlockId(node.id);
- // Studio: a deliberate block click expands the persistent
- // settings panel (it starts collapsed on open).
+ // Studio's embedded editor uses build mode, so a block click reveals
+ // its inline editor (the header chevron still collapses it).
if (embedded) {
setSettingsCollapsed(false);
+ if (isWorkflowBlockNode(appNode)) {
+ useNodeCollapseStore
+ .getState()
+ .expandBlock(
+ workflow.workflow_permanent_id ?? "__global__",
+ appNode.data.label,
+ );
+ }
}
}}
onPaneClick={() => {
diff --git a/skyvern-frontend/src/routes/workflows/editor/WorkflowAddMenu.tsx b/skyvern-frontend/src/routes/workflows/editor/WorkflowAddMenu.tsx
index 1271c502d..0c68d2021 100644
--- a/skyvern-frontend/src/routes/workflows/editor/WorkflowAddMenu.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/WorkflowAddMenu.tsx
@@ -89,8 +89,10 @@ function WorkflowAddMenu({
isUploadingSOP,
]);
- // Show menu in debug mode regardless of browser state
- if (!debugStore.isDebugMode) {
+ // The studio editor (/studio, blockRunsEnabled) surfaces these actions too;
+ // gating on blockRunsEnabled avoids flipping isDebugMode, which would lock the
+ // canvas zoom/pan. Mirrors NodeHeader's block-run gate.
+ if (!debugStore.isDebugMode && !debugStore.blockRunsEnabled) {
return <>{children}</>;
}
diff --git a/skyvern-frontend/src/routes/workflows/editor/__tests__/WorkflowAddMenu.test.tsx b/skyvern-frontend/src/routes/workflows/editor/__tests__/WorkflowAddMenu.test.tsx
index f7d045475..df5b6fe0c 100644
--- a/skyvern-frontend/src/routes/workflows/editor/__tests__/WorkflowAddMenu.test.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/__tests__/WorkflowAddMenu.test.tsx
@@ -46,6 +46,23 @@ function renderInDebugMode() {
);
}
+function renderWithScope(scope: {
+ isDebugMode: boolean;
+ blockRunsEnabled: boolean;
+}) {
+ return render(
+ <DebugStoreContext.Provider value={scope}>
+ <WorkflowAddMenu
+ onAdd={() => {}}
+ onRecord={() => {}}
+ onUploadSOP={() => {}}
+ >
+ <span>child</span>
+ </WorkflowAddMenu>
+ </DebugStoreContext.Provider>,
+ );
+}
+
function lastItems(): RadialMenuItem[] {
const calls = (radialMenuMock as Mock).mock.calls;
const last = calls[calls.length - 1];
@@ -111,3 +128,42 @@ describe("WorkflowAddMenu — Record Browser item visibility/enabled state", ()
expect(item?.enabled).toBe(false);
});
});
+
+describe("WorkflowAddMenu — menu visibility gate", () => {
+ beforeEach(() => {
+ radialMenuMock.mockClear();
+ });
+
+ afterEach(() => {
+ useSettingsStore.setState(initialSettings, true);
+ useRecordingStore.setState(initialRecording, true);
+ cleanup();
+ });
+
+ it("renders the radial menu in the studio editor (blockRunsEnabled) even when not in debug mode", () => {
+ useSettingsStore.getState().setIsUsingABrowser(true);
+ useSettingsStore.getState().setIsLoadingABrowser(false);
+ useRecordingStore.setState({ isRecording: false });
+
+ const { getByTestId } = renderWithScope({
+ isDebugMode: false,
+ blockRunsEnabled: true,
+ });
+
+ expect(getByTestId("radial-menu")).toBeDefined();
+ const items = lastItems();
+ expect(items.find((i) => i.text === "Upload SOP")).toBeDefined();
+ expect(recordBrowserItem(items)).toBeDefined();
+ });
+
+ it("hides the menu (renders only children) when neither debug nor studio block-runs are active", () => {
+ const { queryByTestId, getByText } = renderWithScope({
+ isDebugMode: false,
+ blockRunsEnabled: false,
+ });
+
+ expect(queryByTestId("radial-menu")).toBeNull();
+ expect(getByText("child")).toBeDefined();
+ expect(radialMenuMock).not.toHaveBeenCalled();
+ });
+});
diff --git a/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.test.tsx b/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.test.tsx
index a2cd3d811..acd2fe955 100644
--- a/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.test.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.test.tsx
@@ -97,6 +97,35 @@ describe("useNodeCollapseStore (SKY-9069 / SKY-9361)", () => {
});
});
+ test("expandBlock clears a collapsed label", () => {
+ const { toggleBlock, expandBlock } = useNodeCollapseStore.getState();
+ toggleBlock(WF, "alpha");
+ expect(useNodeCollapseStore.getState().collapsed[`${WF}\x1falpha`]).toBe(
+ true,
+ );
+ expandBlock(WF, "alpha");
+ expect(`${WF}\x1falpha` in useNodeCollapseStore.getState().collapsed).toBe(
+ false,
+ );
+ });
+
+ test("expandBlock is a no-op for an already-open block", () => {
+ const before = useNodeCollapseStore.getState().collapsed;
+ useNodeCollapseStore.getState().expandBlock(WF, "never-collapsed");
+ expect(useNodeCollapseStore.getState().collapsed).toBe(before);
+ });
+
+ test("expandBlock leaves other labels and workflows untouched", () => {
+ const { collapseAll, expandBlock } = useNodeCollapseStore.getState();
+ collapseAll("wf_other", ["x"]);
+ collapseAll(WF, ["a", "b"]);
+ expandBlock(WF, "a");
+ expect(useNodeCollapseStore.getState().collapsed).toEqual({
+ "wf_other\x1fx": true,
+ [`${WF}\x1fb`]: true,
+ });
+ });
+
test("pruneStaleLabels drops entries whose labels are no longer present", () => {
const { collapseAll, pruneStaleLabels } = useNodeCollapseStore.getState();
collapseAll("wf_other", ["keep"]);
diff --git a/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.ts b/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.ts
index 62c78b109..5d7a57481 100644
--- a/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.ts
+++ b/skyvern-frontend/src/routes/workflows/editor/collapse/useNodeCollapseStore.ts
@@ -19,6 +19,8 @@ import {
type NodeCollapseState = {
collapsed: Record<string, boolean>;
toggleBlock: (workflowId: string, blockLabel: string) => void;
+ // Idempotent expand: only removes the collapsed entry, never adds one.
+ expandBlock: (workflowId: string, blockLabel: string) => void;
collapseAll: (workflowId: string, labels: string[]) => void;
expandAll: (workflowId: string) => void;
// Moves a persisted entry from oldLabel to newLabel under the same
@@ -71,6 +73,14 @@ export const useNodeCollapseStore = create<NodeCollapseState>()(
}
return { collapsed: next };
}),
+ expandBlock: (workflowId, label) =>
+ set((s) => {
+ const k = key(workflowId, label);
+ if (!s.collapsed[k]) return s;
+ const next = { ...s.collapsed };
+ delete next[k];
+ return { collapsed: next };
+ }),
collapseAll: (workflowId, labels) =>
set((s) => {
const next = { ...s.collapsed };
diff --git a/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.test.tsx b/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.test.tsx
index df36ac39b..3400b1852 100644
--- a/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.test.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.test.tsx
@@ -4,11 +4,18 @@ import { renderHook } from "@testing-library/react";
import { MemoryRouter } from "react-router-dom";
import { describe, expect, test } from "vitest";
+import { WorkflowScopeContext } from "../WorkflowScopeContext";
import { useWorkflowEditorMode } from "./useWorkflowEditorMode";
-function wrapper(initial: string) {
+function wrapper(initial: string, readOnly = false) {
return ({ children }: { children: React.ReactNode }) => (
- <MemoryRouter initialEntries={[initial]}>{children}</MemoryRouter>
+ <MemoryRouter initialEntries={[initial]}>
+ <WorkflowScopeContext.Provider
+ value={{ workflowId: "wpid_abc", readOnly }}
+ >
+ {children}
+ </WorkflowScopeContext.Provider>
+ </MemoryRouter>
);
}
@@ -27,6 +34,20 @@ describe("useWorkflowEditorMode", () => {
expect(result.current).toBe("build");
});
+ test("returns 'build' for the studio editor at /workflows/wpid/studio", () => {
+ const { result } = renderHook(() => useWorkflowEditorMode(), {
+ wrapper: wrapper("/workflows/wpid_abc/studio"),
+ });
+ expect(result.current).toBe("build");
+ });
+
+ test("returns 'edit' for a read-only comparison canvas at /studio", () => {
+ const { result } = renderHook(() => useWorkflowEditorMode(), {
+ wrapper: wrapper("/workflows/wpid_abc/studio", true),
+ });
+ expect(result.current).toBe("edit");
+ });
+
test("returns 'build' for /workflows/wpid/runId/blockLabel/build", () => {
const { result } = renderHook(() => useWorkflowEditorMode(), {
wrapper: wrapper("/workflows/wpid_abc/wfr_xyz/block_1/build"),
@@ -46,6 +67,18 @@ describe("useWorkflowEditorMode", () => {
expect(subpath.current).toBe("edit");
});
+ test("recognizes /studio even with a trailing slash or subpath", () => {
+ const { result: trailing } = renderHook(() => useWorkflowEditorMode(), {
+ wrapper: wrapper("/workflows/wpid_abc/studio/"),
+ });
+ expect(trailing.current).toBe("build");
+
+ const { result: subpath } = renderHook(() => useWorkflowEditorMode(), {
+ wrapper: wrapper("/workflows/wpid_abc/studio/something"),
+ });
+ expect(subpath.current).toBe("build");
+ });
+
test("defaults to 'build' for paths that match neither", () => {
const { result } = renderHook(() => useWorkflowEditorMode(), {
wrapper: wrapper("/workflows/wpid_abc/runs"),
diff --git a/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.ts b/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.ts
index c6ead3395..73988eaa0 100644
--- a/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.ts
+++ b/skyvern-frontend/src/routes/workflows/editor/hooks/useWorkflowEditorMode.ts
@@ -1,14 +1,27 @@
import { useLocation } from "react-router-dom";
+import { useWorkflowScopeReadOnly } from "../WorkflowScopeContext";
+
type WorkflowEditorMode = "edit" | "build";
-// `/studio` (flag on) is the same edit surface legacy served at `/edit`, so both
-// map to 'edit'; anything else (`/build`, `/runs`, …) falls back to 'build'.
-const EDIT_PATH_PATTERN = /\/(?:edit|studio)(?:$|\/)/;
+// Legacy `/edit` always renders 'edit' (block config in a right-hand sidebar).
+// The Studio editor at `/studio` renders 'build' (inline collapsible blocks with
+// settings in the start node) — except its read-only comparison canvases, which
+// stay 'edit' so the copilot "review changes" diff view is unchanged. Everything
+// else (`/build`, `/runs`, …) is 'build'.
+const EDIT_PATH_PATTERN = /\/edit(?:$|\/)/;
+const STUDIO_PATH_PATTERN = /\/studio(?:$|\/)/;
function useWorkflowEditorMode(): WorkflowEditorMode {
const { pathname } = useLocation();
- return EDIT_PATH_PATTERN.test(pathname) ? "edit" : "build";
+ const readOnly = useWorkflowScopeReadOnly();
+ if (EDIT_PATH_PATTERN.test(pathname)) {
+ return "edit";
+ }
+ if (STUDIO_PATH_PATTERN.test(pathname)) {
+ return readOnly ? "edit" : "build";
+ }
+ return "build";
}
export { useWorkflowEditorMode, type WorkflowEditorMode };