AI media harness for planning, generating, and editing locally
TypeScript
Fix numeric field typing
Bitti99043bec6b5d
diff --git a/src/components/workspace/CommittedNumberInput.test.tsx b/src/components/workspace/CommittedNumberInput.test.tsxnew file mode 100644index 0000000..ca5878a--- /dev/null+++ b/src/components/workspace/CommittedNumberInput.test.tsx@@ -0,0 +1,38 @@+// @vitest-environment jsdom++import { cleanup, fireEvent, render, screen } from "@testing-library/react";+import { afterEach, describe, expect, it, vi } from "vitest";+import { CommittedNumberInput } from "./CommittedNumberInput";++afterEach(cleanup);++describe("keyboard-editable number fields", () => {+ it("keeps partial input visible until it becomes a valid transform value", () => {+ const commit = vi.fn();+ render(<CommittedNumberInput aria-label="Scale" value={100} minimum={10} maximum={400} onCommit={commit} />);+ const field = screen.getByRole("spinbutton", { name: "Scale" }) as HTMLInputElement;++ fireEvent.change(field, { target: { value: "" } });+ fireEvent.change(field, { target: { value: "1" } });+ expect(field.value).toBe("1");+ expect(commit).not.toHaveBeenCalled();++ fireEvent.change(field, { target: { value: "125" } });+ expect(field.value).toBe("125");+ expect(commit).toHaveBeenLastCalledWith(125);+ });++ it("clamps a finished edit and accepts a typed negative seed", () => {+ const commit = vi.fn();+ const view = render(<CommittedNumberInput aria-label="Seed" value={20} minimum={2} maximum={50} integer onCommit={commit} />);+ const field = screen.getByRole("spinbutton", { name: "Seed" }) as HTMLInputElement;+ fireEvent.change(field, { target: { value: "500" } });+ fireEvent.blur(field);+ expect(commit).toHaveBeenLastCalledWith(50);++ view.rerender(<CommittedNumberInput aria-label="Seed" value={-1} minimum={-1} maximum={Number.MAX_SAFE_INTEGER} integer onCommit={commit} />);+ fireEvent.change(field, { target: { value: "" } });+ fireEvent.change(field, { target: { value: "-1" } });+ expect(commit).toHaveBeenLastCalledWith(-1);+ });+});diff --git a/src/components/workspace/CommittedNumberInput.tsx b/src/components/workspace/CommittedNumberInput.tsxnew file mode 100644index 0000000..b9792fe--- /dev/null+++ b/src/components/workspace/CommittedNumberInput.tsx@@ -0,0 +1,56 @@+import { useEffect, useState, type InputHTMLAttributes } from "react";++/** A controlled number field that does not erase an in-progress keyboard edit.+ * Empty strings, a lone minus sign, and values below a minimum are legitimate+ * intermediate text; the parent only receives complete, valid numbers. */+export function CommittedNumberInput({ value, minimum, maximum, integer = false, onCommit, onChange: _onChange, onBlur: _onBlur, onKeyDown: _onKeyDown, ...input }: {+ value: number;+ minimum: number;+ maximum: number;+ integer?: boolean;+ onCommit: (value: number) => void;+} & Omit<InputHTMLAttributes<HTMLInputElement>, "value" | "min" | "max">) {+ const [draft, setDraft] = useState(String(value));++ useEffect(() => setDraft(String(value)), [value]);++ const valid = (text: string): number | null => {+ if (text.trim() === "") return null;+ const parsed = Number(text);+ if (!Number.isFinite(parsed) || (integer && !Number.isInteger(parsed))) return null;+ return parsed >= minimum && parsed <= maximum ? parsed : null;+ };++ const finish = () => {+ const parsed = Number(draft);+ if (!Number.isFinite(parsed) || draft.trim() === "") {+ setDraft(String(value));+ return;+ }+ const normalized = Math.max(minimum, Math.min(maximum, integer ? Math.round(parsed) : parsed));+ setDraft(String(normalized));+ onCommit(normalized);+ };++ return <input+ {...input}+ type="number"+ min={minimum}+ max={maximum}+ value={draft}+ onChange={(event) => {+ const next = event.currentTarget.value;+ setDraft(next);+ const parsed = valid(next);+ if (parsed !== null) onCommit(parsed);+ }}+ onBlur={finish}+ onKeyDown={(event) => {+ if (event.key === "Enter") event.currentTarget.blur();+ if (event.key === "Escape") {+ setDraft(String(value));+ event.currentTarget.blur();+ }+ }}+ />;+}diff --git a/src/components/workspace/SceneEditor.tsx b/src/components/workspace/SceneEditor.tsxindex 99d4cb9..c7ef638 100644--- a/src/components/workspace/SceneEditor.tsx+++ b/src/components/workspace/SceneEditor.tsx@@ -29,6 +29,7 @@ import {SHOT_TAG_GROUPS,type ShotTagSelection,} from "../../lib/shot-tags";+import { CommittedNumberInput } from "./CommittedNumberInput";/** What a reference chip carries when it is dragged into a shot's line. A* private type, so a file dragged in from the desktop is never mistaken for@@ -330,34 +331,28 @@ export function SceneInspector({ job, shots, disabled, onChange, onShots }: {<div className="scene-settings__numbers"><label className="scene-settings__field"><span>Steps</span>- <input- type="number"- min={2}- max={MAX_GENERATION_STEPS}+ <CommittedNumberInput+ minimum={2}+ maximum={MAX_GENERATION_STEPS}step={1}value={sceneGenerationSteps(job)}+ integerdisabled={disabled}aria-label="Generation step count"- onChange={(event) => {- const value = event.currentTarget.valueAsNumber;- if (Number.isInteger(value) && value >= 2 && value <= MAX_GENERATION_STEPS) onChange({ steps: value });- }}+ onCommit={(value) => onChange({ steps: value })}/></label><label className="scene-settings__field"><span>Seed</span>- <input- type="number"- min={-1}- max={Number.MAX_SAFE_INTEGER}+ <CommittedNumberInput+ minimum={-1}+ maximum={Number.MAX_SAFE_INTEGER}step={1}value={sceneGenerationSeed(job)}+ integerdisabled={disabled}aria-label="Generation seed"- onChange={(event) => {- const value = event.currentTarget.valueAsNumber;- if (Number.isSafeInteger(value) && value >= -1) onChange({ seed: value });- }}+ onCommit={(value) => onChange({ seed: value })}/><small>Use -1 for a random seed.</small></label>diff --git a/src/components/workspace/TimelineView.tsx b/src/components/workspace/TimelineView.tsxindex 115ce7e..7c3850e 100644--- a/src/components/workspace/TimelineView.tsx+++ b/src/components/workspace/TimelineView.tsx@@ -27,6 +27,7 @@ import { MediaThumbnail, type MeasuredMedia } from "./MediaThumbnail";import { ProgramMonitor } from "./ProgramMonitor";import { sceneShape, STATUS_WORD } from "./sceneStatus";import { ShotThumbnail } from "./ShotThumbnail";+import { CommittedNumberInput } from "./CommittedNumberInput";const MIN_DURATION = 10_000;/* How long a dropped clip is when the file itself cannot say.@@ -855,12 +856,12 @@ export function TimelineView({ config, folderPath, generationCompletionTimes = {<section className="inspector-section"><h3>Transform</h3><div className="field-pair">- <label><span>Scale (%)</span><input type="number" min="10" max="400" step="1" value={selectedTransform?.scale ?? 100} disabled={visualControlsDisabled} onChange={(event) => updateTransform("scale", Number(event.target.value))} /></label>- <label><span>Rotation (°)</span><input type="number" min="-180" max="180" step="1" value={selectedTransform?.rotation ?? 0} disabled={visualControlsDisabled} onChange={(event) => updateTransform("rotation", Number(event.target.value))} /></label>+ <label><span>Scale (%)</span><CommittedNumberInput minimum={10} maximum={400} step="1" value={selectedTransform?.scale ?? 100} disabled={visualControlsDisabled} onCommit={(value) => updateTransform("scale", value)} /></label>+ <label><span>Rotation (°)</span><CommittedNumberInput minimum={-180} maximum={180} step="1" value={selectedTransform?.rotation ?? 0} disabled={visualControlsDisabled} onCommit={(value) => updateTransform("rotation", value)} /></label></div><div className="field-pair">- <label><span>Position X (%)</span><input type="number" min="-100" max="100" step="1" value={selectedTransform?.positionX ?? 0} disabled={visualControlsDisabled} onChange={(event) => updateTransform("positionX", Number(event.target.value))} /></label>- <label><span>Position Y (%)</span><input type="number" min="-100" max="100" step="1" value={selectedTransform?.positionY ?? 0} disabled={visualControlsDisabled} onChange={(event) => updateTransform("positionY", Number(event.target.value))} /></label>+ <label><span>Position X (%)</span><CommittedNumberInput minimum={-100} maximum={100} step="1" value={selectedTransform?.positionX ?? 0} disabled={visualControlsDisabled} onCommit={(value) => updateTransform("positionX", value)} /></label>+ <label><span>Position Y (%)</span><CommittedNumberInput minimum={-100} maximum={100} step="1" value={selectedTransform?.positionY ?? 0} disabled={visualControlsDisabled} onCommit={(value) => updateTransform("positionY", value)} /></label></div></section><section className="inspector-section">