Skip to content

AI media harness for planning, generating, and editing locally

TypeScript

Move scene LoRAs into advanced options

Bittia52cd911d724
diff --git a/src/components/workspace/SceneEditor.tsx b/src/components/workspace/SceneEditor.tsx
index fd0c8ff..f043100 100644
--- a/src/components/workspace/SceneEditor.tsx
+++ b/src/components/workspace/SceneEditor.tsx
@@ -578,7 +578,7 @@ export function SceneInspector({ job, shots, references, folderPath = "", scenes
onCommit={(value) => onChange({ seed: value })}
/>
</PropRow>
- <PropRow label="Advanced options" htmlFor={`${id}-advanced-options`} tooltip="Show sigma shifts and a separate audio step count.">
+ <PropRow label="Advanced options" htmlFor={`${id}-advanced-options`} tooltip="Show sigma shifts, a separate audio step count and LoRAs.">
<ToggleSwitch id={`${id}-advanced-options`} aria-label="Advanced options" checked={job.audioSteps != null} disabled={disabled}
onChange={(checked) => onChange({ audioSteps: checked ? Math.min(sceneGenerationSteps(job, defaultSteps), MAX_AUDIO_GENERATION_STEPS) : undefined })} />
</PropRow>
@@ -589,8 +589,8 @@ export function SceneInspector({ job, shots, references, folderPath = "", scenes
value={job.audioSteps} integer disabled={disabled} aria-label="Audio step count" onCommit={(value) => onChange({ audioSteps: value })} />
</PropRow>
<SceneSigmaShift stream="audio" job={job} template={template} disabled={disabled} onChange={onChange} />
+ {generatorModel(template?.modelType).loras && <SceneLoras key={job.id} template={template} value={job.loraOverrides} disabled={disabled} onChange={(loraOverrides) => onChange({ loraOverrides })} />}
</>}
- {generatorModel(template?.modelType).loras && <SceneLoras key={job.id} template={template} value={job.loraOverrides} disabled={disabled} onChange={(loraOverrides) => onChange({ loraOverrides })} />}
</PropSection>
</div>
<GenerationEffects key={job.id} value={job.generationEffects} supported={generatorModel(template?.modelType).generationEffects} disabled={disabled} onChange={(generationEffects) => onChange({ generationEffects })} />
diff --git a/src/components/workspace/SceneLoras.test.tsx b/src/components/workspace/SceneLoras.test.tsx
index 8b762f2..160e00d 100644
--- a/src/components/workspace/SceneLoras.test.tsx
+++ b/src/components/workspace/SceneLoras.test.tsx
@@ -28,7 +28,7 @@ it("shows global LoRAs read only and adds, bypasses, edits and removes scene ove
expect(saved()).toEqual([{ loraId: "template", enabled: false, strength: 0.5 }]);
fireEvent.click(screen.getByRole("button", { name: "Remove Template override" }));
expect(screen.getByRole("checkbox", { name: "Enable scene LoRA Template" })).toBeChecked();
- fireEvent.click(screen.getByRole("button", { name: "Add LoRA override" }));
+ fireEvent.click(screen.getByRole("button", { name: "Add LoRA" }));
fireEvent.click(screen.getByRole("button", { name: "Style" }));
fireEvent.change(screen.getByRole("spinbutton", { name: "Style scene strength" }), { target: { value: "0.6" } });
expect(saved()).toEqual([{ loraId: "style", enabled: true, strength: 0.6 }]);
@@ -39,6 +39,6 @@ it("shows global LoRAs read only and adds, bypasses, edits and removes scene ove
it("disables adding recipes incompatible with global LoRAs", () => {
saveLoras([{ ...DMAD_LORA, path: "D:/dmad", globallyEnabled: true }]);
render(<Harness />);
- fireEvent.click(screen.getByRole("button", { name: "Add LoRA override" }));
+ fireEvent.click(screen.getByRole("button", { name: "Add LoRA" }));
expect(screen.getByRole("button", { name: PIKA_REF2VA_LORA.name })).toBeDisabled();
});
diff --git a/src/components/workspace/SceneLoras.tsx b/src/components/workspace/SceneLoras.tsx
index 2b08f18..d15534d 100644
--- a/src/components/workspace/SceneLoras.tsx
+++ b/src/components/workspace/SceneLoras.tsx
@@ -44,7 +44,7 @@ export function SceneLoras({ template, value, disabled = false, onChange }: {
</div>
</section>;
})}
- <button ref={trigger} className="secondary-button clip-effects__add" type="button" disabled={disabled || !available.length} aria-haspopup="dialog" aria-expanded={open} onClick={() => setOpen(!open)}><Add16 />Add LoRA override</button>
+ <button ref={trigger} className="secondary-button clip-effects__add" type="button" disabled={disabled || !available.length} aria-haspopup="dialog" aria-expanded={open} onClick={() => setOpen(!open)}><Add16 />Add LoRA</button>
<Flyout open={open && !disabled} anchor={trigger} onClose={() => setOpen(false)} aria-label="Available scene LoRAs" role="group" placement="top" width={260}>
<div className="clip-effects__picker">{available.map((lora) => {
const entry = { loraId: lora.id, enabled: true, strength: 1 };