Skip to content

AI media harness for planning, generating, and editing locally

TypeScript

Stop claiming a question was asked, and drop two stale justifications

Bittie88529f25364
diff --git a/src-tauri/src/lib.rs b/src-tauri/src/lib.rs
index 50ff490..a874109 100644
--- a/src-tauri/src/lib.rs
+++ b/src-tauri/src/lib.rs
@@ -85,8 +85,11 @@ struct ProjectAsset {
#[serde(default, skip_serializing_if = "Option::is_none")]
source_path: Option<String>,
mime_type: String,
- // zod spells these `.optional()` with no `.nullable()`, so an explicit
- // `null` is REJECTED by the frontend parser. The key has to stay absent.
+ // zod now spells these `.nullish()`, so an explicit `null` WOULD parse.
+ // Keep skipping anyway: it is the shape the fixtures pin, and it keeps the
+ // absent case unambiguous. Do not restate the old reason — the frontend
+ // rejecting null was true once and is the sort of stale justification this
+ // file's own rules warn about.
#[serde(skip_serializing_if = "Option::is_none")]
duration_ms: Option<u64>,
#[serde(skip_serializing_if = "Option::is_none")]
diff --git a/src/components/workspace/ExportView.tsx b/src/components/workspace/ExportView.tsx
index a0d6fa7..e667f39 100644
--- a/src/components/workspace/ExportView.tsx
+++ b/src/components/workspace/ExportView.tsx
@@ -258,7 +258,13 @@ export function ExportView({ config, folderPath }: { config: ProjectConfig; fold
[
"Video",
`${OUTPUT_CODECS.find((codec) => codec.id === settings.codec)?.label ?? settings.codec} in MP4`,
- codecProbe?.codecString ?? (probes ? "unsupported here" : "asking the encoder…"),
+ codecProbe?.codecString
+ ?? (probes ? "unsupported here"
+ /* The probe effect returns early with no clips and no encoder, so
+ "asking…" would be a progress claim for a question never put. */
+ : plan.frameCount === 0 ? "not asked — nothing to encode"
+ : !support.encoder ? "not asked — no encoder here"
+ : "asking the encoder…"),
],
["Bitrate", `${(bitrate / 1_000_000).toFixed(1)} Mbit/s`, qualityPreset(settings.quality).label],
[
diff --git a/src/lib/exportPipeline.ts b/src/lib/exportPipeline.ts
index e87b1e2..7f336d4 100644
--- a/src/lib/exportPipeline.ts
+++ b/src/lib/exportPipeline.ts
@@ -497,9 +497,10 @@ export interface AudioMix {
/** How far over full scale the mix has to go before clipping is worth a
* sentence: a tenth of a decibel.
*
- * Not an arbitrary tolerance. Measured in Chrome, a 16-bit sample decodes as
- * `value / 32767.5`, so two clips sitting at exactly half scale sum to
- * 1.0000305 — one 16-bit step over — and the old code called that "clipped"
+ * Not an arbitrary tolerance. Measured in Chrome: 16384 decodes as
+ * 0.500015258789 — close to `value / 32767.5` but not equal to it, so take the
+ * number and not the formula — and two clips sitting at exactly half scale sum
+ * to 1.0000305, one 16-bit step over. The old code called that "clipped"
* for every sample of the overlap while advising the user to pull down by
* "0.0 dB". Below a tenth of a decibel the advice this message gives rounds
* to nothing and the overshoot is 90 dB under the signal. The samples are