Skip to content

SmythOS Studio: Open-Source Visual AI Agent Builder and deployable runtime stack from SmythOS. Start with an intuitive drag-and-drop workspace, extend with custom code, and deploy your agents anywhere — local, cloud, or edge — with full governance and control.

Refactor: Improve event dispatching and confirm save logic in settings editor

Salman-Ahamed4c8dfeb57aaf
diff --git a/packages/app/src/builder-ui/components/Component.class/settings-editor.ts b/packages/app/src/builder-ui/components/Component.class/settings-editor.ts
index 7de5fe29..05ae259e 100644
--- a/packages/app/src/builder-ui/components/Component.class/settings-editor.ts
+++ b/packages/app/src/builder-ui/components/Component.class/settings-editor.ts
@@ -283,9 +283,11 @@ async function onSave(values) {
component.emit('settingsSaved', settingsValues);
// Also dispatch a global event for tracking
- document.dispatchEvent(new CustomEvent('componentSettingsSaved', {
- detail: { componentId: component.uid, settings: settingsValues }
- }));
+ document.dispatchEvent(
+ new CustomEvent('componentSettingsSaved', {
+ detail: { componentId: component.uid, settings: settingsValues },
+ }),
+ );
component.emit('settingsClosed');
//component.redrawSettings();
@@ -436,8 +438,8 @@ export async function editSettings(component: Component) {
const templateName = component.properties?.template?.templateInfo?.name || component.title || '';
const onBeforeCancel = async () => {
- const saved = await component.confirmSaveSettings();
- return true;
+ const canClose = await component.confirmSaveSettings();
+ return !!canClose;
};
const onCancel = () => {
@@ -853,9 +855,8 @@ export async function editSettings(component: Component) {
component.title = templateData.templateInfo.name;
component.description = templateData.templateInfo.description;
- component.domElement.querySelector(
- '.internal-name',
- ).textContent = `T: ${templateData.templateInfo.name}`;
+ component.domElement.querySelector('.internal-name').textContent =
+ `T: ${templateData.templateInfo.name}`;
const titleBar = component.domElement.querySelector('.title-bar');
if (titleBar) {
titleBar.querySelector('.title .text').textContent =