Skip to content

SmythOS Studio: Open-Source Visual AI Agent Builder and deployable runtime stack from SmythOS. Start with an intuitive drag-and-drop workspace, extend with custom code, and deploy your agents anywhere — local, cloud, or edge — with full governance and control.

Refactor: Improve type safety and performance in AgentInfoWidget and AgentSettings context

Muhammad Hamza Khan558ca5d4d1eb
diff --git a/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx b/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx
index d76e7274..8c92ac8f 100644
--- a/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx
+++ b/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx
@@ -22,7 +22,7 @@ interface AgentInfoWidgetAvatarProps {
tooltipText?: string;
}
const AgentInfoWidgetAvatar: React.FC<AgentInfoWidgetAvatarProps> = ({ data, tooltipText }) => {
- const { agentId, settingsQuery }: any = useAgentSettingsCtx();
+ const { agentId, settingsQuery } = useAgentSettingsCtx();
const queryClient = useQueryClient();
const uploadInputRef = React.useRef<HTMLInputElement>(null);
const [isLoading, setIsLoading] = React.useState(false);
@@ -50,7 +50,9 @@ const AgentInfoWidgetAvatar: React.FC<AgentInfoWidgetAvatarProps> = ({ data, too
if (event.detail?.agentId === agentId && event.detail?.avatarUrl) {
setCurrentAvatar(event.detail.avatarUrl);
// Invalidate the settings query to refresh the data
- queryClient.invalidateQueries(['agentSettings', agentId]);
+ queryClient.invalidateQueries({
+ queryKey: ['agentSettings', agentId],
+ });
}
};
diff --git a/packages/app/src/react/features/agent-settings/contexts/agent-settings.context.tsx b/packages/app/src/react/features/agent-settings/contexts/agent-settings.context.tsx
index b4935e2d..e20ca735 100644
--- a/packages/app/src/react/features/agent-settings/contexts/agent-settings.context.tsx
+++ b/packages/app/src/react/features/agent-settings/contexts/agent-settings.context.tsx
@@ -1,14 +1,14 @@
import { getAgent } from '@react/features/agent-settings/clients';
import { getAgentAuthData } from '@react/features/agent-settings/clients/agent-auth';
import { teamAPI } from '@react/features/teams/clients';
-import { Agent } from '@react/shared/types/agent-data.types';
+import { Agent, AgentSettings } from '@react/shared/types/agent-data.types';
import {
Deployment,
DeploymentWithAgentSnapshot,
TeamRoleWithMembers,
} from '@react/shared/types/api-results.types';
import { useQuery } from '@tanstack/react-query';
-import { createContext, FC, ReactNode, useContext, useEffect, useState } from 'react';
+import { createContext, FC, ReactNode, useCallback, useContext, useEffect, useState } from 'react';
import { useParams } from 'react-router';
import { useAgentSettings } from '@react/features/ai-chat/hooks/agent-settings';
@@ -48,7 +48,7 @@ interface AgentSettingsContextType {
}>
> | null;
agentId: string;
- settingsQuery: ReturnType<typeof useQuery<{ settings: { [key: string]: string } }>> | null;
+ settingsQuery: ReturnType<typeof useQuery<{ settings: AgentSettings }>> | null;
agentTestDomainQuery: ReturnType<typeof useQuery<string>> | null;
latestAgentDeploymentQuery: ReturnType<
typeof useQuery<{ deployment: DeploymentWithAgentSnapshot }>
@@ -69,7 +69,7 @@ const initialState: AgentSettingsContextType = {
latestAgentDeploymentQuery: null,
settingsQuery: null,
allDeploymentsQuery: null,
- refetchAllData: async () => {},
+ refetchAllData: async () => { },
serverStatusQuery: null,
serverStatusData: null,
agentAuthData: null,
@@ -264,7 +264,7 @@ export const AgentSettingsProvider: FC<AgentSettingsProviderProps> = ({
* Refetches all query data in the context
* Returns a promise that resolves when all refetch operations are complete
*/
- const refetchAllData = async (): Promise<void> => {
+ const refetchAllData = useCallback(async (): Promise<void> => {
const queries = [
agentQuery,
settingsQuery,
@@ -276,7 +276,7 @@ export const AgentSettingsProvider: FC<AgentSettingsProviderProps> = ({
].filter((query): query is NonNullable<typeof query> => query !== null);
await Promise.all(queries.map((query) => query.refetch()));
- };
+ }, [agentQuery, settingsQuery, teamRolesQuery, agentTestDomainQuery, latestAgentDeploymentQuery, allDeploymentsQuery, serverStatusQuery]);
// Attach the refetch function to window when the component mounts
useEffect(() => {
diff --git a/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.ts b/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.ts
index 0422f70d..52b8dfa1 100644
--- a/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.ts
+++ b/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.ts
@@ -28,7 +28,10 @@ export const agentOperationsSlice: StateCreator<BuilderStore, [], [], AgentOpera
if (response.ok) {
const data = await response.json();
if (data.url && window.workspace?.agent) {
- window.workspace.agent.emit('AvatarUpdated', data.url);
+ const timeoutId = setTimeout(() => {
+ window.workspace.agent.emit('AvatarUpdated', data.url);
+ clearTimeout(timeoutId);
+ }, 1000);
}
return true;
}