SmythOS Studio: Open-Source Visual AI Agent Builder and deployable runtime stack from SmythOS. Start with an intuitive drag-and-drop workspace, extend with custom code, and deploy your agents anywhere — local, cloud, or edge — with full governance and control.
JavaScript a2aagentic-aiai-agentsdevtoolsmcp-clientn8n-alternativeno-codeopen-sourceorchestrationsmythosvisual-builder
Fix/agent avatar generation blocks creation (#88)
Salman Ahamed61ddf328f8f4
diff --git a/packages/app/src/backend/routes/api/agent/router.ts b/packages/app/src/backend/routes/api/agent/router.tsindex 4e9d19c1..62901436 100644--- a/packages/app/src/backend/routes/api/agent/router.ts+++ b/packages/app/src/backend/routes/api/agent/router.ts@@ -1,6 +1,5 @@import express from 'express';import { includeTeamDetails } from '../../../middlewares/auth.mw';-import { autoGenerateAvatarForAgent } from '../../../services/falai-helper';import * as openai from '../../../services/openai-helper';import * as userData from '../../../services/user-data.service';const router = express.Router();@@ -10,7 +9,6 @@ router.post('/', [includeTeamDetails], async (req, res) => {const userId = req?._user?.id;const userName = req?._user?.name || req?._user?.email;const teamId = req?._team?.id;- let avatar;if (!userId) {return res.status(400).json({ success: false, error: 'User not found' });@@ -23,24 +21,15 @@ router.post('/', [includeTeamDetails], async (req, res) => {return res.status(400).json({ success: false, error: result.error.message });}- const beforeAvatarGenerationTimestamp = Date.now();-- try {- // #region TODO: move this responsibility to the caller- const existingAvatar = await userData.getAgentSettings(req, result.id, 'avatar');- if (!existingAvatar && hasAvatar !== true) {- avatar = await autoGenerateAvatarForAgent(req, result.id, req._team.id);- }- } catch (error) {- console.error('Error handling avatar generation:', error);- }-- const afterAvatarGenerationTimestamp = Date.now();- console.log(- `Avatar generation took ${afterAvatarGenerationTimestamp - beforeAvatarGenerationTimestamp}ms`,- );-- return res.send({ success: true, id: result.id, name: result.name, avatar });+ // Return immediately after agent creation with avatar status information+ // Avatar will be generated asynchronously on client side+ return res.send({+ success: true,+ id: result.id,+ name: result.name,+ avatarStatus: 'pending',+ avatarUrl: null,+ });});router.delete('/:id', async (req, res) => {diff --git a/packages/app/src/builder-ui/Agent.class.ts b/packages/app/src/builder-ui/Agent.class.tsindex afdd5b0f..307fd630 100644--- a/packages/app/src/builder-ui/Agent.class.ts+++ b/packages/app/src/builder-ui/Agent.class.ts@@ -188,16 +188,6 @@ export class Agent extends EventEmitter {this.configureEmbodimentsStates(result.id);}if (result.success) {- // Backend returns the avatar, when the first avatar is created- if (result.avatar) {- // Trigger the event to update the avatar, it will work if the agent card is rendered- if (window.workspace?.agent) {- window.workspace.agent.emit('AvatarUpdated', result.avatar);- }-- // Save the avatar to local storage, in case the agent card is not rendered- window.sessionStorage.setItem(`agent-avatar-${result.id}`, result.avatar);- }//this.setAgentInfo(result.id, name, data);return { id: result.id, name, domain, data };}diff --git a/packages/app/src/builder-ui/components/AgentCard.class.ts b/packages/app/src/builder-ui/components/AgentCard.class.tsindex a7cb84b8..ce8f9ba7 100644--- a/packages/app/src/builder-ui/components/AgentCard.class.ts+++ b/packages/app/src/builder-ui/components/AgentCard.class.ts@@ -668,11 +668,43 @@ export class AgentCard extends EventEmitter {});this.workspace.agent.addEventListener('AvatarUpdated', (url: string) => {+ // Update agent card avatarconst cardAgentAvatarElm: HTMLImageElement | null =document.querySelector('#agent-card-avatar');if (cardAgentAvatarElm) {cardAgentAvatarElm.src = url;+ cardAgentAvatarElm.classList.remove('hidden');}++ // Hide the placeholder when avatar is available+ const agentImagePlaceholder: HTMLDivElement | null = document.querySelector(+ '#agent-card-avatar-placeholder',+ );+ if (agentImagePlaceholder) {+ agentImagePlaceholder.classList.add('hidden');+ }++ // Update builder topbar avatar+ const topbarAvatarElm: HTMLImageElement | null = document.querySelector('#agent-avatar');+ if (topbarAvatarElm) {+ topbarAvatarElm.src = url;+ }++ // Update any other avatar elements in the builder+ const allAvatarElements = document.querySelectorAll('[data-agent-avatar]');+ allAvatarElements.forEach((element: HTMLImageElement) => {+ element.src = url;+ });++ // Save to session storage for persistence+ if (this.workspace.agent?.id) {+ window.sessionStorage.setItem(`agent-avatar-${this.workspace.agent.id}`, url);+ }++ // Trigger a custom event for React components to listen to+ window.dispatchEvent(new CustomEvent('agentAvatarUpdated', {+ detail: { agentId: this.workspace.agent?.id, avatarUrl: url }+ }));});}diff --git a/packages/app/src/builder-ui/workspace/Workspace.class.ts b/packages/app/src/builder-ui/workspace/Workspace.class.tsindex e7c19da4..2add2407 100644--- a/packages/app/src/builder-ui/workspace/Workspace.class.ts+++ b/packages/app/src/builder-ui/workspace/Workspace.class.ts@@ -403,7 +403,10 @@ export class Workspace extends EventEmitter {}).then(async (response) => {if (!response.ok) {- console.error('[Workspace.getOAuthConnections] Error fetching OAuth connections:', response.status);+ console.error(+ '[Workspace.getOAuthConnections] Error fetching OAuth connections:',+ response.status,+ );throw new Error(`Failed to fetch OAuth connections: ${response.status}`);}const data = await response.json();@@ -467,7 +470,7 @@ export class Workspace extends EventEmitter {if (sourceBR.right > targetBR.left) {const cornerRadius =sourceComponentBR.left - targetComponentBR.left > 100 &&- sourceComponentBR.top - targetComponentBR.bottom > 100+ sourceComponentBR.top - targetComponentBR.bottom > 100? 80: 30;@@ -782,7 +785,17 @@ export class Workspace extends EventEmitter {//this._agent = {}; //reset agentthis.agent.resetData();if (typeof callback === 'function') callback(data); //this can be used to preload agent template or other information- return this.saveAgent(name, '', data);+ const result = await this.saveAgent(name, '', data);++ // Generate avatar for the new agent (non-blocking)+ if (result && result.id) {+ const { generateAgentAvatar } = builderStore.getState();+ generateAgentAvatar(result.id).catch((error) => {+ console.warn('Avatar generation failed for new agent:', error);+ });+ }++ return result;}private setAgentInfo(id, name, domain, data) {@@ -968,7 +981,7 @@ export class Workspace extends EventEmitter {smoothScroll: true,duration: 300,easing: 'ease-out',- handleStartEvent(e) { },+ handleStartEvent(e) {},});const parent = zoom.parentElement;@@ -1174,7 +1187,7 @@ export class Workspace extends EventEmitter {components.forEach((component) => {try {this.componentTemplates[component.id] = JSON.parse(component.data);- } catch (error) { }+ } catch (error) {}});}private async initServerData() {diff --git a/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx b/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsxindex 22fca1cd..d76e7274 100644--- a/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx+++ b/packages/app/src/react/features/agent-settings/components/AgentInfoWidget/Avatar.tsx@@ -39,13 +39,28 @@ const AgentInfoWidgetAvatar: React.FC<AgentInfoWidgetAvatarProps> = ({ data, toouseEffect(function syncAvatar() {- setCurrentAvatar(- settingsQuery?.data?.settings?.[EAgentSettings.AVATAR] ?? null,- );+ setCurrentAvatar(settingsQuery?.data?.settings?.[EAgentSettings.AVATAR] ?? null);},[settingsQuery?.data],);+ // Listen for avatar updates from the builder+ useEffect(() => {+ const handleAvatarUpdate = (event: CustomEvent) => {+ if (event.detail?.agentId === agentId && event.detail?.avatarUrl) {+ setCurrentAvatar(event.detail.avatarUrl);+ // Invalidate the settings query to refresh the data+ queryClient.invalidateQueries(['agentSettings', agentId]);+ }+ };++ window.addEventListener('agentAvatarUpdated', handleAvatarUpdate as EventListener);++ return () => {+ window.removeEventListener('agentAvatarUpdated', handleAvatarUpdate as EventListener);+ };+ }, [agentId, queryClient]);+// TODO: move these mutations to a separate fileconst uploadAvatar = useMutation({mutationKey: ['uploadAvatar', agentId],@@ -193,7 +208,7 @@ const AgentInfoWidgetAvatar: React.FC<AgentInfoWidgetAvatarProps> = ({ data, toosetCurrentAvatar(json.url);updateSettingsCache(json.url);- if (window.workspace?.agent) {+ if (window.workspace?.agent) {window.workspace.agent.emit('AvatarUpdated', json.url);}}diff --git a/packages/app/src/react/features/agents/components/agentCard/AgentCard.tsx b/packages/app/src/react/features/agents/components/agentCard/AgentCard.tsxindex c4011430..37373a85 100644--- a/packages/app/src/react/features/agents/components/agentCard/AgentCard.tsx+++ b/packages/app/src/react/features/agents/components/agentCard/AgentCard.tsx@@ -6,7 +6,13 @@ import { AgentActivityModal } from '@src/react/features/agents/components/agentCimport { AgentContributorsModal } from '@src/react/features/agents/components/agentCard/modals/AgentContributorsModal';import { AgentDeleteConfirmationModal } from '@src/react/features/agents/components/agentCard/modals/AgentDeleteConfirmationModal';import { IAgent } from '@src/react/features/agents/components/agentCard/types';-import { ChatIconWithTail, PencilIcon, PinIcon, PinIconSlim, UnPinIcon } from '@src/react/shared/components/svgs';+import {+ ChatIconWithTail,+ PencilIcon,+ PinIcon,+ PinIconSlim,+ UnPinIcon,+} from '@src/react/shared/components/svgs';import { Button } from '@src/react/shared/components/ui/newDesign/button';import { useAuthCtx } from '@src/react/shared/contexts/auth.context';import { FEATURE_FLAGS } from '@src/shared/constants/featureflags';@@ -234,16 +240,20 @@ export function AgentCard({ agent, loadAgents, updateAgentInPlace }: AgentCardPr<FaCircleNotch className="mr-3 h-4 w-4 animate-spin" />) : (<div className="relative mr-3 h-4 w-4">- {agent.isPinned ?- <UnPinIcon className="h-4 w-4" /> :- <PinIcon className="h-4 w-4" />- }+ {agent.isPinned ? (+ <UnPinIcon className="h-4 w-4" />+ ) : (+ <PinIcon className="h-4 w-4" />+ )}</div>)}- {cardState.isPinning- ? (agent.isPinned ? 'Unpinning...' : 'Pinning...')- : (agent.isPinned ? 'Unpin Agent' : 'Pin Agent')- }+ {cardState.isPinning+ ? agent.isPinned+ ? 'Unpinning...'+ : 'Pinning...'+ : agent.isPinned+ ? 'Unpin Agent'+ : 'Pin Agent'}</button>)}</Menu.Item>diff --git a/packages/app/src/react/features/agents/components/agentCard/hooks/useAgentOperations.ts b/packages/app/src/react/features/agents/components/agentCard/hooks/useAgentOperations.tsindex 0bb79911..36532207 100644--- a/packages/app/src/react/features/agents/components/agentCard/hooks/useAgentOperations.ts+++ b/packages/app/src/react/features/agents/components/agentCard/hooks/useAgentOperations.ts@@ -1,6 +1,7 @@import { DuplicateAgentResponse, IAgent } from '@react/features/agents/components/agentCard/types';import { accquireLock } from '@react/features/agents/utils';import { useAgent, useAgentMutations } from '@react/shared/hooks/agent';+import { builderStore } from '@src/shared/state_stores/builder/store';import { useCallback } from 'react';import { toast } from 'react-toastify';@@ -18,22 +19,6 @@ interface UseAgentOperationsResult {isLoading: boolean;}-/**- * Handles avatar generation for a newly created agent- */-const generateAgentAvatar = async (agentId: string): Promise<boolean> => {- try {- const response = await fetch(- `/api/page/agent_settings/ai-agent/${agentId}/avatar/auto-generate`,- { method: 'POST' },- );- return response.ok;- } catch (error) {- console.error('Avatar generation failed:', error);- return false;- }-};-/*** Custom hook for handling agent operations (duplicate, delete)*/@@ -81,6 +66,7 @@ export function useAgentOperations({}// Generate avatar for the new agent (non-blocking)+ const { generateAgentAvatar } = builderStore.getState();const avatarGenerated = await generateAgentAvatar(newAgent.id);if (!avatarGenerated) {console.warn('Avatar generation failed for duplicated agent');@@ -204,10 +190,9 @@ export function useAgentOperations({toast.success(`Agent ${newPinnedState ? 'pinned' : 'unpinned'} successfully`);// Update the agent in place instead of reloading the entire listonAgentPinned?.(updatedAgent);-} catch (error) {console.error('Failed to pin/unpin agent:', error);-+// Check if error has a message, if not use generic errorif (error && typeof error === 'object' && 'message' in error) {toast.error(error.message);diff --git a/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.ts b/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.tsnew file mode 100644index 00000000..0422f70d--- /dev/null+++ b/packages/app/src/shared/state_stores/builder/slices/agent_operations.slice.ts@@ -0,0 +1,43 @@+import { StateCreator } from 'zustand';+import { Slice } from '../..';+import { BuilderStore } from '../store'; // important: import the final store type++export interface AgentOperationsSlice extends Slice {+ /**+ * Handles avatar generation for a newly created agent+ */+ generateAgentAvatar: (agentId: string) => Promise<boolean>;+}++// Add all 3 args: set, get, store+export const agentOperationsSlice: StateCreator<BuilderStore, [], [], AgentOperationsSlice> = (+ set,+ get,+ store,+) => ({+ /**+ * Handles avatar generation for a newly created agent+ */+ generateAgentAvatar: async (agentId: string): Promise<boolean> => {+ try {+ const response = await fetch(+ `/api/page/agent_settings/ai-agent/${agentId}/avatar/auto-generate`,+ { method: 'POST' },+ );++ if (response.ok) {+ const data = await response.json();+ if (data.url && window.workspace?.agent) {+ window.workspace.agent.emit('AvatarUpdated', data.url);+ }+ return true;+ }+ return false;+ } catch (error) {+ console.error('Avatar generation failed:', error);+ return false;+ }+ },++ init: async () => {},+});diff --git a/packages/app/src/shared/state_stores/builder/store.ts b/packages/app/src/shared/state_stores/builder/store.tsindex d0e7d4f8..25cfc179 100644--- a/packages/app/src/shared/state_stores/builder/store.ts+++ b/packages/app/src/shared/state_stores/builder/store.ts@@ -1,18 +1,20 @@// builderStore.tsimport { devtools } from 'zustand/middleware';import { createAppStore } from '..';+import { AgentOperationsSlice, agentOperationsSlice } from './slices/agent_operations.slice';import { BaseSlice, baseSlice } from './slices/base.slice';import { OAuthSlice, oauthSlice } from './slices/oauth.slice';import { ServerStatusSlice, serverStatusSlice } from './slices/server_status.slice';export type BuilderStore = ServerStatusSlice &BaseSlice &- OAuthSlice & {+ OAuthSlice &+ AgentOperationsSlice & {init: () => Promise<void>;};export const builderStore = createAppStore<BuilderStore>({name: 'builder',- slices: [serverStatusSlice, baseSlice, oauthSlice],+ slices: [serverStatusSlice, baseSlice, oauthSlice, agentOperationsSlice],middlewares: [devtools],});