Skip to content

SmythOS Studio: Open-Source Visual AI Agent Builder and deployable runtime stack from SmythOS. Start with an intuitive drag-and-drop workspace, extend with custom code, and deploy your agents anywhere — local, cloud, or edge — with full governance and control.

feat: add telemetry page route and refactor sidebar access control and enhance query parameter handling

SyedZawwarAhmed977f707375cf
diff --git a/packages/app/src/react/shared/components/sidebar/Sidebar.tsx b/packages/app/src/react/shared/components/sidebar/Sidebar.tsx
index bfd2784b..1b76897e 100644
--- a/packages/app/src/react/shared/components/sidebar/Sidebar.tsx
+++ b/packages/app/src/react/shared/components/sidebar/Sidebar.tsx
@@ -33,16 +33,17 @@ export const Sidebar: React.FC = () => {
const { data: userSettings, isLoading: isUserSettingsLoading } = useGetUserSettings(
userSettingKeys.USER_TEAM,
);
- const access = {};
- access['/vault'] = getPageAccess('/vault')?.read;
- access['/agents'] = getPageAccess('/agents')?.read;
- access['/templates'] = getPageAccess('/templates')?.read;
- access['/domains'] = getPageAccess('/domains')?.read;
- access['/data/'] = getPageAccess('/data')?.read;
- access['/data-pool'] = getPageAccess('/data')?.read;
- // access['/data-pool'] = getPageAccess('/data-pool')?.read || true; // Default to true for community edition
- access['/analytics'] = getPageAccess('/analytics')?.read;
- access['/teams/settings'] = getPageAccess('/teams/members')?.read;
+ const resolveAccessPath = (url: string) => {
+ // Normalize trailing slashes (e.g. '/data/' should match '/data' ACL)
+ const normalized = url.endsWith('/') && url.length > 1 ? url.slice(0, -1) : url;
+
+ // Some UI routes map to different ACL keys
+ if (normalized === '/teams/settings') return '/teams/members';
+ if (normalized === '/data-pool') return '/data';
+
+ return normalized;
+ };
+
const currentTeam = userTeams?.find((team) => team.id === userSettings?.userSelectedTeam);
const { data: companyLogo } = useGetTeamSettings(teamSettingKeys.COMPANY_LOGO);
@@ -50,13 +51,14 @@ export const Sidebar: React.FC = () => {
currentTeam?.parentId && companyLogo?.url && getPageAccess('/teams/members')?.read;
const menuItems = getSidebarMenuItems().filter((item) => {
+ const canRead = getPageAccess(resolveAccessPath(item.url))?.read;
const isVisible =
typeof item.visible === 'boolean'
? item.visible
: typeof item.visible === 'function'
? item.visible(currentTeam)
: true;
- return access[item.url] && isVisible;
+ return Boolean(canRead) && isVisible;
});
// if (currentTeam && currentTeam.parentId) {
// // if it is SUBTEAM team, add subTeamsMenuItems to menuItems
diff --git a/packages/app/src/shared/constants/acl.constant.json b/packages/app/src/shared/constants/acl.constant.json
index 0cb96ccf..99e0d189 100644
--- a/packages/app/src/shared/constants/acl.constant.json
+++ b/packages/app/src/shared/constants/acl.constant.json
@@ -1,63 +1,255 @@
{
"page": {
- "/css": { "access": "rw", "name": "css", "internal": true },
- "/js": { "access": "rw", "name": "js", "internal": true },
- "/error": { "access": "r", "name": "Error", "internal": true },
- "/metroui": { "access": "rw", "name": "metroui", "internal": true },
- "/img": { "access": "rw", "name": "img", "internal": true },
- "/favicon.ico": { "access": "rw", "name": "favicon", "internal": true },
- "/accept-invitation": { "access": "rw", "name": "Accept Invitation", "internal": true },
- "/teams/accept-invitation": { "access": "rw", "name": "Accept Invitation", "internal": true },
- "/subscriptions": { "access": "rw", "name": "subscriptions", "internal": true },
- "/_auth": { "access": "rw", "name": "Auth", "internal": true },
- "/oauth2": { "access": "r", "name": "OAuth2", "internal": true },
- "/doc": { "access": "r", "name": "Documentation", "internal": true },
-
- "/grafana": { "access": "r", "name": "Grafana", "internal": true },
- "/": { "access": "r", "redirect": "/agents", "name": "Agents", "internal": true },
-
- "/agents": { "access": "", "name": "Agents List" },
- "/agent-settings": { "access": "", "name": "Agent Settings" },
- "/builder": { "access": "", "name": "Agent Builder" },
- "/newagent": { "access": "", "name": "Basic Agent Builder", "internal": true },
- "/templates": { "access": "", "name": "Templates" },
- "/domains": { "access": "", "name": "Domains" },
- "/data": { "access": "", "name": "Data Pool" },
- "/data-pool": { "access": "", "name": "Data Pool" },
- "/vault": { "access": "", "name": "Vault" },
- "/analytics": { "access": "", "name": "Analytics" },
- "/my-plan": { "access": "", "name": "My Plan" },
- "/onboard": { "access": "rw", "name": "Onboarding", "internal": true },
- "/welcome": { "access": "rw", "name": "Welcome", "internal": true },
-
- "/logs": { "access": "r", "name": "Logs", "internal": true },
-
- "/teams": { "access": "rw", "name": "Teams", "internal": true },
- "/teams/roles": { "access": "", "name": "Team Roles" },
- "/teams/members": { "access": "", "name": "Team Members" },
- "/plansframe": { "access": "rw", "name": "Plans Frame", "internal": true },
- "/plansframev2": { "access": "rw", "name": "Plans Frame", "internal": true },
- "/plansframev3": { "access": "rw", "name": "Plans Frame", "internal": true },
- "/enterprise": { "access": "rw", "name": "Enterprise Plan", "internal": true },
- "/account": { "access": "rw", "name": "Account", "internal": true },
- "/account-deleted": { "access": "r", "name": "Account Deleted", "internal": true },
- "/partners": { "access": "r", "name": "Partners", "internal": true },
- "/aiagents": { "access": "rw", "name": "AI Agents", "internal": true },
- "/chat": { "access": "rw", "name": "AI Chats", "internal": true },
- "/test_v2": { "access": "rw", "name": "Test V2", "internal": true },
-
- "/analyticsv2": { "access": "rw", "name": "Analytics", "internal": true },
- "/enterprise-t1": { "access": "rw", "name": "Enterprise T1", "internal": true },
- "/enterprise-t2": { "access": "rw", "name": "Enterprise T2", "internal": true },
- "/enterprise-t3": { "access": "rw", "name": "Enterprise T3", "internal": true },
- "/enterprise-t4": { "access": "rw", "name": "Enterprise T4", "internal": true },
- "/business-unlimited": { "access": "rw", "name": "Business Unlimited", "internal": true },
- "/plans-legacy": { "access": "rw", "name": "Plans", "internal": true }
+ "/css": {
+ "access": "rw",
+ "name": "css",
+ "internal": true
+ },
+ "/js": {
+ "access": "rw",
+ "name": "js",
+ "internal": true
+ },
+ "/error": {
+ "access": "r",
+ "name": "Error",
+ "internal": true
+ },
+ "/metroui": {
+ "access": "rw",
+ "name": "metroui",
+ "internal": true
+ },
+ "/img": {
+ "access": "rw",
+ "name": "img",
+ "internal": true
+ },
+ "/favicon.ico": {
+ "access": "rw",
+ "name": "favicon",
+ "internal": true
+ },
+ "/accept-invitation": {
+ "access": "rw",
+ "name": "Accept Invitation",
+ "internal": true
+ },
+ "/teams/accept-invitation": {
+ "access": "rw",
+ "name": "Accept Invitation",
+ "internal": true
+ },
+ "/subscriptions": {
+ "access": "rw",
+ "name": "subscriptions",
+ "internal": true
+ },
+ "/_auth": {
+ "access": "rw",
+ "name": "Auth",
+ "internal": true
+ },
+ "/oauth2": {
+ "access": "r",
+ "name": "OAuth2",
+ "internal": true
+ },
+ "/doc": {
+ "access": "r",
+ "name": "Documentation",
+ "internal": true
+ },
+ "/grafana": {
+ "access": "r",
+ "name": "Grafana",
+ "internal": true
+ },
+ "/": {
+ "access": "r",
+ "redirect": "/agents",
+ "name": "Agents",
+ "internal": true
+ },
+ "/agents": {
+ "access": "",
+ "name": "Agents List"
+ },
+ "/agent-settings": {
+ "access": "",
+ "name": "Agent Settings"
+ },
+ "/builder": {
+ "access": "",
+ "name": "Agent Builder"
+ },
+ "/newagent": {
+ "access": "",
+ "name": "Basic Agent Builder",
+ "internal": true
+ },
+ "/templates": {
+ "access": "",
+ "name": "Templates"
+ },
+ "/domains": {
+ "access": "",
+ "name": "Domains"
+ },
+ "/data": {
+ "access": "",
+ "name": "Data Pool"
+ },
+ "/data-pool": {
+ "access": "",
+ "name": "Data Pool"
+ },
+ "/vault": {
+ "access": "",
+ "name": "Vault"
+ },
+ "/analytics": {
+ "access": "",
+ "name": "Analytics"
+ },
+ "/my-plan": {
+ "access": "",
+ "name": "My Plan"
+ },
+ "/onboard": {
+ "access": "rw",
+ "name": "Onboarding",
+ "internal": true
+ },
+ "/welcome": {
+ "access": "rw",
+ "name": "Welcome",
+ "internal": true
+ },
+ "/logs": {
+ "access": "r",
+ "name": "Logs",
+ "internal": true
+ },
+ "/teams": {
+ "access": "rw",
+ "name": "Teams",
+ "internal": true
+ },
+ "/teams/roles": {
+ "access": "",
+ "name": "Team Roles"
+ },
+ "/teams/members": {
+ "access": "",
+ "name": "Team Members"
+ },
+ "/plansframe": {
+ "access": "rw",
+ "name": "Plans Frame",
+ "internal": true
+ },
+ "/plansframev2": {
+ "access": "rw",
+ "name": "Plans Frame",
+ "internal": true
+ },
+ "/plansframev3": {
+ "access": "rw",
+ "name": "Plans Frame",
+ "internal": true
+ },
+ "/enterprise": {
+ "access": "rw",
+ "name": "Enterprise Plan",
+ "internal": true
+ },
+ "/account": {
+ "access": "rw",
+ "name": "Account",
+ "internal": true
+ },
+ "/account-deleted": {
+ "access": "r",
+ "name": "Account Deleted",
+ "internal": true
+ },
+ "/partners": {
+ "access": "r",
+ "name": "Partners",
+ "internal": true
+ },
+ "/aiagents": {
+ "access": "rw",
+ "name": "AI Agents",
+ "internal": true
+ },
+ "/chat": {
+ "access": "rw",
+ "name": "AI Chats",
+ "internal": true
+ },
+ "/test_v2": {
+ "access": "rw",
+ "name": "Test V2",
+ "internal": true
+ },
+ "/analyticsv2": {
+ "access": "rw",
+ "name": "Analytics",
+ "internal": true
+ },
+ "/enterprise-t1": {
+ "access": "rw",
+ "name": "Enterprise T1",
+ "internal": true
+ },
+ "/enterprise-t2": {
+ "access": "rw",
+ "name": "Enterprise T2",
+ "internal": true
+ },
+ "/enterprise-t3": {
+ "access": "rw",
+ "name": "Enterprise T3",
+ "internal": true
+ },
+ "/enterprise-t4": {
+ "access": "rw",
+ "name": "Enterprise T4",
+ "internal": true
+ },
+ "/business-unlimited": {
+ "access": "rw",
+ "name": "Business Unlimited",
+ "internal": true
+ },
+ "/plans-legacy": {
+ "access": "rw",
+ "name": "Plans",
+ "internal": true
+ },
+ "/telemetry": {
+ "access": "",
+ "name": "Telemetry & Logs"
+ }
},
"api": {
- "/user": { "access": "", "name": "User API" },
- "/api": { "access": "", "name": "API" },
- "/api/enterprise": { "access": "", "name": "Enterprise API" },
- "/app": { "access": "r", "name": "App" }
+ "/user": {
+ "access": "",
+ "name": "User API"
+ },
+ "/api": {
+ "access": "",
+ "name": "API"
+ },
+ "/api/enterprise": {
+ "access": "",
+ "name": "Enterprise API"
+ },
+ "/app": {
+ "access": "r",
+ "name": "App"
+ }
}
}
diff --git a/packages/app/src/shared/constants/general.ts b/packages/app/src/shared/constants/general.ts
index 9c79d792..d4de1696 100644
--- a/packages/app/src/shared/constants/general.ts
+++ b/packages/app/src/shared/constants/general.ts
@@ -212,6 +212,7 @@ export const PAGE_TITLE_MAP: Record<string, string> = {
'/my-plan': 'Manage Subscription',
'/data': 'Data Pool',
'/vault': 'Vault',
+ '/telemetry': 'Telemetry & Logs',
'/account': 'Account',
'/teams/roles': 'Team Roles',
'/teams/members': 'User Management',
diff --git a/packages/app/src/shared/utils.ts b/packages/app/src/shared/utils.ts
index 9c9884dd..aa3f2587 100644
--- a/packages/app/src/shared/utils.ts
+++ b/packages/app/src/shared/utils.ts
@@ -15,7 +15,6 @@ export const hasAnyAccess = (currentAcls: object) => {
return aclsArray.some((acl) => acl.access !== '');
};
-
export const getInitials = (name: string, email: string) => {
return name ? name.charAt(0).toUpperCase() : email.charAt(0).toUpperCase();
};
@@ -85,3 +84,68 @@ export function isProdEnv() {
// this comes from rollup-fe.config.mjs
return process.env.NODE_ENV === 'production';
}
+
+/**
+ * Supported query param value types for safe URL serialization.
+ *
+ * Notes:
+ * - Arrays/objects are intentionally not supported to avoid ambiguous encoding.
+ * - `null`/`undefined` values should typically be omitted from query strings.
+ */
+export type QueryParamValue = string | number | boolean | null | undefined;
+
+/**
+ * Plain query params object shape.
+ */
+export type QueryParams = Record<string, QueryParamValue>;
+
+/**
+ * Builds a query string from a params object while omitting unset or invalid values.
+ *
+ * Omits:
+ * - `undefined` and `null`
+ * - empty strings (including whitespace-only)
+ * - literal strings 'undefined' and 'null' (common accidental coercions)
+ *
+ * @param params - Plain query params object.
+ * @returns Serialized query string WITHOUT the leading '?'.
+ */
+export const buildQueryString = (params: QueryParams | undefined): string => {
+ if (!params) return '';
+
+ const searchParams = new URLSearchParams();
+
+ for (const [key, rawValue] of Object.entries(params)) {
+ if (rawValue === undefined || rawValue === null) continue;
+
+ if (typeof rawValue === 'string') {
+ const trimmed = rawValue.trim();
+ if (trimmed.length === 0 || trimmed === 'undefined' || trimmed === 'null') continue;
+ searchParams.set(key, trimmed);
+ continue;
+ }
+
+ // Numbers/booleans are safe to stringify.
+ searchParams.set(key, `${rawValue}`);
+ }
+
+ return searchParams.toString();
+};
+
+/**
+ * Returns a URL with the provided query params appended (if any).
+ *
+ * - Uses `buildQueryString` to omit unset/invalid values.
+ * - Preserves existing query params on the base URL by appending with '&'.
+ *
+ * @param baseUrl - URL path or full URL.
+ * @param params - Query params to append.
+ * @returns `baseUrl` if no query params remain after sanitization; otherwise `baseUrl` with query.
+ */
+export const withQueryParams = (baseUrl: string, params: QueryParams | undefined): string => {
+ const queryString = buildQueryString(params);
+ if (queryString.length === 0) return baseUrl;
+
+ const joiner = baseUrl.includes('?') ? '&' : '?';
+ return `${baseUrl}${joiner}${queryString}`;
+};