SmythOS Studio: Open-Source Visual AI Agent Builder and deployable runtime stack from SmythOS. Start with an intuitive drag-and-drop workspace, extend with custom code, and deploy your agents anywhere — local, cloud, or edge — with full governance and control.
JavaScript a2aagentic-aiai-agentsdevtoolsmcp-clientn8n-alternativeno-codeopen-sourceorchestrationsmythosvisual-builder
Fix: 86ev8vj3z : Feedback Modal - Inconsistent Validation on Feedback Submission
samme-abdulaf325abe612e
diff --git a/packages/app/views/pages/partials/studio/feedback-modal.ejs b/packages/app/views/pages/partials/studio/feedback-modal.ejsindex 57e4592d..737c3486 100644--- a/packages/app/views/pages/partials/studio/feedback-modal.ejs+++ b/packages/app/views/pages/partials/studio/feedback-modal.ejs@@ -120,7 +120,8 @@<div class="flex justify-end gap-3"><buttonid="submitFeedback"- class="flex items-center justify-center font-normal border border-solid text-base px-8 py-2 text-center rounded-lg transition-all duration-200 outline-none focus:outline-none focus:ring-0 focus:ring-offset-0 focus:ring-shadow-none bg-smythos-blue-500 text-white border-transparent hover:bg-smyth-blue"+ class="flex items-center justify-center font-normal border border-solid text-base px-8 py-2 text-center rounded-lg transition-all duration-200 outline-none focus:outline-none focus:ring-0 focus:ring-offset-0 focus:ring-shadow-none bg-smythos-blue-500 text-white border-transparent hover:bg-smyth-blue disabled:opacity-50 disabled:cursor-not-allowed"+ disabled><span>Send</span><div id="submitLoader" class="hidden ml-2">@@ -162,9 +163,15 @@let selectedEmoji = null;+ function updateSubmitButton() {+ const hasText = feedbackTextarea?.value?.trim();+ submitFeedback.disabled = !(hasText && selectedEmoji);+ }+function openFeedbackModal() {feedbackModal?.classList.remove('hidden');document.body.style.overflow = 'hidden';+ updateSubmitButton();}function closeFeedbackModal() {@@ -174,13 +181,12 @@}function resetFeedbackForm() {- if (feedbackTextarea) {- feedbackTextarea.value = '';- }+ if (feedbackTextarea) feedbackTextarea.value = '';selectedEmoji = null;emojiButtons?.forEach((btn) => {btn.classList.remove('border-[#84CAFF]', 'bg-[#F5FAFF]', 'shadow-[0_0_0_4px_#EBF5FF]');});+ updateSubmitButton();}async function submitToHubSpot(feedbackData) {@@ -220,24 +226,17 @@submitLoader?.classList.remove('hidden');if (submitText) submitText.textContent = 'Sending...';} else {- if (submitBtn) submitBtn.disabled = false;if (cancelBtn) cancelBtn.disabled = false;submitLoader?.classList.add('hidden');if (submitText) submitText.textContent = 'Send';+ updateSubmitButton();}}function validateFeedback(text, emoji) {const errors = [];-- if (!text?.trim()) {- errors.push('Please enter your feedback');- }-- if (!emoji) {- errors.push('Please select an emoji');- }-+ if (!text?.trim()) errors.push('Please enter your feedback');+ if (!emoji) errors.push('Please select an emoji rating');return errors;}@@ -249,7 +248,9 @@const errors = validateFeedback(feedbackText, selectedEmoji);if (errors.length > 0) {- toast?.(`${errors.join(' and ')}`, 'Error', 'alert');+ if (typeof toast === 'function') {+ toast(`${errors.join(' and ')}`, 'Error', 'alert');+ }return;}@@ -266,9 +267,14 @@if (result && result.success) {closeFeedbackModal();- toast?.('Thank you for your feedback!', 'Success', 'success');+ if (typeof toast === 'function') {+ toast('Thank you for your feedback!', 'Success', 'success');+ }+ console.log('Feedback submitted successfully to HubSpot');} else {- toast?.('Failed to submit feedback. Please try again.', 'Error', 'alert');+ if (typeof toast === 'function') {+ toast('Failed to submit feedback. Please try again.', 'Error', 'alert');+ }console.error('Failed to submit feedback to HubSpot');}});@@ -280,9 +286,12 @@});button.classList.add('border-[#84CAFF]', 'bg-[#F5FAFF]', 'shadow-[0_0_0_4px_#EBF5FF]');selectedEmoji = button.dataset?.emoji;+ updateSubmitButton();});});+ feedbackTextarea?.addEventListener('input', updateSubmitButton);+feedbackModal?.addEventListener('click', (event) => {if (event?.target === feedbackModal) {closeFeedbackModal();