Skip to content

SmythOS Studio: Open-Source Visual AI Agent Builder and deployable runtime stack from SmythOS. Start with an intuitive drag-and-drop workspace, extend with custom code, and deploy your agents anywhere — local, cloud, or edge — with full governance and control.

fix upload handler middleware

Forhad Hosaincf7fcd91737c
diff --git a/packages/runtime/src/core/router-config.ts b/packages/runtime/src/core/router-config.ts
index f2161110..9f97f4fa 100644
--- a/packages/runtime/src/core/router-config.ts
+++ b/packages/runtime/src/core/router-config.ts
@@ -1,7 +1,5 @@
import { Express } from 'express';
-import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
-
import agentRunnerAgentLoader from '@agent-runner/middlewares/agentLoader.mw';
import agentRunnerOauthRouter from '@agent-runner/routes/_oauth/router';
import { processAgentRequest as agentRunnerProcessAgentRequest } from '@agent-runner/services/agent-request-handler';
@@ -60,13 +58,13 @@ export function configureAgentRouters(app: Express, runtimeConfig?: RuntimeConfi
const smartRouter = createConfiguredSmartRouter(
{
debugger: {
- middlewares: [uploadHandler, debuggerAgentLoader],
+ middlewares: [debuggerAgentLoader],
processAgentRequest: debuggerProcessAgentRequest,
getDebugSession: debuggerGetDebugSession,
createSseConnection: debuggerCreateSseConnection,
},
agentRunner: {
- middlewares: [uploadHandler, agentRunnerAgentLoader],
+ middlewares: [agentRunnerAgentLoader],
processAgentRequest: agentRunnerProcessAgentRequest,
},
},
@@ -84,7 +82,7 @@ export function configureAgentRouters(app: Express, runtimeConfig?: RuntimeConfi
if (config.routing.strategy === 'separate' || config.routing.strategy === 'smart') {
if (debuggerEnabled) {
console.log('Mounting debugger router');
- const debuggerRouter = createDebuggerRouter([uploadHandler, debuggerAgentLoader], debuggerProcessAgentRequest, {
+ const debuggerRouter = createDebuggerRouter([debuggerAgentLoader], debuggerProcessAgentRequest, {
getDebugSession: debuggerGetDebugSession,
createSseConnection: debuggerCreateSseConnection,
});
@@ -93,7 +91,7 @@ export function configureAgentRouters(app: Express, runtimeConfig?: RuntimeConfi
if (agentRunnerEnabled) {
console.log('Mounting agent-runner router');
- const agentRunnerRouter = createAgentRunnerRouter([uploadHandler, agentRunnerAgentLoader], agentRunnerProcessAgentRequest);
+ const agentRunnerRouter = createAgentRunnerRouter([agentRunnerAgentLoader], agentRunnerProcessAgentRequest);
app.use('/', agentRunnerRouter);
// Mount agent-runner-specific routes
diff --git a/packages/runtime/src/core/shared-agent-router.ts b/packages/runtime/src/core/shared-agent-router.ts
index 57812b5f..23bd895c 100644
--- a/packages/runtime/src/core/shared-agent-router.ts
+++ b/packages/runtime/src/core/shared-agent-router.ts
@@ -1,5 +1,6 @@
import { Logger } from '@smythos/sre';
import express from 'express';
+import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
interface AgentRouterConfig {
mode: 'debugger' | 'agent-runner';
@@ -32,7 +33,10 @@ function createAgentRouter(config: AgentRouterConfig): express.Router {
];
apiRoutes.forEach(({ method, path }) => {
- router[method](path, config.middlewares, async (req: any, res) => {
+ // Add uploadHandler to all API routes (matches old server pattern)
+ // Comment from old server: "uploadHandler should precede AgentLoader to parse multipart/form-data correctly"
+ const middlewares = [uploadHandler, ...config.middlewares];
+ router[method](path, middlewares, async (req: any, res) => {
try {
const agent = req._agent;
if (!agent) {
diff --git a/packages/runtime/src/core/smart-agent-router.ts b/packages/runtime/src/core/smart-agent-router.ts
index 30dd1647..ced20fcb 100644
--- a/packages/runtime/src/core/smart-agent-router.ts
+++ b/packages/runtime/src/core/smart-agent-router.ts
@@ -6,6 +6,7 @@
import { Logger } from '@smythos/sre';
import express from 'express';
+import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
import { v4 as uuidv4 } from 'uuid';
const console = Logger('[Smart Agent Router]');
@@ -131,10 +132,14 @@ function createSmartAgentRouter(dependencies: RouterDependencies): express.Route
const startTime = Date.now();
try {
- // Step 1: Make routing decision based on headers
+ // Step 1: Handle file uploads for all API requests (matches old server pattern)
+ // Comment from old server: "uploadHandler should precede AgentLoader to parse multipart/form-data correctly"
+ await runMiddleware(req, res, uploadHandler);
+
+ // Step 2: Make routing decision based on headers
const { useDebugger, reason } = shouldUseDebugger(req);
- // Step 2: Apply service-specific middleware (including upload handlers)
+ // Step 3: Apply service-specific middleware
const serviceMiddlewares = useDebugger ? dependencies.debugger.middlewares : dependencies.agentRunner.middlewares;
console.debug(`Applying ${serviceMiddlewares.length} ${useDebugger ? 'debugger' : 'agent-runner'} middleware(s)`, {
@@ -149,7 +154,7 @@ function createSmartAgentRouter(dependencies: RouterDependencies): express.Route
path: req.path,
});
- // Step 3: Process with appropriate service
+ // Step 4: Process with appropriate service
let result: any;
if (useDebugger) {
diff --git a/packages/runtime/src/index.ts b/packages/runtime/src/index.ts
index 8103cade..3d6109f2 100644
--- a/packages/runtime/src/index.ts
+++ b/packages/runtime/src/index.ts
@@ -15,7 +15,6 @@ import { startServers } from '@core/management-router';
import cors from '@core/middlewares/cors.mw';
import { errorHandler, notFoundHandler } from '@core/middlewares/error.mw';
import RateLimiter from '@core/middlewares/rateLimiter.mw';
-import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
import { requestContext } from '@core/services/request-context';
import { registerConnectors } from '@core/connectors/connectorRegistry';
@@ -35,6 +34,12 @@ const port = config.env.PORT;
registerConnectors();
const sre = SmythRuntime.Instance.init({
+ Storage: {
+ Connector: 'LocalStorage',
+ Settings: {
+ folder: config.env.DATA_PATH + '/tmp',
+ },
+ },
Cache: {
Connector: 'RAM',
Settings: {},
@@ -140,7 +145,6 @@ app.use(
}),
);
-app.use(uploadHandler);
app.use(RateLimiter);
app.use(express.json({ limit: '10mb' }));
app.use(express.urlencoded({ extended: false, limit: '100kb' }));
diff --git a/packages/runtime/src/modules/agent-runner/routes/agent/router.ts b/packages/runtime/src/modules/agent-runner/routes/agent/router.ts
index c14a466f..a5136450 100644
--- a/packages/runtime/src/modules/agent-runner/routes/agent/router.ts
+++ b/packages/runtime/src/modules/agent-runner/routes/agent/router.ts
@@ -1,12 +1,9 @@
import agentLoader from '@agent-runner/middlewares/agentLoader.mw';
import { processAgentRequest } from '@agent-runner/services/agent-request-handler';
-import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
import { createAgentRunnerRouter } from '@core/shared-agent-router';
-/* agentLoader must come before agentAuth because agentAuth relies on req._agent, set by agentLoader.
-Also, uploadHandler should precede agentLoader to parse multipart/form-data correctly */
-const middlewares = [uploadHandler, agentLoader];
+const middlewares = [agentLoader];
const router = createAgentRunnerRouter(middlewares, processAgentRequest);
diff --git a/packages/runtime/src/modules/debugger/routes/agent/routes.ts b/packages/runtime/src/modules/debugger/routes/agent/routes.ts
index d3dc0a2b..449c96f1 100644
--- a/packages/runtime/src/modules/debugger/routes/agent/routes.ts
+++ b/packages/runtime/src/modules/debugger/routes/agent/routes.ts
@@ -1,10 +1,8 @@
-import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
import { createDebuggerRouter } from '@core/shared-agent-router';
import agentLoader from '@debugger/middlewares/agentLoader.mw';
import { createSseConnection, getDebugSession, processAgentRequest } from '@debugger/services/agent-request-handler';
-/* uploadHandler should precede agentLoader to parse multipart/form-data correctly */
-const middlewares = [uploadHandler, agentLoader];
+const middlewares = [agentLoader];
const router = createDebuggerRouter(middlewares, processAgentRequest, {
getDebugSession,
diff --git a/packages/runtime/src/modules/embodiment/modules/chatbot/routes/router.ts b/packages/runtime/src/modules/embodiment/modules/chatbot/routes/router.ts
index e460a986..ca56f121 100644
--- a/packages/runtime/src/modules/embodiment/modules/chatbot/routes/router.ts
+++ b/packages/runtime/src/modules/embodiment/modules/chatbot/routes/router.ts
@@ -2,10 +2,10 @@ import axios from 'axios';
import express from 'express';
import { AccessCandidate, Agent, BinaryInput } from '@smythos/sre';
+import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
import config from '@core/config';
import { readAgentOAuthConfig } from '@core/helpers/agent.helper';
-import { uploadHandler } from '@core/middlewares/uploadHandler.mw';
import { EMBODIMENT_TYPES } from '@embodiment/constants';
import { getChatGPTManifest } from '@embodiment/helpers/chatgpt.helper';
diff --git a/packages/runtime/src/modules/embodiment/routes/index.ts b/packages/runtime/src/modules/embodiment/routes/index.ts
index d5411816..99a39c01 100644
--- a/packages/runtime/src/modules/embodiment/routes/index.ts
+++ b/packages/runtime/src/modules/embodiment/routes/index.ts
@@ -33,7 +33,7 @@ const defaultRoutes: Route[] = [
route: postmanRouter,
},
- // #region Swagger, we need both
+ // #region Swagger, we need both routers
{
rootPath: ['/swagger', '/emb/swagger'],
route: swaggerUi.serve,