A free open source IT asset/license management system
<?php
namespace Tests\Feature\Api\UnacceptedAcceptances;
use App\Models\Asset;
use App\Models\CheckoutAcceptance;
use App\Models\Company;
use App\Models\User;
use App\Notifications\UnacceptedAssetReminderNotification;
use Illuminate\Support\Facades\Notification;
use PHPUnit\Framework\Attributes\Test;
use Tests\TestCase;
/**
* API coverage for POST /api/v1/unaccepted-acceptances/send-reminders,
* the scheduler-friendly surface added for #19811.
*
* Shape:
* - no ids in body: delegates to the snipeit:acceptance-reminder
* console command (one grouped email per assignee).
* - ids in body: iterates each, applies FMCS, dispatches per-row.
*/
class SendRemindersApiTest extends TestCase
{
#[Test]
public function user_without_checkout_grant_is_rejected(): void
{
$this->actingAsForApi(User::factory()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'))
->assertForbidden();
}
#[Test]
public function missing_ids_sends_to_every_pending_assignee(): void
{
Notification::fake();
$userA = User::factory()->create(['email' => '[email protected]']);
$userB = User::factory()->create(['email' => '[email protected]']);
$userNoEmail = User::factory()->create(['email' => '']);
CheckoutAcceptance::factory()->pending()->count(2)->create(['assigned_to_id' => $userA->id]);
CheckoutAcceptance::factory()->pending()->create(['assigned_to_id' => $userB->id]);
CheckoutAcceptance::factory()->pending()->create(['assigned_to_id' => $userNoEmail->id]);
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'))
->assertOk()
->assertJsonPath('status', 'success')
->assertJsonPath('payload.mode', 'all')
->assertJsonPath('payload.sent', 2)
->assertJsonPath('payload.skipped.no_email', 1);
Notification::assertSentTo($userA, UnacceptedAssetReminderNotification::class);
Notification::assertSentTo($userB, UnacceptedAssetReminderNotification::class);
Notification::assertNotSentTo($userNoEmail, UnacceptedAssetReminderNotification::class);
}
#[Test]
public function empty_ids_array_also_sends_to_every_pending_assignee(): void
{
// Explicitly-empty array arrives from well-formed clients
// that always include the key. Should behave the same as a
// missing one.
Notification::fake();
$user = User::factory()->create(['email' => '[email protected]']);
CheckoutAcceptance::factory()->pending()->create(['assigned_to_id' => $user->id]);
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'), ['ids' => []])
->assertOk()
->assertJsonPath('payload.mode', 'all')
->assertJsonPath('payload.sent', 1);
Notification::assertSentTo($user, UnacceptedAssetReminderNotification::class);
}
#[Test]
public function ids_in_body_narrows_to_only_the_targeted_assignees(): void
{
// Verifies ids-mode doesn't accidentally mail every pending
// assignee the way the no-ids send-all path does.
Notification::fake();
$targeted = User::factory()->create(['email' => '[email protected]']);
$unrelated = User::factory()->create(['email' => '[email protected]']);
$targetedAcceptance = CheckoutAcceptance::factory()
->pending()
->for(Asset::factory(), 'checkoutable')
->for($targeted, 'assignedTo')
->create();
// Unrelated user has a pending acceptance that's NOT in the ids list.
CheckoutAcceptance::factory()
->pending()
->for(Asset::factory(), 'checkoutable')
->for($unrelated, 'assignedTo')
->create();
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'), ['ids' => [$targetedAcceptance->id]])
->assertOk()
->assertJsonPath('payload.mode', 'ids')
->assertJsonPath('payload.sent', 1);
Notification::assertSentTo($targeted, UnacceptedAssetReminderNotification::class);
Notification::assertNotSentTo($unrelated, UnacceptedAssetReminderNotification::class);
}
#[Test]
public function id_pointing_at_a_non_pending_acceptance_sends_nothing(): void
{
Notification::fake();
$assignee = User::factory()->create(['email' => '[email protected]']);
$asset = Asset::factory()->create();
$acceptance = CheckoutAcceptance::factory()
->for($asset, 'checkoutable')
->for($assignee, 'assignedTo')
->create(['accepted_at' => now()]);
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'), ['ids' => [$acceptance->id]])
->assertOk()
->assertJsonPath('payload.sent', 0);
Notification::assertNothingSent();
}
#[Test]
public function acceptance_without_assignee_email_sends_nothing(): void
{
Notification::fake();
$assignee = User::factory()->create(['email' => '']);
$asset = Asset::factory()->create();
$acceptance = CheckoutAcceptance::factory()
->pending()
->for($asset, 'checkoutable')
->for($assignee, 'assignedTo')
->create();
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'), ['ids' => [$acceptance->id]])
->assertOk()
->assertJsonPath('payload.sent', 0);
Notification::assertNothingSent();
}
#[Test]
public function fmcs_blocks_cross_company_ids_without_leaking_to_the_mail_queue(): void
{
Notification::fake();
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$assignee = User::factory()->create(['email' => '[email protected]']);
$assetInB = Asset::factory()->create(['company_id' => $companyB->id]);
$acceptance = CheckoutAcceptance::factory()
->pending()
->for($assetInB, 'checkoutable')
->for($assignee, 'assignedTo')
->create();
$callerInA = User::factory()
->checkoutAccessories()
->forCompany($companyA)
->create();
$this->actingAsForApi($callerInA)
->postJson(route('api.unaccepted-acceptances.send-reminders'), ['ids' => [$acceptance->id]])
->assertOk()
->assertJsonPath('payload.sent', 0);
Notification::assertNothingSent();
}
#[Test]
public function mixed_batch_sends_only_valid_rows(): void
{
Notification::fake();
$goodAssignee = User::factory()->create(['email' => '[email protected]']);
$noEmailAssignee = User::factory()->create(['email' => '']);
$goodAcceptance = CheckoutAcceptance::factory()
->pending()
->for(Asset::factory(), 'checkoutable')
->for($goodAssignee, 'assignedTo')
->create();
$noEmailAcceptance = CheckoutAcceptance::factory()
->pending()
->for(Asset::factory(), 'checkoutable')
->for($noEmailAssignee, 'assignedTo')
->create();
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'), [
'ids' => [$goodAcceptance->id, $noEmailAcceptance->id, 999999],
])
->assertOk()
->assertJsonPath('payload.sent', 1);
Notification::assertSentTimes(UnacceptedAssetReminderNotification::class, 1);
}
#[Test]
public function selecting_multiple_acceptances_for_one_user_dedupes_to_one_email(): void
{
// Regression pin for the dedupe behavior. A user with three
// pending acceptances who gets all three selected in the
// bulk UI should receive one UnacceptedAssetReminderNotification
// with count=3, not three separate emails.
Notification::fake();
$assignee = User::factory()->create(['email' => '[email protected]']);
$acceptances = CheckoutAcceptance::factory()->count(3)
->pending()
->for(Asset::factory(), 'checkoutable')
->for($assignee, 'assignedTo')
->create();
$this->actingAsForApi(User::factory()->superuser()->create())
->postJson(route('api.unaccepted-acceptances.send-reminders'), [
'ids' => $acceptances->pluck('id')->all(),
])
->assertOk()
->assertJsonPath('payload.sent', 1);
Notification::assertSentTimes(UnacceptedAssetReminderNotification::class, 1);
}
}