A free open source IT asset/license management system
Organization
Marcus Moore1cc7ef05439b
diff --git a/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php b/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.phpindex 3e17a983ed..c7f92b9023 100644--- a/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php+++ b/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php@@ -19,6 +19,10 @@ class LicenseSeatUpdateTest extends TestCase->assertForbidden();}+ /**************************************************************************+ * Validation+ **************************************************************************/+/*** @link [rb-20713]*/@@ -117,37 +121,68 @@ class LicenseSeatUpdateTest extends TestCase]);}- public function test_license_seat_can_be_updated()+ public function test_parent_license_cannot_be_updated(){$licenseSeat = LicenseSeat::factory()->create();+ $licenseId = $licenseSeat->license_id;$this->actingAsForApi(User::factory()->checkoutLicenses()->create())->patchJson($this->route($licenseSeat), [- 'notes' => 'A new note is here',+ 'notes' => '',+ 'license_id' => License::factory()->create()->id,])->assertStatus(200)->assertStatusMessageIs('success');$licenseSeat->refresh();+ $this->assertEquals($licenseId, $licenseSeat->license_id);+ }- $this->assertEquals('A new note is here', $licenseSeat->notes);+ public function test_cannot_reassign_unreassignable_license_seat()+ {+ $user = User::factory()->create();++ $licenseSeat = LicenseSeat::factory()->assignedToUser($user)->create(['unreassignable_seat' => true]);++ $this->actingAsForApi(User::factory()->checkoutLicenses()->create())+ ->patchJson($this->route($licenseSeat), [+ 'asset_id' => Asset::factory()->create()->id,+ 'notes' => 'Attempting to reassign an unreassignable seat',+ ])+ ->assertStatus(200)+ ->assertStatusMessageIs('error');++ $licenseSeat->refresh();+ $this->assertNull($licenseSeat->asset_id);++ $this->assertDatabaseHas('action_logs', [+ 'action_type' => 'checkin from',+ 'target_id' => $user->id,+ 'target_type' => User::class,+ 'note' => 'Attempting to reassign an unreassignable seat',+ 'item_type' => License::class,+ 'item_id' => $licenseSeat->license_id,+ 'quantity' => 1,+ ]);}- public function test_parent_license_cannot_be_updated()+ /**************************************************************************+ * Happy Path+ **************************************************************************/+ public function test_license_seat_can_be_updated(){$licenseSeat = LicenseSeat::factory()->create();- $licenseId = $licenseSeat->license_id;$this->actingAsForApi(User::factory()->checkoutLicenses()->create())->patchJson($this->route($licenseSeat), [- 'notes' => '',- 'license_id' => License::factory()->create()->id,+ 'notes' => 'A new note is here',])->assertStatus(200)->assertStatusMessageIs('success');$licenseSeat->refresh();- $this->assertEquals($licenseId, $licenseSeat->license_id);++ $this->assertEquals('A new note is here', $licenseSeat->notes);}public function test_reassignableness_is_not_updated()@@ -191,34 +226,9 @@ class LicenseSeatUpdateTest extends TestCase$this->assertEquals($deleteAt, $licenseSeat->deleted_at);}- public function test_cannot_reassign_unreassignable_license_seat()- {- $user = User::factory()->create();-- $licenseSeat = LicenseSeat::factory()->assignedToUser($user)->create(['unreassignable_seat' => true]);-- $this->actingAsForApi(User::factory()->checkoutLicenses()->create())- ->patchJson($this->route($licenseSeat), [- 'asset_id' => Asset::factory()->create()->id,- 'notes' => 'Attempting to reassign an unreassignable seat',- ])- ->assertStatus(200)- ->assertStatusMessageIs('error');-- $licenseSeat->refresh();- $this->assertNull($licenseSeat->asset_id);-- $this->assertDatabaseHas('action_logs', [- 'action_type' => 'checkin from',- 'target_id' => $user->id,- 'target_type' => User::class,- 'note' => 'Attempting to reassign an unreassignable seat',- 'item_type' => License::class,- 'item_id' => $licenseSeat->license_id,- 'quantity' => 1,- ]);- }-+ /**************************************************************************+ * Checkout/Checkin+ **************************************************************************/public function test_license_seat_can_be_checked_out_to_user_when_updating(){$licenseSeat = LicenseSeat::factory()->create(['assigned_to' => null]);