Skip to content

A free open source IT asset/license management system

Fixed RB-20854 - only allow scalars for users/hardware query strings

snipe2bb86a2ec1f5
diff --git a/resources/views/users/index.blade.php b/resources/views/users/index.blade.php
index 952a9ab3fa..fd0d6c6f6c 100755
--- a/resources/views/users/index.blade.php
+++ b/resources/views/users/index.blade.php
@@ -31,13 +31,13 @@
<x-box>
<x-table.users :route="route('api.users.index',
[
- 'status' => e(request('status')),
+ 'status' => is_scalar(request('status')) ? request('status') : null,
'deleted'=> (request('status')=='deleted') ? 'true' : 'false',
- 'company_id' => e(request('company_id')),
- 'manager_id' => e(request('manager_id')),
- 'admins' => e(request('admins')),
- 'superadmins' => e(request('superadmins')),
- 'activated' => e(request('activated')),
+ 'company_id' => is_scalar(request('company_id')) ? request('company_id') : null,
+ 'manager_id' => is_scalar(request('manager_id')) ? request('manager_id') : null,
+ 'admins' => is_scalar(request('admins')) ? request('admins') : null,
+ 'superadmins' => is_scalar(request('superadmins')) ? request('superadmins') : null,
+ 'activated' => is_scalar(request('activated')) ? request('activated') : null,
])"/>
</x-box>
</x-container>
diff --git a/tests/Feature/Users/Ui/IndexUsersTest.php b/tests/Feature/Users/Ui/IndexUsersTest.php
index fea2b3d81c..58d0c9c5bb 100644
--- a/tests/Feature/Users/Ui/IndexUsersTest.php
+++ b/tests/Feature/Users/Ui/IndexUsersTest.php
@@ -20,4 +20,15 @@ class IndexUsersTest extends TestCase
->get(route('users.index'))
->assertOk();
}
+
+ public function test_page_renders_with_array_query_inputs()
+ {
+ $this->actingAs(User::factory()->viewUsers()->create())
+ ->get(route('users.index', [
+ 'manager_id' => [1],
+ 'company_id' => [1],
+ 'status' => ['deleted'],
+ ]))
+ ->assertOk();
+ }
}