Skip to content

A free open source IT asset/license management system

Fixed #19643 - asset names wiped on item transfer

snipe3fa8ae9deb6b
diff --git a/app/Http/Controllers/Users/UserItemTransferController.php b/app/Http/Controllers/Users/UserItemTransferController.php
index 3c519bed6f..aad3d4e941 100644
--- a/app/Http/Controllers/Users/UserItemTransferController.php
+++ b/app/Http/Controllers/Users/UserItemTransferController.php
@@ -113,7 +113,7 @@ class UserItemTransferController extends Controller
}
$this->checkInAsset($asset, $source, $note);
- $asset->checkOut($target, auth()->user(), date('Y-m-d H:i:s'), null, $note);
+ $asset->checkOut($target, auth()->user(), date('Y-m-d H:i:s'), null, $note, $asset->name);
$count++;
}
diff --git a/app/Models/Asset.php b/app/Models/Asset.php
index 1a9eaf057f..91db955f2b 100644
--- a/app/Models/Asset.php
+++ b/app/Models/Asset.php
@@ -614,7 +614,7 @@ class Asset extends Depreciable
* @param Carbon $checkout_at
* @param Carbon $expected_checkin
* @param string $note
- * @param null $name
+ * @param string|null $name
* @return bool
*
* @since [v3.0]
diff --git a/tests/Feature/Users/TransferUserItemsBehaviorTest.php b/tests/Feature/Users/TransferUserItemsBehaviorTest.php
index 247a49eb1a..e97113f9f4 100644
--- a/tests/Feature/Users/TransferUserItemsBehaviorTest.php
+++ b/tests/Feature/Users/TransferUserItemsBehaviorTest.php
@@ -147,6 +147,29 @@ class TransferUserItemsBehaviorTest extends TestCase
$this->assertSame($target->id, $selectedAsset->assigned_to);
$this->assertSame($source->id, $unselectedAsset->assigned_to);
}
+
+ public function test_transfer_preserves_asset_name(): void
+ {
+ $source = User::factory()->create();
+ $target = User::factory()->create();
+ $asset = Asset::factory()->create([
+ 'name' => 'Ada\'s laptop',
+ 'assigned_to' => $source->id,
+ 'assigned_type' => User::class,
+ ]);
+
+ $this->actingAs($this->transferActor())
+ ->post(route('users.transfer.store', $source), [
+ 'target_user_id' => $target->id,
+ 'asset_ids' => [$asset->id],
+ 'note' => 'employee offboarding',
+ ])
+ ->assertRedirect(route('users.show', $target));
+
+ $asset->refresh();
+ $this->assertSame($target->id, $asset->assigned_to);
+ $this->assertSame('Ada\'s laptop', $asset->name, 'Asset name must survive a transfer.');
+ }
private function transferActor(): User
{