Skip to content

A free open source IT asset/license management system

Seeders: Fixed fields and factories so they run in the right order

snipe4036c7327b99
diff --git a/database/factories/CustomFieldFactory.php b/database/factories/CustomFieldFactory.php
index 2264232261..c63756be28 100644
--- a/database/factories/CustomFieldFactory.php
+++ b/database/factories/CustomFieldFactory.php
@@ -161,10 +161,8 @@ class CustomFieldFactory extends Factory
return [
'name' => 'Sample Date',
'help_text' => 'This shows a datepicker',
- // element must be one of text/listbox/textarea/markdown-
- // textarea/checkbox/radio; the date widget is picked by
- // format, not element.
- 'element' => 'text',
+ // element is auto-forced to date_picker by the saving hook
+ // when format is DATE; no need to specify both.
'format' => 'DATE',
];
});
@@ -176,9 +174,6 @@ class CustomFieldFactory extends Factory
return [
'name' => 'Sample Datetime',
'help_text' => 'This shows a datetimepicker',
- // Same story as testDate: element stays 'text', the
- // datetimepicker fires when format == 'DATETIME'.
- 'element' => 'text',
'format' => 'DATETIME',
];
});
diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php
index 5d369e4b60..01d88a5648 100644
--- a/database/seeders/DatabaseSeeder.php
+++ b/database/seeders/DatabaseSeeder.php
@@ -46,6 +46,14 @@ class DatabaseSeeder extends Seeder
$this->reportMemory('after ManufacturerSeeder');
$this->call(SupplierSeeder::class);
$this->reportMemory('after SupplierSeeder');
+ // CustomFieldSeeder MUST run before AssetModelSeeder. Mobile-phone
+ // model factories look up CustomFieldset by name (e.g., "Mobile
+ // Devices") to attach — if the fieldsets aren't seeded yet, the
+ // ?? fallback creates ad-hoc fieldsets that CustomFieldSeeder
+ // then truncates, leaving the models pointing at orphan
+ // fieldset_ids.
+ $this->call(CustomFieldSeeder::class);
+ $this->reportMemory('after CustomFieldSeeder');
$this->call(AssetModelSeeder::class);
$this->reportMemory('after AssetModelSeeder');
$this->call(DepreciationSeeder::class);
@@ -54,8 +62,6 @@ class DatabaseSeeder extends Seeder
$this->reportMemory('after StatuslabelSeeder');
$this->call(AccessorySeeder::class);
$this->reportMemory('after AccessorySeeder');
- $this->call(CustomFieldSeeder::class);
- $this->reportMemory('after CustomFieldSeeder');
$this->call(AssetSeeder::class);
$this->reportMemory('after AssetSeeder');
$this->call(LicenseSeeder::class);