Skip to content

A free open source IT asset/license management system

Added note about created_by fillable

snipe55f2c205137c
diff --git a/app/Models/Order.php b/app/Models/Order.php
index 6e3292275b..33a3b1d6fe 100644
--- a/app/Models/Order.php
+++ b/app/Models/Order.php
@@ -29,12 +29,15 @@ class Order extends SnipeModel
protected $table = 'orders';
+ // NOTE: `created_by` is deliberately NOT fillable — accepting it via
+ // mass-assignment would let a request attribute an Order to any
+ // user_id the caller writes. All internal writers set it via
+ // explicit `$order->created_by = auth()->id()`.
protected $fillable = [
'order_number',
'supplier_id',
'company_id',
'purchase_date',
- 'created_by',
'notes',
'currency',
];
diff --git a/app/Models/OrderItem.php b/app/Models/OrderItem.php
index 2090f3b45b..1504b11c57 100644
--- a/app/Models/OrderItem.php
+++ b/app/Models/OrderItem.php
@@ -28,6 +28,7 @@ class OrderItem extends Model
'item_id',
'qty',
'price',
+ 'created_by',
];
protected $casts = [
@@ -44,4 +45,14 @@ class OrderItem extends Model
{
return $this->morphTo();
}
+
+ /**
+ * User who added this specific line. Distinct from Order.admin
+ * because staggered receipts under one order_number can accumulate
+ * lines from multiple operators.
+ */
+ public function admin(): BelongsTo
+ {
+ return $this->belongsTo(User::class, 'created_by');
+ }
}