Skip to content

A free open source IT asset/license management system

Make test more explicit

Marcus Moore636d42a52e85
diff --git a/database/factories/ReportTemplateFactory.php b/database/factories/ReportTemplateFactory.php
index bc5d24c724..ae7837bc81 100644
--- a/database/factories/ReportTemplateFactory.php
+++ b/database/factories/ReportTemplateFactory.php
@@ -30,4 +30,11 @@ class ReportTemplateFactory extends Factory
return['share_report_template' => 1];
});
}
+
+ public function notShared()
+ {
+ return $this->state(function () {
+ return ['share_report_template' => 0];
+ });
+ }
}
diff --git a/tests/Feature/ReportTemplates/UpdateReportTemplateTest.php b/tests/Feature/ReportTemplates/UpdateReportTemplateTest.php
index 603c6d762e..45601d8ac7 100644
--- a/tests/Feature/ReportTemplates/UpdateReportTemplateTest.php
+++ b/tests/Feature/ReportTemplates/UpdateReportTemplateTest.php
@@ -66,7 +66,7 @@ class UpdateReportTemplateTest extends TestCase implements TestsPermissionsRequi
{
$user = User::factory()->canViewReports()->create();
- $reportTemplate = ReportTemplate::factory()->for($user, 'creator')->create([
+ $reportTemplate = ReportTemplate::factory()->notShared()->for($user, 'creator')->create([
'name' => 'Original Name',
'options' => [
'category' => 1,
@@ -85,6 +85,7 @@ class UpdateReportTemplateTest extends TestCase implements TestsPermissionsRequi
->assertRedirectToRoute('report-templates.show', $reportTemplate->id);
$reportTemplate->refresh();
+ $this->assertEquals(0, $reportTemplate->share_report_template);
$this->assertEquals('Updated Name', $reportTemplate->name);
$this->assertEquals(0, $reportTemplate->checkmarkValue('category'));
$this->assertEquals([], $reportTemplate->selectValues('by_category_id'));