A free open source IT asset/license management system
fix: PHPStan bool type + PHP 8.4 by-ref property init in OIDC test
Rod Christiansen663aba80deaf
diff --git a/app/Services/Oidc/OidcUserResolver.php b/app/Services/Oidc/OidcUserResolver.phpindex eb1fd53282..0d6f3b45bc 100644--- a/app/Services/Oidc/OidcUserResolver.php+++ b/app/Services/Oidc/OidcUserResolver.php@@ -64,7 +64,7 @@ class OidcUserResolver$user->email = $claims['email'] ?? '';$user->first_name = $claims['given_name'] ?? $username;$user->last_name = $claims['family_name'] ?? '';- $user->activated = 1;+ $user->activated = true;// Random unusable password -- these users authenticate only via OIDC.$user->password = bcrypt(Str::random(40));$user->save();diff --git a/tests/Feature/Authentication/OidcApiAuthTest.php b/tests/Feature/Authentication/OidcApiAuthTest.phpindex 53b35ef8e8..1831a74ca8 100644--- a/tests/Feature/Authentication/OidcApiAuthTest.php+++ b/tests/Feature/Authentication/OidcApiAuthTest.php@@ -35,7 +35,8 @@ class OidcApiAuthTest extends TestCase'private_key_bits' => 2048,'private_key_type' => OPENSSL_KEYTYPE_RSA,]);- openssl_pkey_export($res, $this->privatePem);+ openssl_pkey_export($res, $privatePem);+ $this->privatePem = $privatePem;$details = openssl_pkey_get_details($res);$jwks = ['keys' => [[