Skip to content

A free open source IT asset/license management system

Don’t check for filled on groups in user save

snipe6e33bfaf8f23
diff --git a/app/Http/Controllers/Users/UsersController.php b/app/Http/Controllers/Users/UsersController.php
index 84a86e6c3b..0e30d258e3 100755
--- a/app/Http/Controllers/Users/UsersController.php
+++ b/app/Http/Controllers/Users/UsersController.php
@@ -160,14 +160,11 @@ class UsersController extends Controller
}
- if ($request->filled('groups')) {
- if (auth()->user()->can('canEditAuthFields', $user) && auth()->user()->can('editableOnDemo')) {
- $user->groups()->sync($request->input('groups'));
- }
- } else {
- $user->groups()->sync([]);
+ if (auth()->user()->can('canEditAuthFields', $user) && auth()->user()->can('editableOnDemo')) {
+ $user->groups()->sync($request->input('groups'));
}
+
return Helper::getRedirectOption($request, $user->id, 'Users')
->with('success', trans('admin/users/message.success.create'));
}
@@ -318,7 +315,7 @@ class UsersController extends Controller
));
// Only save groups if the user is a superuser
- if (($request->has('groups')) && (auth()->user()->isSuperUser())) {
+ if (auth()->user()->isSuperUser()) {
$user->groups()->sync($request->input('groups'));
}
}