A free open source IT asset/license management system
Added custom adapter test
snipea89713a37a0a
diff --git a/tests/Feature/SyncAdapters/CustomHttp/CustomHttpAdapterTest.php b/tests/Feature/SyncAdapters/CustomHttp/CustomHttpAdapterTest.phpnew file mode 100644index 0000000000..32eb9e450f--- /dev/null+++ b/tests/Feature/SyncAdapters/CustomHttp/CustomHttpAdapterTest.php@@ -0,0 +1,761 @@+<?php++namespace Tests\Feature\SyncAdapters\CustomHttp;++use App\Models\Asset;+use App\Models\AssetExternalSource;+use App\Models\Statuslabel;+use App\Models\SyncAdapterConfig;+use App\Models\SyncAdapterInstance;+use App\SyncAdapters\CustomHttp\CustomHttpAdapter;+use App\SyncAdapters\PushableAdapter;+use Illuminate\Support\Facades\Crypt;+use Illuminate\Support\Facades\Http;+use Tests\TestCase;++class CustomHttpAdapterTest extends TestCase+{+ protected function setUp(): void+ {+ parent::setUp();+ Statuslabel::factory()->rtd()->create();+ }++ public function test_pull_normalizes_records_via_configured_dot_paths()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'data.devices',+ 'field_source_id' => 'id',+ 'field_hostname' => 'name',+ 'field_serial' => 'hardware.serial',+ 'field_model' => 'hardware.model',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ 'data' => [+ 'devices' => [+ [+ 'id' => 'dev-1',+ 'name' => 'wksn-01',+ 'hardware' => ['serial' => 'SN-ABC', 'model' => 'MacBook Pro'],+ ],+ ],+ ],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());++ $this->assertCount(1, $records);+ $this->assertSame('dev-1', $records[0]->sourceId);+ $this->assertSame('wksn-01', $records[0]->hostname);+ $this->assertSame('SN-ABC', $records[0]->hardwareSerial);+ $this->assertSame('MacBook Pro', $records[0]->hardwareModel);+ }++ public function test_pull_handles_root_array_response_when_records_path_is_blank()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => '',+ 'field_source_id' => 'uuid',+ 'field_hostname' => 'hostname',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ ['uuid' => 'aaa', 'hostname' => 'host-a'],+ ['uuid' => 'bbb', 'hostname' => 'host-b'],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());++ $this->assertCount(2, $records);+ $this->assertSame(['aaa', 'bbb'], array_map(fn ($r) => $r->sourceId, $records));+ }++ public function test_pull_walks_numeric_dot_path_segments()+ {+ // Numeric segments index into sequential arrays, so an API+ // whose device list sits at a fixed position like+ // response.results.0.devices is representable without a+ // wrapper record-level accessor.+ $adapter = $this->configuredAdapter([+ 'records_path' => 'results.0.devices',+ 'field_source_id' => 'id',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ 'results' => [+ ['devices' => [['id' => 'first-only']]],+ ['devices' => [['id' => 'never-yielded']]],+ ],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());+ $this->assertCount(1, $records);+ $this->assertSame('first-only', $records[0]->sourceId);+ }++ public function test_bearer_auth_sends_authorization_header()+ {+ $adapter = $this->configuredAdapter([+ 'auth_method' => 'bearer',+ 'bearer_token' => 'stub-bearer-secret',+ 'field_source_id' => 'id',+ ]);++ Http::fake(['vendor.example/*' => Http::response([['id' => 'x']])]);++ iterator_to_array($adapter->pull());++ Http::assertSent(fn ($request) => $request->hasHeader('Authorization', 'Bearer stub-bearer-secret'));+ }++ public function test_basic_auth_sends_basic_authorization_header()+ {+ $adapter = $this->configuredAdapter([+ 'auth_method' => 'basic',+ 'basic_username' => 'alice',+ 'basic_password' => 'hunter2',+ 'field_source_id' => 'id',+ ]);++ Http::fake(['vendor.example/*' => Http::response([['id' => 'x']])]);++ iterator_to_array($adapter->pull());++ Http::assertSent(fn ($request) => $request->hasHeader('Authorization', 'Basic '.base64_encode('alice:hunter2')));+ }++ public function test_api_key_auth_sends_configured_header_name()+ {+ $adapter = $this->configuredAdapter([+ 'auth_method' => 'api_key',+ 'api_key_header' => 'X-Vendor-Token',+ 'api_key_value' => 'stub-api-key',+ 'field_source_id' => 'id',+ ]);++ Http::fake(['vendor.example/*' => Http::response([['id' => 'x']])]);++ iterator_to_array($adapter->pull());++ Http::assertSent(fn ($request) => $request->hasHeader('X-Vendor-Token', 'stub-api-key'));+ }++ public function test_none_auth_sends_no_authorization_header()+ {+ $adapter = $this->configuredAdapter([+ 'auth_method' => 'none',+ 'field_source_id' => 'id',+ ]);++ Http::fake(['vendor.example/*' => Http::response([['id' => 'x']])]);++ iterator_to_array($adapter->pull());++ Http::assertSent(fn ($request) => ! $request->hasHeader('Authorization'));+ }++ public function test_extras_definition_emits_extra_fields_and_populates_them()+ {+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ 'extras_definition' => json_encode([+ ['key' => 'vendor_tag', 'label' => 'Vendor Asset Tag', 'path' => 'tags.asset_tag'],+ ['key' => 'vendor_room', 'label' => 'Vendor Room', 'path' => 'location.room'],+ ]),+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ [+ 'id' => 'dev-1',+ 'tags' => ['asset_tag' => 'ACME-123'],+ 'location' => ['room' => 'Server Room A'],+ ],+ ]),+ ]);++ // Both metadata AND value must round-trip through extraFields()+ // and normalize().+ $this->assertSame(+ ['vendor_tag' => ['label' => 'Vendor Asset Tag'], 'vendor_room' => ['label' => 'Vendor Room']],+ $adapter->extraFields(),+ );++ $records = iterator_to_array($adapter->pull());+ $this->assertSame('ACME-123', $records[0]->extra['vendor_tag']);+ $this->assertSame('Server Room A', $records[0]->extra['vendor_room']);+ }++ public function test_missing_dot_path_leaves_field_null_without_throwing()+ {+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ 'field_hostname' => 'not.present.here',+ ]);++ Http::fake(['vendor.example/*' => Http::response([['id' => 'dev-1']])]);++ $records = iterator_to_array($adapter->pull());+ $this->assertNull($records[0]->hostname);+ }++ public function test_non_array_at_records_path_logs_warning_and_yields_nothing()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'data.not_an_array',+ 'field_source_id' => 'id',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['data' => ['not_an_array' => 'oops']])]);++ $records = iterator_to_array($adapter->pull());+ $this->assertSame([], $records);+ }++ public function test_blank_source_id_path_aborts_pull_softly_instead_of_throwing()+ {+ // Regression: blank source_id path made dotPathGet return+ // the whole record array, which (string) cast blew up with+ // "Array to string conversion" and aborted the sync. Now we+ // detect the missing config up front and log a clear+ // "Source ID is required" message instead.+ $adapter = $this->configuredAdapter([+ 'field_hostname' => 'name',+ ]);++ Http::fake(['vendor.example/*' => Http::response([['id' => 'x', 'name' => 'host']])]);++ $records = iterator_to_array($adapter->pull());+ $this->assertSame([], $records);+ }++ public function test_non_scalar_at_source_id_path_skips_record_without_throwing()+ {+ // If the vendor puts an object or array at the source_id+ // path in one specific record (bad row, schema drift),+ // stringOrNull returns null and pull() skips just that+ // record with an info log, letting other records through.+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ 'field_hostname' => 'name',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ ['id' => ['nested' => 'not a scalar'], 'name' => 'broken'],+ ['id' => 'good-1', 'name' => 'valid'],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());+ $this->assertCount(1, $records);+ $this->assertSame('good-1', $records[0]->sourceId);+ }++ public function test_offset_limit_pagination_walks_until_short_page()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'rows',+ 'field_source_id' => 'id',+ 'pagination_style' => 'offset_limit',+ 'pagination_page_size' => '2',+ ]);++ // Two full pages of 2, then a short page of 1, then would-be+ // page 4 never fires because the short page signals "last".+ Http::fake([+ 'vendor.example/*offset=0*' => Http::response(['rows' => [['id' => 'a'], ['id' => 'b']]]),+ 'vendor.example/*offset=2*' => Http::response(['rows' => [['id' => 'c'], ['id' => 'd']]]),+ 'vendor.example/*offset=4*' => Http::response(['rows' => [['id' => 'e']]]),+ ]);++ $records = iterator_to_array($adapter->pull());++ $this->assertSame(['a', 'b', 'c', 'd', 'e'], array_map(fn ($r) => $r->sourceId, $records));++ // Never fetches offset=6.+ Http::assertNotSent(fn ($request) => str_contains($request->url(), 'offset=6'));+ }++ public function test_offset_limit_pagination_honors_custom_param_names()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'data',+ 'field_source_id' => 'id',+ 'pagination_style' => 'offset_limit',+ 'pagination_page_size' => '3',+ 'pagination_limit_param' => 'per_page',+ 'pagination_offset_param' => 'start',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response(['data' => [['id' => 'only']]]),+ ]);++ iterator_to_array($adapter->pull());++ Http::assertSent(fn ($request) => str_contains($request->url(), 'per_page=3')+ && str_contains($request->url(), 'start=0'));+ }++ public function test_page_number_pagination_walks_until_short_page()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'rows',+ 'field_source_id' => 'id',+ 'pagination_style' => 'page_number',+ 'pagination_page_size' => '2',+ ]);++ Http::fake([+ 'vendor.example/*page=1*' => Http::response(['rows' => [['id' => 'a'], ['id' => 'b']]]),+ 'vendor.example/*page=2*' => Http::response(['rows' => [['id' => 'c'], ['id' => 'd']]]),+ 'vendor.example/*page=3*' => Http::response(['rows' => [['id' => 'e']]]),+ ]);++ $records = iterator_to_array($adapter->pull());++ $this->assertSame(['a', 'b', 'c', 'd', 'e'], array_map(fn ($r) => $r->sourceId, $records));++ // Never fetches page 4 because page 3 was short.+ Http::assertNotSent(fn ($request) => str_contains($request->url(), 'page=4'));+ }++ public function test_page_number_pagination_honors_custom_page_param_and_start()+ {+ // Zero-based API: pages start at 0 and the query param is+ // called "p" instead of "page".+ $adapter = $this->configuredAdapter([+ 'records_path' => 'data',+ 'field_source_id' => 'id',+ 'pagination_style' => 'page_number',+ 'pagination_page_size' => '10',+ 'pagination_page_param' => 'p',+ 'pagination_page_start' => '0',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response(['data' => [['id' => 'only']]]),+ ]);++ iterator_to_array($adapter->pull());++ Http::assertSent(fn ($request) => str_contains($request->url(), 'p=0'));+ }++ public function test_next_url_pagination_follows_response_link()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'rows',+ 'field_source_id' => 'id',+ 'pagination_style' => 'next_url',+ 'pagination_next_path' => 'links.next',+ ]);++ // Distinct path segments per page keep Http::fake pattern+ // matching unambiguous. The first-page URL is+ // https://vendor.example/api by way of configuredAdapter().+ Http::fake([+ 'vendor.example/page-two' => Http::response([+ 'rows' => [['id' => 'c']],+ 'links' => ['next' => null],+ ]),+ 'vendor.example/api' => Http::response([+ 'rows' => [['id' => 'a'], ['id' => 'b']],+ 'links' => ['next' => 'https://vendor.example/page-two'],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());++ $this->assertSame(['a', 'b', 'c'], array_map(fn ($r) => $r->sourceId, $records));+ }++ public function test_pagination_style_none_yields_one_page_and_stops()+ {+ $adapter = $this->configuredAdapter([+ 'records_path' => 'rows',+ 'field_source_id' => 'id',+ 'pagination_style' => 'none',+ ]);++ $callCount = 0;+ Http::fake([+ 'vendor.example/*' => function () use (&$callCount) {+ $callCount++;++ return Http::response(['rows' => [['id' => 'only-'.$callCount]]]);+ },+ ]);++ iterator_to_array($adapter->pull());++ $this->assertSame(1, $callCount, 'None-style must issue exactly one HTTP call.');+ }++ public function test_http_failure_fails_soft_and_yields_nothing()+ {+ // Vendor 500 must not crash the sync run. Adapter logs a+ // warning and returns an empty iterable so the framework's+ // orchestrator moves on.+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['error' => 'boom'], 500)]);++ $records = iterator_to_array($adapter->pull());+ $this->assertSame([], $records);+ }++ public function test_malformed_extras_json_is_ignored()+ {+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ 'extras_definition' => 'not valid json {{{',+ ]);++ $this->assertSame([], $adapter->extraFields());+ }++ public function test_html_escaped_string_values_are_decoded_on_ingest()+ {+ // Some APIs (Snipe-IT's own /api/v1/hardware is one) run+ // string values through htmlspecialchars(), so a model name+ // like `MacBook Pro 13"` shows up on the wire as+ // `MacBook Pro 13"`. Decoding here keeps us from+ // round-tripping the entity into the asset table.+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ 'field_hostname' => 'name',+ 'field_model' => 'model',+ 'extras_definition' => json_encode([+ ['key' => 'vendor_notes', 'label' => 'Vendor Notes', 'path' => 'notes'],+ ]),+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ [+ 'id' => 'dev-1',+ 'name' => 'wksn & friends',+ 'model' => 'MacBook Pro 13" '16',+ 'notes' => 'Ampersand: A & B',+ ],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());++ $this->assertSame('wksn & friends', $records[0]->hostname);+ $this->assertSame("MacBook Pro 13\" '16", $records[0]->hardwareModel);+ $this->assertSame('Ampersand: A & B', $records[0]->extra['vendor_notes']);+ }++ public function test_last_seen_string_parses_to_carbon()+ {+ $adapter = $this->configuredAdapter([+ 'field_source_id' => 'id',+ 'field_last_seen' => 'last_check_in',+ ]);++ Http::fake([+ 'vendor.example/*' => Http::response([+ ['id' => 'dev-1', 'last_check_in' => '2026-01-15T12:34:56Z'],+ ]),+ ]);++ $records = iterator_to_array($adapter->pull());+ $this->assertNotNull($records[0]->lastSeen);+ $this->assertSame('2026-01-15 12:34:56', $records[0]->lastSeen->utc()->format('Y-m-d H:i:s'));+ }++ public function test_implements_pushable_when_push_method_is_not_disabled()+ {+ $adapter = $this->configuredAdapter([+ 'push_method' => 'PATCH',+ ]);++ $this->assertInstanceOf(PushableAdapter::class, $adapter);+ $this->assertTrue($adapter->canPush());+ }++ public function test_cannot_push_when_push_method_is_disabled()+ {+ $adapter = $this->configuredAdapter(['push_method' => 'disabled']);++ $this->assertFalse($adapter->canPush());+ }++ public function test_cannot_push_when_push_method_is_unset()+ {+ // Fresh install: nothing under push_method. canPush() must+ // return false so the shell hides the Push Now button until+ // the admin picks a verb.+ $adapter = $this->configuredAdapter([]);++ $this->assertFalse($adapter->canPush());+ }++ public function test_push_with_blank_push_path_targets_base_url()+ {+ // Some APIs accept record-scoped writes at the base URL when+ // the id is in the body rather than the path. Blank+ // push_path means "hit the base URL directly."+ $adapter = $this->configuredAdapter([+ 'push_method' => 'PATCH',+ 'field_asset_tag' => 'asset_tag',+ ]);+ SyncAdapterConfig::put(SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail()->id, 'direction.asset_tag', 'push');++ $asset = Asset::factory()->create(['asset_tag' => 'BASE-URL-1']);+ AssetExternalSource::create([+ 'asset_id' => $asset->id,+ 'source' => $adapter->name(),+ 'external_id' => 'ext-base',+ ]);++ Http::fake(['vendor.example/api' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertSent(function ($request) {+ return $request->method() === 'PATCH'+ && rtrim($request->url(), '/') === 'https://vendor.example/api';+ });+ }++ public function test_push_builds_payload_from_directed_fields_with_configured_dot_paths()+ {+ $adapter = $this->configuredAdapter([+ 'auth_method' => 'bearer',+ 'bearer_token' => 'stub-bearer',+ 'push_path' => '/api/v1/devices/{external_id}',+ 'field_asset_tag' => 'asset.tag',+ 'field_hostname' => 'name',+ ]);+ $instance = SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail();+ SyncAdapterConfig::put($instance->id, 'direction.asset_tag', 'push');+ SyncAdapterConfig::put($instance->id, 'direction.hostname', 'push');++ $asset = Asset::factory()->create(['asset_tag' => 'SNIPE-42', 'name' => 'wksn-42']);+ AssetExternalSource::create([+ 'asset_id' => $asset->id,+ 'source' => $adapter->name(),+ 'external_id' => 'ext-42',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertSent(function ($request) {+ $body = $request->data();++ return $request->method() === 'PATCH'+ && str_contains($request->url(), '/api/v1/devices/ext-42')+ && ($body['asset']['tag'] ?? null) === 'SNIPE-42'+ && ($body['name'] ?? null) === 'wksn-42';+ });+ }++ public function test_push_method_override_is_honored()+ {+ $adapter = $this->configuredAdapter([+ 'push_path' => '/devices/{external_id}',+ 'push_method' => 'PUT',+ 'field_asset_tag' => 'asset_tag',+ ]);+ SyncAdapterConfig::put(SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail()->id, 'direction.asset_tag', 'push');++ $asset = Asset::factory()->create(['asset_tag' => 'PUT-ME']);+ AssetExternalSource::create([+ 'asset_id' => $asset->id,+ 'source' => $adapter->name(),+ 'external_id' => 'ext-99',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertSent(fn ($request) => $request->method() === 'PUT');+ }++ public function test_push_substitutes_url_encoded_external_id_in_path_template()+ {+ // Regression guard: external ids often contain characters+ // that need to be percent-encoded (spaces, forward slashes,+ // etc.). The substitution has to rawurlencode the id or the+ // resulting URL is malformed.+ $adapter = $this->configuredAdapter([+ 'push_path' => '/devices/{external_id}/fields',+ 'field_asset_tag' => 'asset_tag',+ ]);+ SyncAdapterConfig::put(SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail()->id, 'direction.asset_tag', 'push');++ $asset = Asset::factory()->create(['asset_tag' => 'ENC-1']);+ AssetExternalSource::create([+ 'asset_id' => $asset->id,+ 'source' => $adapter->name(),+ 'external_id' => 'weird id/with slash',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertSent(fn ($request) => str_contains($request->url(), '/devices/weird%20id%2Fwith%20slash/fields'));+ }++ public function test_push_skips_when_no_external_source_row()+ {+ // Asset was never pulled from this instance, so there is no+ // vendor-side id to write against. Framework's pushPrologue+ // returns null and we no-op silently rather than 404 the+ // vendor with a made-up id.+ $adapter = $this->configuredAdapter([+ 'push_path' => '/devices/{external_id}',+ 'field_asset_tag' => 'asset_tag',+ ]);+ SyncAdapterConfig::put(SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail()->id, 'direction.asset_tag', 'push');++ $asset = Asset::factory()->create();++ Http::fake(['vendor.example/*' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertNothingSent();+ }++ public function test_push_dry_run_logs_instead_of_sending()+ {+ $adapter = $this->configuredAdapter([+ 'push_path' => '/devices/{external_id}',+ 'field_asset_tag' => 'asset_tag',+ ]);+ $instance = SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail();+ SyncAdapterConfig::put($instance->id, 'direction.asset_tag', 'push');+ SyncAdapterConfig::put($instance->id, 'push_dry_run', '1');++ $asset = Asset::factory()->create(['asset_tag' => 'DRY-RUN']);+ AssetExternalSource::create([+ 'asset_id' => $asset->id,+ 'source' => $adapter->name(),+ 'external_id' => 'ext-dry',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertNothingSent();+ }++ public function test_push_notes_target_receives_composed_notes()+ {+ $adapter = $this->configuredAdapter([+ 'push_path' => '/devices/{external_id}',+ 'push_notes_target' => 'metadata.notes',+ 'push_notes_template' => 'Snipe tag: {asset_tag}',+ ]);+ SyncAdapterConfig::put(SyncAdapterInstance::where('slug', $adapter->name())->firstOrFail()->id, 'direction.asset_tag', 'push');++ $asset = Asset::factory()->create(['asset_tag' => 'NOTES-1']);+ AssetExternalSource::create([+ 'asset_id' => $asset->id,+ 'source' => $adapter->name(),+ 'external_id' => 'ext-notes',+ ]);++ Http::fake(['vendor.example/*' => Http::response(['ok' => true])]);++ $adapter->push($asset);++ Http::assertSent(function ($request) {+ $body = $request->data();++ return ($body['metadata']['notes'] ?? null) === 'Snipe tag: NOTES-1';+ });+ }++ /**+ * @param array<string, string> $config+ */+ private function configuredAdapter(array $config): CustomHttpAdapter+ {+ $instance = SyncAdapterInstance::create([+ 'adapter_type' => 'custom_http',+ 'label' => 'Test Custom '.uniqid('', true),+ 'active' => true,+ 'built_in' => false,+ ]);++ SyncAdapterConfig::put($instance->id, 'url', 'https://vendor.example/api');++ // Match credential()'s decryption path: secret-flagged keys+ // must round-trip through Crypt so credential() can read them.+ // Anything not in this set is stored plaintext.+ $secretKeys = ['bearer_token', 'basic_password', 'api_key_value'];++ // Shim: field-map storage collapsed 12 individual field_*+ // credential keys into a single field_paths JSON blob, and+ // source_id was hoisted to its own standalone credential+ // (source_id_path) to keep the required identifier visible+ // rather than buried in the picker. Tests pre-date those+ // refactors and still write the old shape for readability,+ // so translate here.+ if (array_key_exists('field_source_id', $config)) {+ SyncAdapterConfig::put($instance->id, 'source_id_path', (string) $config['field_source_id']);+ unset($config['field_source_id']);+ }+ $fieldPathAliases = [+ 'field_hostname' => 'hostname',+ 'field_serial' => 'serial',+ 'field_asset_tag' => 'asset_tag',+ 'field_model' => 'model',+ 'field_manufacturer' => 'manufacturer',+ 'field_mac' => 'mac',+ 'field_ip' => 'ip',+ 'field_os' => 'os',+ 'field_os_version' => 'os_version',+ 'field_last_seen' => 'last_seen',+ 'field_assigned_user_email' => 'assigned_user_email',+ 'field_assigned_user_name' => 'assigned_user_name',+ ];+ $fieldPaths = [];+ foreach ($fieldPathAliases as $legacyKey => $canonicalKey) {+ if (array_key_exists($legacyKey, $config)) {+ $fieldPaths[$canonicalKey] = (string) $config[$legacyKey];+ unset($config[$legacyKey]);+ }+ }+ // Shim: canPush() now gates on push_method rather than+ // push_path. Existing tests set push_path without specifying+ // a method (default was PATCH before, disabled after). If a+ // test provided push_path without a push_method, default to+ // PATCH so those assertions keep passing without rewrites.+ if (array_key_exists('push_path', $config) && ! array_key_exists('push_method', $config)) {+ $config['push_method'] = 'PATCH';+ }++ if ($fieldPaths !== []) {+ SyncAdapterConfig::put($instance->id, 'field_paths', json_encode($fieldPaths));+ }++ foreach ($config as $key => $value) {+ $stored = in_array($key, $secretKeys, true) ? Crypt::encrypt((string) $value) : (string) $value;+ SyncAdapterConfig::put($instance->id, $key, $stored);+ }++ return new CustomHttpAdapter($instance->fresh());+ }+}