Skip to content

A free open source IT asset/license management system

cleaning up notes

akemidxdf3e8ec0f32c
diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php
index ba89ca1322..c25c9d1aac 100644
--- a/app/Http/Controllers/ReportsController.php
+++ b/app/Http/Controllers/ReportsController.php
@@ -437,15 +437,8 @@ class ReportsController extends Controller
$handle = fopen('php://output', 'w');
stream_set_timeout($handle, 2000);
- //this is handling emdash encoding, and is preventing that character from becoming something like —
fprintf($handle, chr(0xEF).chr(0xBB).chr(0xBF));
- //U+00EC is accent grave in model number
- //U+00EE is circumflex in model name
- //why is the same character a value of 2 off of each other?
- //why are we all getting different outputs for this emdash?
- //exporting and opening with a text editor doesn't fuck it up? so its NOT on export. It's an Excel problem.
-
$header = [];
if ($request->filled('id')) {
diff --git a/database/migrations/2013_11_13_075318_create_models_table.php b/database/migrations/2013_11_13_075318_create_models_table.php
index fd8dd62a5d..cd2d9dfc70 100755
--- a/database/migrations/2013_11_13_075318_create_models_table.php
+++ b/database/migrations/2013_11_13_075318_create_models_table.php
@@ -19,7 +19,6 @@ class CreateModelsTable extends Migration
$table->integer('category_id')->nullable();
$table->timestamps();
$table->engine = 'InnoDB';
- //making a note here. Interestingly we state the model and modelno cloumns as strings. Tableplus stores as a var_string.
});
}