Skip to content

A free open source IT asset/license management system

Scaffold additional test cases and organize

Marcus Mooree25e405f7490
diff --git a/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php b/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php
index 385c864621..b6c8729edb 100644
--- a/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php
+++ b/tests/Feature/LicenseSeats/Api/LicenseSeatUpdateTest.php
@@ -18,12 +18,79 @@ class LicenseSeatUpdateTest extends TestCase
->assertForbidden();
}
+ public function test_assigned_to_cannot_be_array()
+ {
+ $licenseSeat = LicenseSeat::factory()->create(['assigned_to' => null]);
+
+ $targets = User::factory()->count(2)->create();
+
+ $this->actingAsForApi(User::factory()->superuser()->create())
+ ->patchJson(
+ route('api.licenses.seats.update', [$licenseSeat->license->id, $licenseSeat->id]),
+ [
+ 'assigned_to' => [
+ $targets[0]->id,
+ $targets[1]->id,
+ ],
+ 'notes' => '',
+ ]
+ )
+ ->assertStatus(200)
+ ->assertStatusMessageIs('error')
+ ->assertMessagesContains('assigned_to');
+ }
+
+ public function test_assigned_to_must_be_valid_user()
+ {
+ $licenseSeat = LicenseSeat::factory()->create(['assigned_to' => null]);
+
+ $softDeletedUser = User::factory()->trashed()->create();
+
+ $this->actingAsForApi(User::factory()->superuser()->create())
+ ->patchJson(
+ route('api.licenses.seats.update', [$licenseSeat->license->id, $licenseSeat->id]),
+ [
+ 'assigned_to' => $softDeletedUser->id,
+ 'notes' => '',
+ ]
+ )
+ ->assertStatus(200)
+ ->assertStatusMessageIs('error')
+ ->assertMessagesContains('assigned_to');
+ }
+
+ public function test_assigned_to_and_asset_id_cannot_be_provided_together()
+ {
+ $this->markTestIncomplete();
+ }
+
public function test_license_seat_can_be_updated()
+ {
+ $licenseSeat = LicenseSeat::factory()->create();
+
+ $this->actingAsForApi(User::factory()->superuser()->create())
+ ->patchJson($this->route($licenseSeat), [
+ 'notes' => 'A new note is here',
+ ])
+ ->assertStatus(200)
+ ->assertStatusMessageIs('success');
+
+ $licenseSeat->refresh();
+
+ $this->assertEquals('A new note is here', $licenseSeat->notes);
+ }
+
+ public function test_created_by_and_timestamps_are_not_updated()
+ {
+ $this->markTestIncomplete();
+ }
+
+ public function test_reassignableness_cannot_be_updated()
{
$this->markTestIncomplete();
}
- public function test_license_seat_can_be_checked_out_when_updating()
+ public function test_license_seat_can_be_checked_out_to_user_when_updating()
{
$this->markTestIncomplete();
@@ -57,6 +124,11 @@ class LicenseSeatUpdateTest extends TestCase
$this->assertHasTheseActionLogs($license, ['add seats', 'create', 'checkout']); //FIXME - backwards
}
+ public function test_license_seat_can_be_checked_out_to_asset_when_updating()
+ {
+ $this->markTestIncomplete();
+ }
+
public function test_license_seat_can_be_checked_in_when_updating()
{
$this->markTestIncomplete();
@@ -79,50 +151,14 @@ class LicenseSeatUpdateTest extends TestCase
$this->assertNull($licenseSeat->assigned_to);
}
- public function test_cannot_reassign_unreassignable_license_seat()
+ public function test_cannot_change_license_for_license_seat()
{
$this->markTestIncomplete();
}
- public function test_assigned_to_cannot_be_array()
- {
- $licenseSeat = LicenseSeat::factory()->create(['assigned_to' => null]);
-
- $targets = User::factory()->count(2)->create();
-
- $this->actingAsForApi(User::factory()->superuser()->create())
- ->patchJson(
- route('api.licenses.seats.update', [$licenseSeat->license->id, $licenseSeat->id]),
- [
- 'assigned_to' => [
- $targets[0]->id,
- $targets[1]->id,
- ],
- 'notes' => '',
- ]
- )
- ->assertStatus(200)
- ->assertStatusMessageIs('error')
- ->assertMessagesContains('assigned_to');
- }
-
- public function test_assigned_to_must_be_valid_user()
+ public function test_cannot_reassign_unreassignable_license_seat()
{
- $licenseSeat = LicenseSeat::factory()->create(['assigned_to' => null]);
-
- $softDeletedUser = User::factory()->trashed()->create();
-
- $this->actingAsForApi(User::factory()->superuser()->create())
- ->patchJson(
- route('api.licenses.seats.update', [$licenseSeat->license->id, $licenseSeat->id]),
- [
- 'assigned_to' => $softDeletedUser->id,
- 'notes' => '',
- ]
- )
- ->assertStatus(200)
- ->assertStatusMessageIs('error')
- ->assertMessagesContains('assigned_to');
+ $this->markTestIncomplete();
}
private function route(LicenseSeat $licenseSeat)