Skip to content

A free open source IT asset/license management system

Remove unneeded assertions

Marcus Mooree80a9655fbf7
diff --git a/tests/Feature/Checkins/Ui/AccessoryCheckinTest.php b/tests/Feature/Checkins/Ui/AccessoryCheckinTest.php
index 9d453c4f3c..20ecf2f04e 100644
--- a/tests/Feature/Checkins/Ui/AccessoryCheckinTest.php
+++ b/tests/Feature/Checkins/Ui/AccessoryCheckinTest.php
@@ -175,12 +175,6 @@ class AccessoryCheckinTest extends TestCase
[$accessory, $asset] = $this->createAccessoryAndAssetSharingAnId($user);
- // Notifications on for this one. With checkin_email off the delete never
- // runs at all and this would be a re-run of the two tests above rather
- // than a test of the missing morph filter.
- $accessory->category->update(['checkin_email' => true]);
- $this->assertTrue((bool) $accessory->fresh()->checkin_email());
-
// The asset's acceptance is created FIRST so it is the older row.
// Accessory checkins retire only the oldest matching pending row, so
// with the accessory's own row older this test would pass whether or
@@ -198,8 +192,6 @@ class AccessoryCheckinTest extends TestCase
$this->checkInAccessoryFrom($accessory, $user);
- Mail::assertSent(CheckinAccessoryMail::class);
-
$this->assertAcceptanceWasSoftDeleted(
$accessoryAcceptance,
'The checked-in accessory\'s own pending acceptance should have been soft-deleted.'
diff --git a/tests/Feature/Checkins/Ui/LicenseCheckinTest.php b/tests/Feature/Checkins/Ui/LicenseCheckinTest.php
index 55f3597ee8..17a1712bbc 100644
--- a/tests/Feature/Checkins/Ui/LicenseCheckinTest.php
+++ b/tests/Feature/Checkins/Ui/LicenseCheckinTest.php
@@ -3,7 +3,6 @@
namespace Tests\Feature\Checkins\Ui;
use App\Events\CheckoutableCheckedIn;
-use App\Mail\CheckinLicenseMail;
use App\Models\Asset;
use App\Models\Category;
use App\Models\CheckoutAcceptance;
@@ -14,7 +13,6 @@ use App\Models\User;
use App\Notifications\CheckinLicenseSeatNotification;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Event;
-use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Facades\Notification;
use PHPUnit\Framework\Attributes\Test;
use Tests\TestCase;
@@ -188,20 +186,12 @@ class LicenseCheckinTest extends TestCase
#[Test]
public function license_seat_checkin_does_not_clear_a_same_id_pending_acceptance_of_another_type()
{
- Mail::fake();
-
$this->settings->disableAdminCC()->disableAdminCCAlways()->disableSlackWebhook();
$user = User::factory()->create();
[$seat, $asset] = $this->createSeatAndAssetSharingAnId($user);
- // Notifications on for this one. With checkin_email off the delete never
- // runs at all and this would be a re-run of the two tests above rather
- // than a test of the missing morph filter.
- $seat->license->category->update(['checkin_email' => true]);
- $this->assertTrue((bool) $seat->license->fresh()->checkin_email());
-
$seatAcceptance = $this->pendingSeatAcceptance($seat, $user);
$assetAcceptance = CheckoutAcceptance::factory()->pending()->create([
@@ -212,8 +202,6 @@ class LicenseCheckinTest extends TestCase
$this->checkInSeat($seat);
- Mail::assertSent(CheckinLicenseMail::class);
-
$this->assertAcceptanceWasSoftDeleted(
$seatAcceptance,
'The checked-in seat\'s own pending acceptance should have been soft-deleted.'