A free open source IT asset/license management system
Fixed flaky test
snipee965b510d0b5
diff --git a/database/factories/AssetFactory.php b/database/factories/AssetFactory.phpindex fab04b687c..32a56f0fcf 100644--- a/database/factories/AssetFactory.php+++ b/database/factories/AssetFactory.php@@ -37,7 +37,13 @@ class AssetFactory extends Factoryreturn Statuslabel::where('name', 'Ready to Deploy')->first() ?? Statuslabel::factory()->rtd()->create(['name' => 'Ready to Deploy']);},'created_by' => User::factory()->superuser(),- 'asset_tag' => $this->faker->unixTime('now'),+ // Guaranteed unique per faker instance rather than relying on+ // wall-clock seconds. The previous `unixTime('now')` default+ // collided with `unique_undeleted:assets,asset_tag` when a+ // test created assets back-to-back within one second, which+ // showed up as off-by-one flakiness on GH's slower runners+ // (e.g. MergeUsersTest asserting 9 but getting 8).+ 'asset_tag' => $this->faker->unique()->numerify('##########'),'notes' => 'Created by DB seeder','purchase_date' => $this->faker->dateTimeBetween('-1 years', 'now', date_default_timezone_get())->format('Y-m-d'),'purchase_cost' => $this->faker->randomFloat(2, '299.99', '2999.99'),