Skip to content

A free open source IT asset/license management system

Added tests

snipeea274f0df039
diff --git a/tests/Unit/Actions/Permissions/NormalizePermissionsPayloadActionTest.php b/tests/Unit/Actions/Permissions/NormalizePermissionsPayloadActionTest.php
new file mode 100644
index 0000000000..c3efd58146
--- /dev/null
+++ b/tests/Unit/Actions/Permissions/NormalizePermissionsPayloadActionTest.php
@@ -0,0 +1,44 @@
+<?php
+
+namespace Tests\Unit\Actions\Permissions;
+
+use App\Actions\Permissions\NormalizePermissionsPayloadAction;
+use Tests\TestCase;
+
+class NormalizePermissionsPayloadActionTest extends TestCase
+{
+ public function test_it_returns_arrays_unchanged(): void
+ {
+ $permissions = ['users.view' => '1', 'reports.view' => 0];
+
+ $normalized = NormalizePermissionsPayloadAction::run($permissions);
+
+ $this->assertSame($permissions, $normalized);
+ }
+
+ public function test_it_decodes_valid_json_objects(): void
+ {
+ $normalized = NormalizePermissionsPayloadAction::run('{"users.view":"1","reports.view":"0"}');
+
+ $this->assertSame(['users.view' => '1', 'reports.view' => '0'], $normalized);
+ }
+
+ public function test_it_casts_std_class_payloads_to_arrays(): void
+ {
+ $permissions = (object) ['users.view' => '1'];
+
+ $normalized = NormalizePermissionsPayloadAction::run($permissions);
+
+ $this->assertSame(['users.view' => '1'], $normalized);
+ }
+
+ public function test_it_returns_empty_array_for_invalid_json_or_non_array_values(): void
+ {
+ $this->assertSame([], NormalizePermissionsPayloadAction::run('{not-valid-json}'));
+ $this->assertSame([], NormalizePermissionsPayloadAction::run('null'));
+ $this->assertSame([], NormalizePermissionsPayloadAction::run('"users.view"'));
+ $this->assertSame([], NormalizePermissionsPayloadAction::run(null));
+ $this->assertSame([], NormalizePermissionsPayloadAction::run(123));
+ $this->assertSame([], NormalizePermissionsPayloadAction::run(true));
+ }
+}
diff --git a/tests/Unit/Actions/Permissions/PreserveUnauthorizedPrivilegedPermissionsActionTest.php b/tests/Unit/Actions/Permissions/PreserveUnauthorizedPrivilegedPermissionsActionTest.php
new file mode 100644
index 0000000000..697a26eefb
--- /dev/null
+++ b/tests/Unit/Actions/Permissions/PreserveUnauthorizedPrivilegedPermissionsActionTest.php
@@ -0,0 +1,85 @@
+<?php
+
+namespace Tests\Unit\Actions\Permissions;
+
+use App\Actions\Permissions\PreserveUnauthorizedPrivilegedPermissionsAction;
+use App\Models\User;
+use Tests\TestCase;
+
+class PreserveUnauthorizedPrivilegedPermissionsActionTest extends TestCase
+{
+ public function test_superuser_can_modify_privileged_keys(): void
+ {
+ $actor = User::factory()->superuser()->create();
+
+ $normalized = PreserveUnauthorizedPrivilegedPermissionsAction::run(
+ requestedPermissions: ['admin' => '0', 'superuser' => '0', 'users.view' => '1'],
+ authenticatedUser: $actor,
+ originalPermissions: ['admin' => '1', 'superuser' => '1']
+ );
+
+ $this->assertSame('0', (string) $normalized['admin']);
+ $this->assertSame('0', (string) $normalized['superuser']);
+ $this->assertSame('1', (string) $normalized['users.view']);
+ }
+
+ public function test_admin_cannot_change_existing_superuser_key(): void
+ {
+ $actor = User::factory()->admin()->create();
+
+ $normalized = PreserveUnauthorizedPrivilegedPermissionsAction::run(
+ requestedPermissions: ['admin' => '0', 'superuser' => '0', 'users.view' => '1'],
+ authenticatedUser: $actor,
+ originalPermissions: ['admin' => '1', 'superuser' => '1']
+ );
+
+ $this->assertSame('0', (string) $normalized['admin']);
+ $this->assertSame('1', (string) $normalized['superuser']);
+ $this->assertSame('1', (string) $normalized['users.view']);
+ }
+
+ public function test_admin_cannot_add_superuser_key_when_original_is_missing(): void
+ {
+ $actor = User::factory()->admin()->create();
+
+ $normalized = PreserveUnauthorizedPrivilegedPermissionsAction::run(
+ requestedPermissions: ['admin' => '1', 'superuser' => '1', 'users.view' => '1'],
+ authenticatedUser: $actor,
+ originalPermissions: ['admin' => '0']
+ );
+
+ $this->assertArrayNotHasKey('superuser', $normalized);
+ $this->assertSame('1', (string) $normalized['admin']);
+ $this->assertSame('1', (string) $normalized['users.view']);
+ }
+
+ public function test_non_admin_cannot_change_existing_admin_or_superuser_keys(): void
+ {
+ $actor = User::factory()->editUsers()->create();
+
+ $normalized = PreserveUnauthorizedPrivilegedPermissionsAction::run(
+ requestedPermissions: ['admin' => '1', 'superuser' => '1', 'users.view' => '1'],
+ authenticatedUser: $actor,
+ originalPermissions: ['admin' => '0', 'superuser' => '0']
+ );
+
+ $this->assertSame('0', (string) $normalized['admin']);
+ $this->assertSame('0', (string) $normalized['superuser']);
+ $this->assertSame('1', (string) $normalized['users.view']);
+ }
+
+ public function test_non_admin_cannot_add_missing_admin_or_superuser_keys(): void
+ {
+ $actor = User::factory()->editUsers()->create();
+
+ $normalized = PreserveUnauthorizedPrivilegedPermissionsAction::run(
+ requestedPermissions: ['admin' => '1', 'superuser' => '1', 'users.view' => '1'],
+ authenticatedUser: $actor,
+ originalPermissions: []
+ );
+
+ $this->assertArrayNotHasKey('admin', $normalized);
+ $this->assertArrayNotHasKey('superuser', $normalized);
+ $this->assertSame('1', (string) $normalized['users.view']);
+ }
+}