Skip to content

A free open source IT asset/license management system

Fixed RB-4138 - json validation on wonky params

snipef74fedb226a2
diff --git a/app/Rules/ValidJson.php b/app/Rules/ValidJson.php
index 7923494a0a..c7b63adcad 100644
--- a/app/Rules/ValidJson.php
+++ b/app/Rules/ValidJson.php
@@ -4,17 +4,18 @@ namespace App\Rules;
use Closure;
use Illuminate\Contracts\Validation\ValidationRule;
+use Illuminate\Translation\PotentiallyTranslatedString;
class ValidJson implements ValidationRule
{
/**
* Run the validation rule.
*
- * @param \Closure(string, ?string=): \Illuminate\Translation\PotentiallyTranslatedString $fail
+ * @param Closure(string, ?string=): PotentiallyTranslatedString $fail
*/
public function validate(string $attribute, mixed $value, Closure $fail): void
{
- if (!json_validate($value)) {
+ if (! is_string($value) || ! json_validate($value)) {
$fail(trans('validation.json'));
}
}