Skip to content

A free open source IT asset/license management system

Updated baseline

snipef8fdc067e7ff
diff --git a/app/Http/Controllers/Components/ComponentCheckoutController.php b/app/Http/Controllers/Components/ComponentCheckoutController.php
index 2723b63c75..dbed2a556d 100644
--- a/app/Http/Controllers/Components/ComponentCheckoutController.php
+++ b/app/Http/Controllers/Components/ComponentCheckoutController.php
@@ -29,11 +29,10 @@ class ComponentCheckoutController extends Controller
* @since [v3.0]
*
* @param int $id
- * @return View
*
* @throws AuthorizationException
*/
- public function create(Request $request, $id)
+ public function create(Request $request, $id): View|RedirectResponse
{
if ($component = Component::find($id)) {
diff --git a/app/Http/Controllers/Reports/CustomComponentReportController.php b/app/Http/Controllers/Reports/CustomComponentReportController.php
index a0845ba59b..9e167b697b 100644
--- a/app/Http/Controllers/Reports/CustomComponentReportController.php
+++ b/app/Http/Controllers/Reports/CustomComponentReportController.php
@@ -5,6 +5,7 @@ namespace App\Http\Controllers\Reports;
use App\Http\Controllers\Controller;
use App\Http\Requests\CustomComponentReportRequest;
use App\Models\Actionlog;
+use App\Models\Builders\ComponentQueryBuilder;
use App\Models\Component;
use App\Models\ReportTemplate;
use Carbon\Carbon;
@@ -270,7 +271,7 @@ class CustomComponentReportController extends Controller
return $headers;
}
- private function buildQuery(Request $request): Builder
+ private function buildQuery(Request $request): ComponentQueryBuilder
{
$query = Component::select('components.*')
->with([
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index d9b89e4f60..8c81f19338 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -1842,12 +1842,6 @@ parameters:
count: 1
path: app/Http/Controllers/Components/ComponentCheckoutController.php
- -
- message: '#^Method App\\Http\\Controllers\\Components\\ComponentCheckoutController\:\:create\(\) should return Illuminate\\Contracts\\View\\View but returns Illuminate\\Http\\RedirectResponse\.$#'
- identifier: return.type
- count: 3
- path: app/Http/Controllers/Components/ComponentCheckoutController.php
-
-
message: '#^Using nullsafe property access "\?\-\>name" on left side of \?\? is unnecessary\. Use \-\> instead\.$#'
identifier: nullsafe.neverNull
@@ -2220,6 +2214,12 @@ parameters:
count: 1
path: app/Http/Controllers/ReportTemplatesController.php
+ -
+ message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Builder\:\:notArchived\(\)\.$#'
+ identifier: method.notFound
+ count: 1
+ path: app/Http/Controllers/Reports/CustomComponentReportController.php
+
-
message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Builder\:\:onlyTrashed\(\)\.$#'
identifier: method.notFound
@@ -2232,6 +2232,12 @@ parameters:
count: 1
path: app/Http/Controllers/Reports/CustomComponentReportController.php
+ -
+ message: '#^Method App\\Http\\Controllers\\Reports\\CustomComponentReportController\:\:buildQuery\(\) should return App\\Models\\Builders\\ComponentQueryBuilder but returns Illuminate\\Database\\Eloquent\\Builder\.$#'
+ identifier: return.type
+ count: 1
+ path: app/Http/Controllers/Reports/CustomComponentReportController.php
+
-
message: '#^Call to an undefined method Illuminate\\Database\\Eloquent\\Builder\:\:onlyTrashed\(\)\.$#'
identifier: method.notFound
@@ -2739,7 +2745,7 @@ parameters:
-
message: '#^Access to an undefined property Illuminate\\Database\\Eloquent\\Model\:\:\$pivot\.$#'
identifier: property.notFound
- count: 6
+ count: 7
path: app/Http/Transformers/ComponentsTransformer.php
-