Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

SOLR-17951: satiate errorprone's ImmutableEnumChecker

Chris Hostetter073d82d22d09
diff --git a/solr/core/src/java/org/apache/solr/search/ReRankOperator.java b/solr/core/src/java/org/apache/solr/search/ReRankOperator.java
index b3b5582836c..9072a18e25e 100644
--- a/solr/core/src/java/org/apache/solr/search/ReRankOperator.java
+++ b/solr/core/src/java/org/apache/solr/search/ReRankOperator.java
@@ -25,6 +25,12 @@ public enum ReRankOperator implements DoubleBinaryOperator {
MULTIPLY((firstPass, secondPass) -> firstPass * secondPass),
REPLACE((firstPass, secondPass) -> secondPass);
+ /**
+ * The operators we use <em>are</em> immutable, even if we can't annotate them as such, and
+ * errorprone's "TIP" of using abstract methods would make this enum declaration 5 times longer --
+ * so no thanks.
+ */
+ @SuppressWarnings("ImmutableEnumChecker")
private final DoubleBinaryOperator op;
private ReRankOperator(final DoubleBinaryOperator op) {