Apache Solr open-source search software
disable-useless-errorprone-checks (#1201)
Kevin Risden0bbff1b2c0f6
diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradleindex 6dba70b5009..72d0e3cfc87 100644--- a/gradle/validation/error-prone.gradle+++ b/gradle/validation/error-prone.gradle@@ -67,11 +67,13 @@ allprojects { prj ->// List of enabled/disabled checks// Please keep this synced with https://errorprone.info/bugpatterns when upgrading!+ // Do *NOT* enable checks based on their name or description. Read the source code and make sure they are useful!+ // Most error-prone checks are not useful for non-google software.// On by Default : ERROR'-Xep:AlwaysThrows:ERROR',- '-Xep:AndroidInjectionBeforeSuper:ERROR',+ // '-Xep:AndroidInjectionBeforeSuper:OFF', // we don't use android'-Xep:ArrayEquals:ERROR','-Xep:ArrayFillIncompatibleType:ERROR','-Xep:ArrayHashCode:ERROR',@@ -79,31 +81,31 @@ allprojects { prj ->'-Xep:ArraysAsListPrimitiveArray:ERROR','-Xep:AsyncCallableReturnsNull:ERROR','-Xep:AsyncFunctionReturnsNull:ERROR',- '-Xep:AutoValueBuilderDefaultsInConstructor:ERROR',- '-Xep:AutoValueConstructorOrderChecker:ERROR',+ // '-Xep:AutoValueBuilderDefaultsInConstructor:OFF', // we don't use autovalue+ // '-Xep:AutoValueConstructorOrderChecker:OFF', // we don't use autovalue'-Xep:BadAnnotationImplementation:ERROR','-Xep:BadShiftAmount:ERROR',- '-Xep:BanJNDI:ERROR',+ '-Xep:BanJNDI:ERROR', // todo - implement with forbidden APIs instead?'-Xep:BoxedPrimitiveEquality:ERROR',- '-Xep:BundleDeserializationCast:ERROR',+ // '-Xep:BundleDeserializationCast:OFF', // we don't use android'-Xep:ChainingConstructorIgnoresParameter:ERROR','-Xep:CheckNotNullMultipleTimes:ERROR',- '-Xep:CheckReturnValue:ERROR',+ // '-Xep:CheckReturnValue:OFF', // we don't use these annotations'-Xep:CollectionToArraySafeParameter:ERROR',// '-Xep:ComparableType:OFF', // SolrTestCaseJ4.Doc and Fld are messy'-Xep:ComparingThisWithNull:ERROR','-Xep:ComparisonOutOfRange:ERROR',- '-Xep:CompatibleWithAnnotationMisuse:ERROR',- '-Xep:CompileTimeConstant:ERROR',+ // '-Xep:CompatibleWithAnnotationMisuse:OFF', // we don't use this annotation+ // '-Xep:CompileTimeConstant:OFF', // we don't use this annotation'-Xep:ComputeIfAbsentAmbiguousReference:ERROR','-Xep:ConditionalExpressionNumericPromotion:ERROR','-Xep:ConstantOverflow:ERROR',- '-Xep:DaggerProvidesNull:ERROR',+ // '-Xep:DaggerProvidesNull:OFF', // we don't use dagger'-Xep:DangerousLiteralNull:ERROR','-Xep:DeadException:ERROR','-Xep:DeadThread:ERROR','-Xep:DiscardedPostfixExpression:ERROR',- '-Xep:DoNotCall:ERROR',+ // '-Xep:DoNotCall:OFF', // we don't use this annotation'-Xep:DoNotMock:ERROR','-Xep:DoubleBraceInitialization:ERROR','-Xep:DuplicateMapKeys:ERROR',@@ -117,36 +119,36 @@ allprojects { prj ->'-Xep:EqualsNull:ERROR','-Xep:EqualsReference:ERROR','-Xep:EqualsWrongThing:ERROR',- '-Xep:FloggerFormatString:ERROR',- '-Xep:FloggerLogVarargs:ERROR',- '-Xep:FloggerSplitLogStatement:ERROR',- '-Xep:ForOverride:ERROR',+ // '-Xep:FloggerFormatString:OFF', // we don't use flogger+ // '-Xep:FloggerLogVarargs:OFF', // we don't use flogger+ // '-Xep:FloggerSplitLogStatement:OFF', // we don't use flogger+ // '-Xep:ForOverride:OFF', // we don't use this annotation'-Xep:FormatString:ERROR',- '-Xep:FormatStringAnnotation:ERROR',+ // '-Xep:FormatStringAnnotation:OFF', // we don't use this annotation'-Xep:FromTemporalAccessor:ERROR','-Xep:FunctionalInterfaceMethodChanged:ERROR','-Xep:FuturesGetCheckedIllegalExceptionType:ERROR','-Xep:FuzzyEqualsShouldNotBeUsedInEqualsMethod:ERROR','-Xep:GetClassOnAnnotation:ERROR','-Xep:GetClassOnClass:ERROR',- '-Xep:GuardedBy:ERROR',- '-Xep:GuiceAssistedInjectScoping:ERROR',- '-Xep:GuiceAssistedParameters:ERROR',- '-Xep:GuiceInjectOnFinalField:ERROR',+ // '-Xep:GuardedBy:OFF', // we don't use this annotation+ // '-Xep:GuiceAssistedInjectScoping:OFF', // we don't use guice+ // '-Xep:GuiceAssistedParameters:OFF', // we don't use guice+ // '-Xep:GuiceInjectOnFinalField:OFF', // we don't use guice'-Xep:HashtableContains:ERROR','-Xep:IdentityBinaryExpression:ERROR','-Xep:IdentityHashMapBoxing:ERROR',- '-Xep:IgnoredPureGetter:ERROR',- '-Xep:Immutable:ERROR',+ // '-Xep:IgnoredPureGetter:OFF', // we don't use these annotations+ // '-Xep:Immutable:OFF', // we don't use this annotation'-Xep:Incomparable:ERROR',- '-Xep:IncompatibleArgumentType:ERROR',- '-Xep:IncompatibleModifiers:ERROR',+ // '-Xep:IncompatibleArgumentType:OFF', // we don't use this annotation+ // '-Xep:IncompatibleModifiers:OFF', // we don't use this annotation'-Xep:IndexOfChar:ERROR','-Xep:InexactVarargsConditional:ERROR','-Xep:InfiniteRecursion:ERROR',- '-Xep:InjectMoreThanOneScopeAnnotationOnClass:ERROR',- '-Xep:InjectOnMemberAndConstructor:ERROR',- '-Xep:InlineMeValidator:ERROR',+ '-Xep:InjectMoreThanOneScopeAnnotationOnClass:ERROR', // todo - check if we use this annotation?+ '-Xep:InjectOnMemberAndConstructor:ERROR', // todo - check if we use this annotation?+ // '-Xep:InlineMeValidator:OFF', // we don't use this annotation'-Xep:InstantTemporalUnit:ERROR','-Xep:InvalidJavaTimeConstant:ERROR','-Xep:InvalidPatternSyntax:ERROR',@@ -154,11 +156,11 @@ allprojects { prj ->'-Xep:InvalidZoneId:ERROR','-Xep:IsInstanceIncompatibleType:ERROR','-Xep:IsInstanceOfClass:ERROR',- '-Xep:IsLoggableTagLength:ERROR',- '-Xep:JUnit3TestNotRun:ERROR',+ // '-Xep:IsLoggableTagLength:OFF', // we don't use android+ // '-Xep:JUnit3TestNotRun:OFF', // we don't use junit3'-Xep:JUnit4ClassAnnotationNonStatic:ERROR',- '-Xep:JUnit4SetUpNotRun:ERROR',- '-Xep:JUnit4TearDownNotRun:ERROR',+ // '-Xep:JUnit4SetUpNotRun:OFF', // LuceneTestCase takes care+ // '-Xep:JUnit4TearDownNotRun:OFF', // LuceneTestCase takes care// '-Xep:JUnit4TestNotRun:OFF', // RandomizedRunner finds unannotated test methods no problem'-Xep:JUnit4TestsNotRunWithinEnclosed:ERROR','-Xep:JUnitAssertSameCheck:ERROR',@@ -171,33 +173,33 @@ allprojects { prj ->'-Xep:LoopConditionChecker:ERROR','-Xep:LossyPrimitiveCompare:ERROR','-Xep:MathRoundIntLong:ERROR',- '-Xep:MislabeledAndroidString:ERROR',- '-Xep:MisplacedScopeAnnotations:ERROR',- '-Xep:MissingSuperCall:ERROR',- '-Xep:MissingTestCall:ERROR',+ // '-Xep:MislabeledAndroidString:OFF', // we don't use android+ '-Xep:MisplacedScopeAnnotations:ERROR', // todo - check if we use this annotation?+ // '-Xep:MissingSuperCall:OFF', // we don't use this annotation+ // '-Xep:MissingTestCall:OFF', // we don't use this annotation'-Xep:MisusedDayOfYear:ERROR','-Xep:MisusedWeekYear:ERROR','-Xep:MixedDescriptors:ERROR','-Xep:MockitoUsage:ERROR','-Xep:ModifyingCollectionWithItself:ERROR',- '-Xep:MoreThanOneInjectableConstructor:ERROR',- '-Xep:MustBeClosedChecker:ERROR',+ '-Xep:MoreThanOneInjectableConstructor:ERROR', // todo - check if we use this annotation?+ // '-Xep:MustBeClosedChecker:OFF', // we don't use this annotation'-Xep:NCopiesOfChar:ERROR','-Xep:NoCanIgnoreReturnValueOnClasses:ERROR','-Xep:NonCanonicalStaticImport:ERROR',- '-Xep:NonFinalCompileTimeConstant:ERROR',+ // '-Xep:NonFinalCompileTimeConstant:OFF', // we don't use this annotation'-Xep:NonRuntimeAnnotation:ERROR',- '-Xep:NullArgumentForNonNullParameter:ERROR',+ // '-Xep:NullArgumentForNonNullParameter:OFF', // we don't use this annotation'-Xep:NullTernary:ERROR',- '-Xep:NullableOnContainingClass:ERROR',+ // '-Xep:NullableOnContainingClass:OFF', // we don't use this annotation'-Xep:OptionalEquality:ERROR','-Xep:OptionalMapUnusedValue:ERROR','-Xep:OptionalOfRedundantMethod:ERROR',- '-Xep:OverlappingQualifierAndScopeAnnotation:ERROR',+ '-Xep:OverlappingQualifierAndScopeAnnotation:ERROR', // todo - check if we use this annotation?'-Xep:OverridesJavaxInjectableMethod:ERROR','-Xep:PackageInfo:ERROR','-Xep:ParametersButNotParameterized:ERROR',- '-Xep:ParcelableCreator:ERROR',+ // '-Xep:ParcelableCreator:OFF', // we don't use android'-Xep:PeriodFrom:ERROR','-Xep:PeriodGetTemporalUnit:ERROR','-Xep:PeriodTimeMath:ERROR',@@ -208,29 +210,29 @@ allprojects { prj ->'-Xep:ProtoStringFieldReferenceEquality:ERROR','-Xep:ProtoTruthMixedDescriptors:ERROR','-Xep:ProtocolBufferOrdinal:ERROR',- '-Xep:ProvidesMethodOutsideOfModule:ERROR',+ // '-Xep:ProvidesMethodOutsideOfModule:OFF', // we don't use guice'-Xep:RandomCast:ERROR','-Xep:RandomModInteger:ERROR',- '-Xep:RectIntersectReturnValueIgnored:ERROR',- '-Xep:RequiredModifiers:ERROR',- '-Xep:RestrictedApiChecker:ERROR',+ // '-Xep:RectIntersectReturnValueIgnored:OFF', // we don't use android+ // '-Xep:RequiredModifiers:OFF', // we don't use this annotation+ // '-Xep:RestrictedApiChecker:OFF', // we don't use this annotation// '-Xep:ReturnValueIgnored:OFF', // todo check if useful or comment why not'-Xep:SelfAssignment:ERROR','-Xep:SelfComparison:ERROR','-Xep:SelfEquals:ERROR',- '-Xep:ShouldHaveEvenArgs:ERROR',+ // '-Xep:ShouldHaveEvenArgs:OFF', // we don't use truth'-Xep:SizeGreaterThanOrEqualsZero:ERROR','-Xep:StreamToString:ERROR','-Xep:StringBuilderInitWithChar:ERROR','-Xep:SubstringOfZero:ERROR','-Xep:SuppressWarningsDeprecated:ERROR','-Xep:TemporalAccessorGetChronoField:ERROR',- '-Xep:TestParametersNotInitialized:ERROR',- '-Xep:TheoryButNoTheories:ERROR',- '-Xep:ThrowIfUncheckedKnownChecked:ERROR',+ // '-Xep:TestParametersNotInitialized:OFF', // we don't use this annotation+ // '-Xep:TheoryButNoTheories:OFF', // we don't use junit theory apis/runner+ // '-Xep:ThrowIfUncheckedKnownChecked:OFF', // we don't use this annotation'-Xep:ThrowNull:ERROR','-Xep:TreeToString:ERROR',- '-Xep:TruthSelfEquals:ERROR',+ // '-Xep:TruthSelfEquals:OFF', // we don't use truth'-Xep:TryFailThrowable:ERROR','-Xep:TypeParameterQualifier:ERROR','-Xep:UnicodeDirectionalityCharacters:ERROR',@@ -250,16 +252,16 @@ allprojects { prj ->'-Xep:AlmostJavadoc:WARN',// '-Xep:AlreadyChecked:OFF', // todo check if useful or comment why not// '-Xep:AmbiguousMethodReference:OFF', // todo check if useful or comment why not- '-Xep:AnnotateFormatMethod:WARN',+ // '-Xep:AnnotateFormatMethod:OFF', // we don't use this annotation// '-Xep:ArgumentSelectionDefectChecker:OFF', // todo check if useful or comment why not'-Xep:ArrayAsKeyOfSetOrMap:WARN','-Xep:AssertEqualsArgumentOrderChecker:WARN','-Xep:AssertThrowsMultipleStatements:WARN','-Xep:AssertionFailureIgnored:WARN',- '-Xep:AssistedInjectAndInjectOnSameConstructor:WARN',- '-Xep:AutoValueFinalMethods:WARN',- '-Xep:AutoValueImmutableFields:WARN',- '-Xep:AutoValueSubclassLeaked:WARN',+ '-Xep:AssistedInjectAndInjectOnSameConstructor:WARN', // todo - check if we use this annotation?+ // '-Xep:AutoValueFinalMethods:OFF', // we don't use autovalue+ // '-Xep:AutoValueImmutableFields:OFF', // we don't use autovalue+ // '-Xep:AutoValueSubclassLeaked:OFF', // we don't use autovalue'-Xep:BadComparable:WARN',// '-Xep:BadImport:OFF', // style preference that we don't want to enforce'-Xep:BadInstanceof:WARN',@@ -267,7 +269,7 @@ allprojects { prj ->'-Xep:BigDecimalEquals:WARN','-Xep:BigDecimalLiteralDouble:WARN','-Xep:BoxedPrimitiveConstructor:WARN',- '-Xep:BugPatternNaming:WARN',+ // '-Xep:BugPatternNaming:OFF', // we don't use this annotation'-Xep:ByteBufferBackingArray:WARN','-Xep:CacheLoaderNull:WARN','-Xep:CanonicalDuration:WARN',@@ -278,7 +280,7 @@ allprojects { prj ->'-Xep:CharacterGetNumericValue:WARN','-Xep:ClassCanBeStatic:WARN','-Xep:ClassNewInstance:WARN',- '-Xep:CloseableProvides:WARN',+ // '-Xep:CloseableProvides:OFF', // we don't use this annotation'-Xep:CollectionUndefinedEquality:WARN','-Xep:CollectorShouldNotUseState:WARN','-Xep:ComparableAndComparator:WARN',@@ -286,18 +288,18 @@ allprojects { prj ->// '-Xep:ComplexBooleanConstant:OFF', // non trivial to fix in some cases'-Xep:DateChecker:WARN','-Xep:DateFormatConstant:WARN',- '-Xep:DefaultCharset:WARN',+ // '-Xep:DefaultCharset:OFF', // we have forbiddenapis for that'-Xep:DefaultPackage:WARN','-Xep:DeprecatedVariable:WARN','-Xep:DirectInvocationOnMock:WARN','-Xep:DistinctVarargsChecker:WARN',- '-Xep:DoNotCallSuggester:WARN',- '-Xep:DoNotClaimAnnotations:WARN',- '-Xep:DoNotMockAutoValue:WARN',+ // '-Xep:DoNotCallSuggester:OFF', // we don't use this annotation+ // '-Xep:DoNotClaimAnnotations:OFF', // we don't use this annotation+ // '-Xep:DoNotMockAutoValue:OFF', // we don't use autovalue// '-Xep:DoubleCheckedLocking:OFF', // todo check if useful or comment why not'-Xep:EmptyBlockTag:WARN',// '-Xep:EmptyCatch:OFF', // todo check if useful or comment why not - might be handled by ECJ?- '-Xep:EmptySetMultibindingContributions:WARN',+ // '-Xep:EmptySetMultibindingContributions:OFF', // we don't use this annotation'-Xep:EqualsGetClass:WARN','-Xep:EqualsIncompatibleType:WARN','-Xep:EqualsUnsafeCast:WARN',@@ -312,29 +314,29 @@ allprojects { prj ->'-Xep:FloatCast:WARN','-Xep:FloatingPointAssertionWithinEpsilon:WARN','-Xep:FloatingPointLiteralPrecision:WARN',- '-Xep:FloggerArgumentToString:WARN',- '-Xep:FloggerStringConcatenation:WARN',- '-Xep:FragmentInjection:WARN',- '-Xep:FragmentNotInstantiable:WARN',+ // '-Xep:FloggerArgumentToString:OFF', // we don't use flogger+ // '-Xep:FloggerStringConcatenation:OFF', // we don't use flogger+ // '-Xep:FragmentInjection:OFF', // we don't use android+ // '-Xep:FragmentNotInstantiable:OFF', // we don't use android// '-Xep:FutureReturnValueIgnored:OFF', // todo check if useful or comment why not'-Xep:GetClassOnEnum:WARN','-Xep:HidingField:WARN','-Xep:IdentityHashMapUsage:WARN',- '-Xep:ImmutableAnnotationChecker:WARN',+ // '-Xep:ImmutableAnnotationChecker:OFF', // we don't use this annotation'-Xep:ImmutableEnumChecker:WARN','-Xep:InconsistentCapitalization:WARN','-Xep:InconsistentHashCode:WARN','-Xep:IncorrectMainMethod:WARN','-Xep:IncrementInForLoopAndHeader:WARN','-Xep:InheritDoc:WARN',- '-Xep:InjectInvalidTargetingOnScopingAnnotation:WARN',+ // '-Xep:InjectInvalidTargetingOnScopingAnnotation:OFF', // we don't use this annotation'-Xep:InjectOnConstructorOfAbstractClass:WARN','-Xep:InjectScopeAnnotationOnInterfaceOrAbstractClass:WARN','-Xep:InjectedConstructorAnnotations:WARN',// '-Xep:InlineFormatString:OFF', // this introduces redundancy in format strings- '-Xep:InlineMeInliner:WARN',+ // '-Xep:InlineMeInliner:OFF', // we don't use this annotation// '-Xep:InlineMeSuggester:OFF', // We don't use this annotation- // '-Xep:InputStreamSlowMultibyteRead:OFF' // todo check if useful or comment why not,+ // '-Xep:InputStreamSlowMultibyteRead:OFF', // todo check if useful or comment why not'-Xep:InstanceOfAndCastMatchWrongType:WARN','-Xep:IntLongMath:WARN',// '-Xep:InvalidBlockTag:OFF', // this is needed for tags like lucene.internal@@ -344,9 +346,9 @@ allprojects { prj ->'-Xep:InvalidThrows:WARN','-Xep:InvalidThrowsLink:WARN','-Xep:IterableAndIterator:WARN',- '-Xep:JUnit3FloatingPointComparisonWithoutDelta:WARN',- '-Xep:JUnit4ClassUsedInJUnit3:WARN',- '-Xep:JUnitAmbiguousTestClass:WARN',+ // '-Xep:JUnit3FloatingPointComparisonWithoutDelta:OFF', // we don't use junit3+ // '-Xep:JUnit4ClassUsedInJUnit3:OFF', // we don't use junit3+ // '-Xep:JUnitAmbiguousTestClass:OFF', // we don't use junit3'-Xep:JavaDurationGetSecondsGetNano:WARN','-Xep:JavaDurationWithNanos:WARN','-Xep:JavaDurationWithSeconds:WARN',@@ -355,7 +357,7 @@ allprojects { prj ->'-Xep:JavaLocalDateTimeGetNano:WARN','-Xep:JavaLocalTimeGetNano:WARN','-Xep:JavaPeriodGetDays:WARN',- '-Xep:JavaTimeDefaultTimeZone:WARN',+ // '-Xep:JavaTimeDefaultTimeZone:OFF', // forbidden-apis checks this// '-Xep:JavaUtilDate:OFF', // todo check if useful or comment why not'-Xep:JavaxInjectOnFinalField:WARN','-Xep:JdkObsolete:WARN',@@ -376,7 +378,7 @@ allprojects { prj ->'-Xep:LoopOverCharArray:WARN','-Xep:MalformedInlineTag:WARN','-Xep:MathAbsoluteRandom:WARN',- '-Xep:MemoizeConstantVisitorStateLookups:WARN',+ // '-Xep:MemoizeConstantVisitorStateLookups:OFF', // we don't use this class'-Xep:MissingCasesInEnumSwitch:WARN','-Xep:MissingFail:WARN','-Xep:MissingImplementsComparable:WARN',@@ -398,10 +400,10 @@ allprojects { prj ->// '-Xep:NonCanonicalType:OFF', // todo check if useful or comment why not'-Xep:NonOverridingEquals:WARN','-Xep:NullOptional:WARN',- '-Xep:NullableConstructor:WARN',- '-Xep:NullablePrimitive:WARN',- '-Xep:NullablePrimitiveArray:WARN',- '-Xep:NullableVoid:WARN',+ // '-Xep:NullableConstructor:OFF', // we don't use this annotation+ // '-Xep:NullablePrimitive:OFF', // we don't use this annotation+ // '-Xep:NullablePrimitiveArray:OFF', // we don't use this annotation+ // '-Xep:NullableVoid:OFF', // we don't use this annotation'-Xep:ObjectEqualsForPrimitives:WARN',// '-Xep:ObjectToString:OFF', // todo check if useful or comment why not'-Xep:ObjectsHashCodePrimitive:WARN',@@ -409,7 +411,7 @@ allprojects { prj ->'-Xep:OptionalMapToOptional:WARN','-Xep:OptionalNotPresent:WARN','-Xep:OrphanedFormatString:WARN',- '-Xep:OutlineNone:WARN',+ // '-Xep:OutlineNone:OFF', // we don't use gwt'-Xep:OverrideThrowableToString:WARN','-Xep:Overrides:WARN','-Xep:OverridesGuiceInjectableMethod:WARN',@@ -437,7 +439,7 @@ allprojects { prj ->// '-Xep:StreamResourceLeak:OFF', // todo check if useful or comment why not'-Xep:StreamToIterable:WARN',// '-Xep:StringSplitter:OFF', // todo check if useful or comment why not - might be able to use forbidden-apis for this?- '-Xep:SwigMemoryLeak:WARN',+ // '-Xep:SwigMemoryLeak:OFF', // we don't use swig// '-Xep:SynchronizeOnNonFinalField:OFF', // todo check if useful or comment why not// '-Xep:ThreadJoinLoop:OFF', // todo check if useful or comment why not// '-Xep:ThreadLocalUsage:OFF', // todo check if useful or comment why not@@ -445,10 +447,10 @@ allprojects { prj ->'-Xep:ThreeLetterTimeZoneID:WARN','-Xep:TimeUnitConversionChecker:WARN','-Xep:ToStringReturnsNull:WARN',- '-Xep:TruthAssertExpected:WARN',- '-Xep:TruthConstantAsserts:WARN',- '-Xep:TruthGetOrDefault:WARN',- '-Xep:TruthIncompatibleType:WARN',+ // '-Xep:TruthAssertExpected:OFF', // we don't use truth+ // '-Xep:TruthConstantAsserts:OFF', // we don't use truth+ // '-Xep:TruthGetOrDefault:OFF', // we don't use truth+ // '-Xep:TruthIncompatibleType:OFF', // we don't use truth'-Xep:TypeEquals:WARN','-Xep:TypeNameShadowing:WARN',// '-Xep:TypeParameterShadowing:OFF', // todo check if useful or comment why not@@ -457,7 +459,7 @@ allprojects { prj ->'-Xep:UndefinedEquals:WARN','-Xep:UnescapedEntity:WARN',// '-Xep:UnicodeEscape:OFF', // can't enable since Lucene/Solr tests use unicode a bunch- '-Xep:UnnecessaryAssignment:WARN',+ // '-Xep:UnnecessaryAssignment:OFF', // we don't use these annotations'-Xep:UnnecessaryLambda:WARN','-Xep:UnnecessaryLongToIntConversion:WARN','-Xep:UnnecessaryMethodInvocationMatcher:WARN',@@ -471,12 +473,12 @@ allprojects { prj ->'-Xep:UnusedNestedClass:WARN','-Xep:UnusedTypeParameter:WARN',// '-Xep:UnusedVariable:OFF', // todo check if useful or comment why not - might be able to use ecj?- '-Xep:UseBinds:WARN',+ // '-Xep:UseBinds:OFF', // we don't use this annotation// '-Xep:UseCorrectAssertInTests:OFF', // we inherit from LuceneTestCase which extends Assert'-Xep:VariableNameSameAsType:WARN',// '-Xep:WaitNotInLoop:OFF', // todo check if useful or comment why not- '-Xep:WakelockReleasedDangerously:WARN',- '-Xep:WithSignatureDiscouraged:WARN',+ // '-Xep:WakelockReleasedDangerously:OFF', // we don't use android+ // '-Xep:WithSignatureDiscouraged:OFF', // we aren't using this error-prone internal api]}}