Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

SOLR-16741: refactor Replia.State.toString() (#1549)

Noble Paul27f69db8827d
diff --git a/solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java b/solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
index 7c2de199b4f..a336abcad60 100644
--- a/solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
+++ b/solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
@@ -78,13 +78,16 @@ public class Replica extends ZkNodeProps implements MapWriter {
*/
public final String shortName;
+ public final String longName;
+
State(String c) {
this.shortName = c;
+ this.longName = super.toString().toLowerCase(Locale.ROOT);
}
@Override
public String toString() {
- return super.toString().toLowerCase(Locale.ROOT);
+ return longName;
}
/** Converts the state string to a State instance. */
@@ -391,7 +394,7 @@ public class Replica extends ZkNodeProps implements MapWriter {
w.putIfNotNull(ReplicaStateProps.CORE_NAME, core)
.putIfNotNull(ReplicaStateProps.NODE_NAME, node)
.putIfNotNull(ReplicaStateProps.TYPE, type.toString())
- .putIfNotNull(ReplicaStateProps.STATE, getState().toString().toLowerCase(Locale.ROOT))
+ .putIfNotNull(ReplicaStateProps.STATE, getState().toString())
.putIfNotNull(ReplicaStateProps.LEADER, () -> isLeader() ? "true" : null)
.putIfNotNull(
ReplicaStateProps.FORCE_SET_STATE, propMap.get(ReplicaStateProps.FORCE_SET_STATE))