Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

removing explicit check on outputField in TextToVectorUpdateProcessorFactory.java, check is already done by late… (#3666)

Renato Haeberli2a03deee6491
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index ed4924a39ea..0584672fa1c 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -61,6 +61,8 @@ Improvements
* Minor refactoring of the TextToVectorQParserPlugin (Ilaria Petreti via Alessandro Benedetti)
+* GITHUB#3666: Removing redundant check if field exists in TextToVectorUpdateProcessorFactory (Renato Haeberli via Alessandro Benedetti)
+
Optimizations
---------------------
* SOLR-17568: The CLI bin/solr export tool now contacts the appropriate nodes directly for data instead of proxying through one.
diff --git a/solr/modules/llm/src/java/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactory.java b/solr/modules/llm/src/java/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactory.java
index 07653df62dd..c4f7ea2924f 100644
--- a/solr/modules/llm/src/java/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactory.java
+++ b/solr/modules/llm/src/java/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactory.java
@@ -76,10 +76,6 @@ public class TextToVectorUpdateProcessorFactory extends UpdateRequestProcessorFa
SolrException.ErrorCode.SERVER_ERROR, "undefined field: \"" + inputField + "\"");
}
- if (!latestSchema.isDynamicField(outputField) && !latestSchema.hasExplicitField(outputField)) {
- throw new SolrException(
- SolrException.ErrorCode.SERVER_ERROR, "undefined field: \"" + outputField + "\"");
- }
final SchemaField outputFieldSchema = latestSchema.getField(outputField);
assertIsDenseVectorField(outputFieldSchema);