Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

Remove broken and unused ZkStateReader.getReplicaProps() (#3059)

Pierre Salagnac41a7cd50141f
diff --git a/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java b/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java
index f450c11668d..4f11b43a150 100644
--- a/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java
+++ b/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java
@@ -1002,30 +1002,12 @@ public class ZkStateReader implements SolrCloseable {
public List<ZkCoreNodeProps> getReplicaProps(
String collection, String shardId, String thisCoreNodeName) {
- return getReplicaProps(collection, shardId, thisCoreNodeName, null);
- }
-
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection,
- String shardId,
- String thisCoreNodeName,
- Replica.State mustMatchStateFilter) {
- return getReplicaProps(collection, shardId, thisCoreNodeName, mustMatchStateFilter, null);
- }
-
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection,
- String shardId,
- String thisCoreNodeName,
- Replica.State mustMatchStateFilter,
- Replica.State mustNotMatchStateFilter) {
- // TODO: We don't need all these getReplicaProps method overloading. Also, it's odd that the
- // default is to return replicas of type TLOG and NRT only
+ // TODO: It's odd that the default is to return replicas of type TLOG and NRT only
return getReplicaProps(
collection,
shardId,
thisCoreNodeName,
- mustMatchStateFilter,
+ null,
null,
EnumSet.of(Replica.Type.TLOG, Replica.Type.NRT));
}