Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

Test fix: flaky doc-order assertions in TextToVectorUpdateProcessorTest (#4879)

David Smiley5c7840131265
diff --git a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessorTest.java b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessorTest.java
index 2b948786d2a..06711ae4919 100644
--- a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessorTest.java
+++ b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessorTest.java
@@ -77,6 +77,9 @@ public class TextToVectorUpdateProcessorTest extends TestLanguageModelBase {
final SolrQuery query = new SolrQuery();
query.setQuery(solrQuery);
query.add("fl", "id,vector");
+ // *:* gives every doc the same score, so without an explicit sort the order between
+ // tied docs is arbitrary (depends on segment/merge timing), which made this flaky.
+ query.setSort("id", SolrQuery.ORDER.desc);
return query;
}
@@ -187,10 +190,10 @@ public class TextToVectorUpdateProcessorTest extends TestLanguageModelBase {
assertJQ(
"/query" + query.toQueryString(),
"/response/numFound==2]",
- "/response/docs/[0]/id=='98'",
- "!/response/docs/[0]/vector==", // no vector field for document 98
- "/response/docs/[1]/id=='99'",
- "/response/docs/[1]/vector==[1.0, 2.0, 3.0, 4.0]");
+ "/response/docs/[0]/id=='99'",
+ "/response/docs/[0]/vector==[1.0, 2.0, 3.0, 4.0]",
+ "/response/docs/[1]/id=='98'",
+ "!/response/docs/[1]/vector=="); // no vector field for document 98
restTestHarness.delete(TextToVectorModelStore.REST_END_POINT + "/dummy-1");
}