Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

LUCENE-9554: Expose IndexWriter#pendingNumDocs (#1941)

Nhat Nguyen7e04e4d0ca39
diff --git a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
index a5beda26ae5..7cc907af897 100644
--- a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
+++ b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
@@ -5463,6 +5463,14 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable,
throw new IllegalArgumentException("number of documents in the index cannot exceed " + actualMaxDocs + " (current document count is " + pendingNumDocs.get() + "; added numDocs is " + addedNumDocs + ")");
}
+ /**
+ * Returns the number of documents in the index including documents are being added (i.e., reserved).
+ * @lucene.experimental
+ */
+ public long getPendingNumDocs() {
+ return pendingNumDocs.get();
+ }
+
/** Returns the highest <a href="#sequence_number">sequence number</a> across
* all completed operations, or 0 if no operations have finished yet. Still
* in-flight operations (in other threads) are not counted until they finish.
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
index fc085ae0526..cc80e193b44 100644
--- a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
+++ b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
@@ -4238,4 +4238,24 @@ public class TestIndexWriter extends LuceneTestCase {
}
IOUtils.close(w, dir);
}
+
+ public void testPendingNumDocs() throws Exception {
+ try (Directory dir = newDirectory()) {
+ int numDocs = random().nextInt(100);
+ try (IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig())) {
+ for (int i = 0; i < numDocs; i++) {
+ Document d = new Document();
+ d.add(new StringField("id", Integer.toString(i), Field.Store.YES));
+ writer.addDocument(d);
+ assertEquals(i + 1L, writer.getPendingNumDocs());
+ }
+ assertEquals(numDocs, writer.getPendingNumDocs());
+ writer.flush();
+ assertEquals(numDocs, writer.getPendingNumDocs());
+ }
+ try (IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig())) {
+ assertEquals(numDocs, writer.getPendingNumDocs());
+ }
+ }
+ }
}