Apache Solr open-source search software
SOLR-15054: Test should not require private methods to be final (#2150)
Timothy Potter809d15115b45
diff --git a/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java b/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.javaindex 0a988f6e747..246ed981137 100644--- a/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java+++ b/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java@@ -66,7 +66,7 @@ public class ConfigureRecoveryStrategyTest extends SolrTestCaseJ4 {public void testAlmostAllMethodsAreFinal() throws Exception {for (Method m : RecoveryStrategy.class.getDeclaredMethods()) {- if (Modifier.isStatic(m.getModifiers())) continue;+ if (Modifier.isStatic(m.getModifiers()) || Modifier.isPrivate(m.getModifiers())) continue;final String methodName = m.getName();if ("getReplicateLeaderUrl".equals(methodName)) {assertFalse(m.toString(), Modifier.isFinal(m.getModifiers()));