Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

SOLR-17995: Remove deprecated coreUrl-dependent SolrStream ctors (#4970)

Jason Gerlowskid8ee6184f0be
diff --git a/solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java b/solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java
index 284e9f381fd..0412b505a8a 100644
--- a/solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java
+++ b/solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java
@@ -70,33 +70,10 @@ public class SolrStream extends TupleStream {
private transient boolean doCloseCache;
/**
- * @param collectionOrCoreUrl URL of the Solr core or collection to query, typically of the form
- * "http://host:8983/solr/myCore".
- * @param params query-parameters sent with the streaming request
- * @deprecated Use base URL constructor instead.
- */
- @Deprecated(since = "10.1")
- public SolrStream(String collectionOrCoreUrl, SolrParams params) {
- this.baseUrl = collectionOrCoreUrl;
- this.params = params;
- }
-
- // TODO SOLR-17995 proposes that we should deprecate this constructor in favor of one of the other
- // constructors that requires users to provide the core as an explicit parameter
- /**
- * @param collectionOrCoreUrl URL of the Solr core or collection to query, typically of the form
- * "http://host:8983/solr/myCore".
- * @param path the request handler path to query (e.g. "/export"). If not provided, defaults to
- * "/select".
- * @param params query-parameters sent with the streaming request
- * @deprecated Use base URL constructor instead.
- */
- @Deprecated(since = "10.1")
- public SolrStream(String collectionOrCoreUrl, String path, SolrParams params) {
- this(collectionOrCoreUrl, null, path, params);
- }
-
- /**
+ * Creates a Solr stream pointed at the specified URL and core.
+ *
+ * <p>"/select" is used as the default path unless "qt" is included in {@code params}
+ *
* @param baseUrl the Solr node's "base" URL (i.e. no core or collection in the path
* @param params query-parameters sent with the streaming request
* @param core the name of the collection or core to query; must be hosted at {@code baseUrl}