Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

SOLR-17256: Deprecate SolrRequest get/set BasePath and RequestWriter.getPath (#2494)

David Smileydfc8b587ea98
diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java b/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
index 7824ec7c392..4bb077065ce 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
@@ -248,12 +248,14 @@ public abstract class SolrRequest<T extends SolrResponse> implements Serializabl
return getParams() == null ? null : getParams().get("collection");
}
+ @Deprecated // SOLR-17256 Slated for removal in Solr 10; only used internally
public void setBasePath(String path) {
if (path.endsWith("/")) path = path.substring(0, path.length() - 1);
this.basePath = path;
}
+ @Deprecated // SOLR-17256 Slated for removal in Solr 10; only used internally
public String getBasePath() {
return basePath;
}
diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/request/RequestWriter.java b/solr/solrj/src/java/org/apache/solr/client/solrj/request/RequestWriter.java
index 6b4d87c57e8..e15c750f308 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/request/RequestWriter.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/request/RequestWriter.java
@@ -89,6 +89,7 @@ public class RequestWriter {
&& updateRequest.getDocIterator() == null;
}
+ @Deprecated // SOLR-17256 Slated for removal in Solr 10; only used internally
public String getPath(SolrRequest<?> req) {
return req.getPath();
}