Skip to content

armgit / solr

Public Imported from GitHub
0

Apache Solr open-source search software

SOLR-16427: Evaluate and fix errorprone rules - UnsynchronizedOverridesSynchronized

Kevin Risdene5a3f6c73ebd
diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradle
index ac5593c7c1a..98bfe25613b 100644
--- a/gradle/validation/error-prone.gradle
+++ b/gradle/validation/error-prone.gradle
@@ -131,7 +131,6 @@ allprojects { prj ->
'-Xep:UnescapedEntity:OFF',
'-Xep:UnicodeEscape:OFF',
'-Xep:UnnecessaryParentheses:OFF',
- '-Xep:UnsynchronizedOverridesSynchronized:OFF',
'-Xep:UnusedMethod:OFF',
'-Xep:UnusedVariable:OFF',
'-Xep:WaitNotInLoop:OFF',
diff --git a/solr/core/src/java/org/apache/solr/core/StandardDirectoryFactory.java b/solr/core/src/java/org/apache/solr/core/StandardDirectoryFactory.java
index 09078b6773c..75983dd4bb4 100644
--- a/solr/core/src/java/org/apache/solr/core/StandardDirectoryFactory.java
+++ b/solr/core/src/java/org/apache/solr/core/StandardDirectoryFactory.java
@@ -86,7 +86,7 @@ public class StandardDirectoryFactory extends CachingDirectoryFactory {
}
@Override
- protected void removeDirectory(CacheValue cacheValue) throws IOException {
+ protected synchronized void removeDirectory(CacheValue cacheValue) throws IOException {
Path dirPath = Path.of(cacheValue.path);
PathUtils.deleteDirectory(dirPath);
}