Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

Wave 433/509: Fillet rig: the concave arc where a bar's top meets a cylinder its sides run tangent into (and 2 more)

jyviko103b86f8f41f
diff --git a/crates/engine/src/naming_history_tests.rs b/crates/engine/src/naming_history_tests.rs
index 97560d42f7..e786049147 100644
--- a/crates/engine/src/naming_history_tests.rs
+++ b/crates/engine/src/naming_history_tests.rs
@@ -691,3 +691,25 @@ fn a_shell_point_pick_moved_off_its_face_reopens_only_that_face() {
assert!(solid_at(&s, [100.0, 16.0, 10.0]), "the bottom face stays closed");
assert!(!solid_at(&s, [149.0, 25.0, 10.0]), "the end at x = 150 is open");
}
+
+/// A two-distance chamfer of a plate's bottom front edge running 220 up the front face, past the
+/// 85 mm where the plate's sides start to taper (rig fillets/5181): the chamfer takes up the front
+/// face's straight side edges too, and lies between their faces, but it is made from the picked
+/// edge alone. Its one face has the picked edge's name everywhere on it (it was named after the
+/// left side's edge, l6, the first edge it took up).
+#[test]
+fn a_chamfer_running_past_the_side_edges_it_takes_up_is_named_by_its_edge() {
+ let mut s = Session::default();
+ run(&mut s, "sketch.create", json!({"plane": {"origin": [0, 0, 0], "x_dir": [1, 0, 0], "y_dir": [0, 0, 1]}, "name": "Bracket"}));
+ let taper = 30.675635228421154;
+ run(&mut s, "sketch.line", json!({"points": [[-50, 0], [50, 0], [50, 85], [taper, 222.5], [-taper, 222.5], [-50, 85]], "closed": true}));
+ run(&mut s, "sketch.finish", json!({}));
+ run(&mut s, "solid.extrude", json!({"sketch": "Bracket", "distance": 23, "body_name": "Bracket"}));
+ run(&mut s, "solid.chamfer", json!({"edges": [[0, 0, 0]], "distance": 220, "distance2": 11}));
+ let blends: Vec<String> = names(&s, "Bracket").into_iter().map(|(n, _)| n).filter(|n| n.starts_with("F3:blend:")).collect();
+ assert_eq!(blends, vec!["F3:blend:F2:side:l1|F2:start".to_string()]);
+ // On the chamfer's plane, through (x, -11, 0) and (x, 0, 220): below and above z = 85.
+ let on = |z: f64| Vec3::new(0.0, -11.0 * (1.0 - z / 220.0), z);
+ let at = solidcraft_doc::naming::face_names_at(&s.model.state(), &[on(40.0), on(150.0)]);
+ assert_eq!(at, vec![blends[0].clone(), blends[0].clone()]);
+}
diff --git a/crates/engine/src/tests.rs b/crates/engine/src/tests.rs
index 9cb46a158d..c1746a6225 100644
--- a/crates/engine/src/tests.rs
+++ b/crates/engine/src/tests.rs
@@ -493,6 +493,24 @@ fn rounds_on_a_bar_running_tangent_into_a_cylinder() {
}
}
+/// After the peg's front top round, the edge where that round runs into the cylinder's wall: its
+/// faces are tangent at its lower end (40, 0, 8), where the round's contact with the front face
+/// meets the wall's tangent line with it, and meet at a crease everywhere else. It is no smooth
+/// edge (it was refused as one, judged at that end alone); the wall's seam with the front face,
+/// tangent all along, still is.
+#[test]
+fn an_edge_tangent_at_one_end_only_is_not_smooth() {
+ let mut s = Session::default();
+ peg(&mut s);
+ run(&mut s, "solid.fillet", json!({"edges": [[20, 0, 10]], "radius": 2}));
+ let fillet = |s: &mut Session, at: [f64; 3]| s.execute("solid.fillet", &json!({"edges": [at], "radius": 1, "tangent_chain": false}));
+ if let Err(e) = fillet(&mut s, [37.2641, 0.4827, 9.3025]) {
+ assert!(!e.to_string().contains("is smooth"), "{e}");
+ }
+ let seam = fillet(&mut s, [40.0, 0.0, 4.0]).unwrap_err().to_string();
+ assert!(seam.contains("is smooth: its faces meet tangentially"), "{seam}");
+}
+
/// The top outline of two overlapping cylinders whose concave edges were rounded: the walls of
/// the rounds meet the cylinders along the rolling-ball contact lines, straight but not lines.
#[test]
diff --git a/crates/kernel/src/blend.rs b/crates/kernel/src/blend.rs
index 73ea6f0dec..ca67f4b677 100644
--- a/crates/kernel/src/blend.rs
+++ b/crates/kernel/src/blend.rs
@@ -682,17 +682,28 @@ fn normal_reach(rec: &Faces) -> f64 {
rec.rec.tolerance.max(1e-7) * 10.0
}
-/// Whether edge `e`'s two faces meet tangentially (within [`TANGENT_DEGREES`]) at its start: a
-/// smooth edge, with no corner to blend.
+/// Stations along an edge, as fractions of its interval, where [`smooth_join`] compares its
+/// faces' normals: its ends, and between them.
+const SMOOTH_STATIONS: [f64; 5] = [0.0, 0.25, 0.5, 0.75, 1.0];
+
+/// Whether edge `e`'s two faces meet tangentially (within [`TANGENT_DEGREES`]) all along it: a
+/// smooth edge, with no corner to blend. An edge whose faces are tangent at one end only (a
+/// round running into a wall it is tangent to where the wall meets its face) is a crease
+/// everywhere else, which is not smooth.
fn smooth_join(rec: &Faces, e: usize) -> bool {
let cos = TANGENT_DEGREES.to_radians().cos();
let accept = normal_reach(rec);
let faces: Vec<u32> = rec.faces_of(e).into_iter().collect();
- let (Some(&a), Some(&b), Some((p, _))) = (faces.first(), faces.get(1), rec.ends(e)) else { return false };
- match (rec.normal_at(a as usize, p, accept), rec.normal_at(b as usize, p, accept)) {
- (Some(na), Some(nb)) => faces.len() == 2 && na.dot(nb) > cos,
- _ => false,
- }
+ let ([a, b], Some(edge)) = (faces.as_slice(), rec.rec.edges.get(e)) else { return false };
+ let Ok(curve) = CurveEval::new(edge.parameters()) else { return false };
+ let [t0, t1] = edge.interval;
+ SMOOTH_STATIONS.iter().all(|s| {
+ let Some(p) = curve.point(t0 + (t1 - t0) * s) else { return false };
+ match (rec.normal_at(*a as usize, p, accept), rec.normal_at(*b as usize, p, accept)) {
+ (Some(na), Some(nb)) => na.dot(nb) > cos,
+ _ => false,
+ }
+ })
}
/// `seeds` (edges in the record's order, each once), then every other edge that continues one
diff --git a/crates/kernel/src/blend_smlib.rs b/crates/kernel/src/blend_smlib.rs
index 1e6e7e10f7..0f197e43ca 100644
--- a/crates/kernel/src/blend_smlib.rs
+++ b/crates/kernel/src/blend_smlib.rs
@@ -362,8 +362,8 @@ mod imp {
(Some(o), Some(ro)) => match r.history().map_err(|e| failed(what, "history", e))?.history(&[o], ro) {
Ok(mut h) => {
let operand = History::identity(body).edges;
- let replaced = blended(body, edges, &h);
- solidcraft_smlib::history::blends(&mut h, &operand, &replaced);
+ let taken_up = taken_up(body, edges, &h);
+ solidcraft_smlib::history::blends(&mut h, &operand, edges, &taken_up);
Some(with_corners(h))
}
Err(e) => {
@@ -414,10 +414,10 @@ mod imp {
h
}
- /// The operand's edges the blend replaced: each picked edge, and every edge no result edge
- /// comes from (one the blend's corners took up), in the operand's edge order.
- fn blended(body: &Body, picked: &[usize], h: &History) -> Vec<usize> {
- let mut out: BTreeSet<usize> = picked.iter().copied().collect();
+ /// The operand's edges the blend took up besides the picked ones: every edge no result edge
+ /// comes from (one the blend's corners took up, or one it ran over), in the operand's edge
+ /// order.
+ fn taken_up(body: &Body, picked: &[usize], h: &History) -> Vec<usize> {
let kept: BTreeSet<usize> = h
.edges
.iter()
@@ -427,8 +427,7 @@ mod imp {
_ => None,
})
.collect();
- out.extend((0..body.edge_count()).filter(|e| !kept.contains(e)));
- out.into_iter().collect()
+ (0..body.edge_count()).filter(|e| !kept.contains(e) && !picked.contains(e)).collect()
}
}
diff --git a/crates/smlib/src/history.rs b/crates/smlib/src/history.rs
index 5ad04c3a9b..b88b54d128 100644
--- a/crates/smlib/src/history.rs
+++ b/crates/smlib/src/history.rs
@@ -202,13 +202,17 @@ impl Raw {
}
}
-/// A blend's faces (fillet, chamfer) in `h`, the history of a blend of edges `blended` of its
+/// A blend's faces (fillet, chamfer) in `h`, the history of a blend of edges `picked` of its
/// one operand (operand 0), whose own edges `operand` lists (the faces each bounds, as in the
-/// operand's identity history): SMLib makes a blend face with no tag, so each Generated face is
-/// given [`FaceOrigin::Edge`] for every blended edge whose two faces both lie under faces next
-/// to it and no longer meet each other directly. A corner patch between several blends matches
-/// none of them and stays without origin.
-pub fn blends(h: &mut History, operand: &[EdgeProv], blended: &[usize]) {
+/// operand's identity history), which also took up edges `taken_up` (no result edge comes from
+/// them: a corner's short edge, or an edge the blend ran over): SMLib makes a blend face with no
+/// tag, so each Generated face is given [`FaceOrigin::Edge`] for every picked edge whose two
+/// faces both lie under faces next to it and no longer meet each other directly, and only where
+/// no picked edge is such, every taken-up edge that is. A chamfer running up past the end of the
+/// face beside it takes up that face's side edge and lies between its faces too: it is made from
+/// the picked edge alone. A corner patch between several blends matches none of them and stays
+/// without origin.
+pub fn blends(h: &mut History, operand: &[EdgeProv], picked: &[usize], taken_up: &[usize]) {
let mut next_to: Vec<BTreeSet<FaceOrigin>> = vec![BTreeSet::new(); h.faces.len()];
for e in &h.edges {
for f in &e.faces {
@@ -238,14 +242,18 @@ pub fn blends(h: &mut History, operand: &[EdgeProv], blended: &[usize]) {
if f.change != Change::Generated || !f.origins.is_empty() {
continue;
}
- let edges = blended.iter().filter(|e| {
+ let under = |e: &&usize| {
operand.get(**e).is_some_and(|p| {
let [a, b] = p.faces.as_slice() else { return false };
let (a, b) = (FaceOrigin::Face { operand: 0, face: *a }, FaceOrigin::Face { operand: 0, face: *b });
around.contains(&a) && around.contains(&b) && !meeting.contains(&(a.min(b), a.max(b)))
})
- });
- f.origins = edges.map(|e| FaceOrigin::Edge { operand: 0, edge: *e }).collect();
+ };
+ let mut edges: Vec<usize> = picked.iter().filter(under).copied().collect();
+ if edges.is_empty() {
+ edges = taken_up.iter().filter(under).copied().collect();
+ }
+ f.origins = edges.into_iter().map(|e| FaceOrigin::Edge { operand: 0, edge: e }).collect();
}
}
diff --git a/crates/smlib/src/history/tests.rs b/crates/smlib/src/history/tests.rs
index 06ecf734bf..6fdc4b9944 100644
--- a/crates/smlib/src/history/tests.rs
+++ b/crates/smlib/src/history/tests.rs
@@ -96,7 +96,7 @@ fn a_fillet_face_comes_from_its_edge() {
let mut h = History { operands: 1, faces, edges: vec![edge(4, 6), edge(5, 6), edge(0, 6), edge(2, 6), edge(0, 4)] };
// The operand's own edges: edge 0 between faces 4 and 5, edge 1 between 0 and 4.
let operand = vec![edge(4, 5), edge(0, 4)];
- blends(&mut h, &operand, &[0, 1]);
+ blends(&mut h, &operand, &[0], &[1]);
assert_eq!(h.faces[6].origins, vec![FaceOrigin::Edge { operand: 0, edge: 0 }]);
assert!(h.faces[..6].iter().all(|f| f.origins.len() == 1));
}
diff --git a/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues/expected.json b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues/expected.json
new file mode 100644
index 0000000000..db2aada47a
--- /dev/null
+++ b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues/expected.json
@@ -0,0 +1,11 @@
+{
+ "sources": [
+ "tangency-labs/solidcraft#1207"
+ ],
+ "what": "as 1207-fillet-concave-arc-bar-top-into-cylinder, with the sketch solver's residues of the reported design: SMLib's Nx1 corner fails (status 1001)",
+ "source": "analytic",
+ "method": "the same bar with the sketch solver's residues of the reported design (~1e-10 mm: the front side's ends differ by 3.0e-10 in y, the arc's centre 5.7e-11 off the disc's), length 41.160417754, V0 = 41.160417754 * 16.0000000000762 * 10 + 960 pi; the concave arc where the bar's top meets the cylinder's wall rounded r2: the spandrel ring added, clipped by the bar's sides y = 0 and y = 16 (as 1207-fillet-concave-arc-at-boss): integral over rho in [8, 10] of [2 - sqrt(4 - (10 - rho)^2)] rho 2 asin(8 / rho) = 18.4553684491 (Simpson)",
+ "body_count": 1,
+ "faces": 8,
+ "volume_mm3": 9620.051156581294
+}
diff --git a/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues/recipe.json b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues/recipe.json
new file mode 100644
index 0000000000..cedb6512f1
--- /dev/null
+++ b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues/recipe.json
@@ -0,0 +1,169 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": "XY",
+ "name": "Peg"
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0.4892940775280783,
+ 0.05792545052986289
+ ],
+ [
+ 41.64971183161969,
+ 0.05792545083296555
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.arc.center_point",
+ "params": {
+ "center": [
+ 41.64971183108453,
+ 8.057925450890195
+ ],
+ "start": [
+ 41.64971183161969,
+ 0.05792545083296555
+ ],
+ "end": [
+ 41.64971183161969,
+ 16.05792545083297
+ ]
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 41.64971183161969,
+ 16.05792545083297
+ ],
+ [
+ 0.4892940775280783,
+ 16.057925450606035
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0.4892940775280783,
+ 16.057925450606035
+ ],
+ [
+ 0.4892940775280783,
+ 0.05792545052986289
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "solid.extrude",
+ "params": {
+ "sketch": "Peg",
+ "distance": 10,
+ "body_name": "Peg"
+ }
+ },
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 10
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Top"
+ }
+ },
+ {
+ "command": "sketch.project",
+ "params": {
+ "refs": [
+ {
+ "face": [
+ 2.4892940775280783,
+ 8.057925450890195,
+ 10
+ ]
+ }
+ ]
+ }
+ },
+ {
+ "command": "sketch.circle.center",
+ "params": {
+ "center": [
+ 41.64971183108453,
+ 8.057925450832967
+ ],
+ "radius": 8.000000000006473
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "solid.extrude",
+ "params": {
+ "sketch": "Top",
+ "distance": 10,
+ "operation": "join",
+ "targets": [
+ "Peg"
+ ],
+ "profiles": [
+ {
+ "point": [
+ 41.64971183108453,
+ 8.057925450832967
+ ]
+ }
+ ],
+ "exact_regions": true
+ }
+ },
+ {
+ "command": "solid.fillet",
+ "params": {
+ "edges": [
+ [
+ 33.65,
+ 8.058,
+ 10
+ ]
+ ],
+ "radius": 2
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder/expected.json b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder/expected.json
new file mode 100644
index 0000000000..ab7af9c58d
--- /dev/null
+++ b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder/expected.json
@@ -0,0 +1,11 @@
+{
+ "sources": [
+ "tangency-labs/solidcraft#1207"
+ ],
+ "what": "an r2 round of the concave arc where a bar's top meets a cylinder its sides run tangent into",
+ "source": "analytic",
+ "method": "a bar 40 x 16 x 10 whose far end is a half disc R8 about (40, 8), a disc R8 about the same centre sketched on its top (the top's outline projected) and extruded 10 up, joined: the bar's sides run tangent into the cylinder, V0 = 6400 + 960 pi; the concave arc where the bar's top meets the cylinder's wall rounded r2: the spandrel ring added, clipped by the bar's sides y = 0 and y = 16 (as 1207-fillet-concave-arc-at-boss): integral over rho in [8, 10] of [2 - sqrt(4 - (10 - rho)^2)] rho 2 asin(8 / rho) = 18.4553684491 (Simpson)",
+ "body_count": 1,
+ "faces": 8,
+ "volume_mm3": 9434.384315895273
+}
diff --git a/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder/recipe.json b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder/recipe.json
new file mode 100644
index 0000000000..a548d6289b
--- /dev/null
+++ b/tests/kernel-cases/fillets/1207-fillet-concave-arc-bar-top-into-cylinder/recipe.json
@@ -0,0 +1,169 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": "XY",
+ "name": "Peg"
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0,
+ 0
+ ],
+ [
+ 40,
+ 0
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.arc.center_point",
+ "params": {
+ "center": [
+ 40,
+ 8
+ ],
+ "start": [
+ 40,
+ 0
+ ],
+ "end": [
+ 40,
+ 16
+ ]
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 40,
+ 16
+ ],
+ [
+ 0,
+ 16
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0,
+ 16
+ ],
+ [
+ 0,
+ 0
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "solid.extrude",
+ "params": {
+ "sketch": "Peg",
+ "distance": 10,
+ "body_name": "Peg"
+ }
+ },
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 10
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Top"
+ }
+ },
+ {
+ "command": "sketch.project",
+ "params": {
+ "refs": [
+ {
+ "face": [
+ 2,
+ 8,
+ 10
+ ]
+ }
+ ]
+ }
+ },
+ {
+ "command": "sketch.circle.center",
+ "params": {
+ "center": [
+ 40,
+ 8
+ ],
+ "radius": 8
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "solid.extrude",
+ "params": {
+ "sketch": "Top",
+ "distance": 10,
+ "operation": "join",
+ "targets": [
+ "Peg"
+ ],
+ "profiles": [
+ {
+ "point": [
+ 40,
+ 8
+ ]
+ }
+ ],
+ "exact_regions": true
+ }
+ },
+ {
+ "command": "solid.fillet",
+ "params": {
+ "edges": [
+ [
+ 32,
+ 8,
+ 10
+ ]
+ ],
+ "radius": 2
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/fillets/5181-two-distance-chamfer-runs-past-tapered-sides/expected.json b/tests/kernel-cases/fillets/5181-two-distance-chamfer-runs-past-tapered-sides/expected.json
index dde396198d..0550322981 100644
--- a/tests/kernel-cases/fillets/5181-two-distance-chamfer-runs-past-tapered-sides/expected.json
+++ b/tests/kernel-cases/fillets/5181-two-distance-chamfer-runs-past-tapered-sides/expected.json
@@ -2,7 +2,7 @@
"sources": [
"tangency-labs/solidcraft#5181"
],
- "what": "a 220 x 11 two-distance chamfer along the bottom edge of a 23 mm plate 100 wide whose sides run straight for 85 mm and then taper to 61.4 at 222.5: refused ('runs past the faces beside the edge into other geometry; the largest size that fits is 85 mm')",
+ "what": "a 220 x 11 two-distance chamfer along the bottom edge of a 23 mm plate 100 wide whose sides run straight for 85 mm and then taper to 61.4 at 222.5: it builds, the chamfer plane running on past the straight sides into the tapered ones, which it trims",
"source": "analytic",
"method": "the plate (profile 100x85 + the trapezoid to 61.351 at 222.5) x 23. The first face is the big face (it faces up most: horizontal, the bottom faces down): 220 up it, 11 into the bottom face. The chamfer plane cuts the wedge 11 (1 - z/220) deep across the full width w(z) (100, then tapering past z = 85): Int_0^220 w(z) 11 (1 - z/220) dz, the tapered sides simply trimmed",
"body_count": 1,
diff --git a/tests/kernel-cases/fillets/896-fillet-edge-tangent-at-one-end-into-cylinder/expected.json b/tests/kernel-cases/fillets/896-fillet-edge-tangent-at-one-end-into-cylinder/expected.json
new file mode 100644
index 0000000000..8bea0d555d
--- /dev/null
+++ b/tests/kernel-cases/fillets/896-fillet-edge-tangent-at-one-end-into-cylinder/expected.json
@@ -0,0 +1,10 @@
+{
+ "sources": [
+ "tangency-labs/solidcraft#896",
+ "tangency-labs/solidcraft#1207"
+ ],
+ "what": "after the round of a bar's top edge running into a cylinder, an r2 round of the edge where that round meets the cylinder's wall (tangent at its lower end only, a crease elsewhere) with its tangent chain (the concave arc of the top): it was refused as a smooth edge",
+ "source": "invariants",
+ "method": "a bar 40 x 16 x 10 whose far end is a half disc R8 about (40, 8), a disc R8 about the same centre sketched on its top (the top's outline projected) and extruded 10 up, joined: the bar's sides run tangent into the cylinder, V0 = 6400 + 960 pi; then the front round (the r2 round of the front top edge (y = 0, z = 10) runs into the cylinder's wall: removed = integral over y in [0, 2] of (2 - sqrt(4 - (2 - y)^2)) (40 - sqrt(64 - (8 - y)^2)) dy = 32.3064821881 (Simpson)); the second round fades to nothing at the edge's tangent end, no closed form: one valid body, adding material (concave), so V > V0 - removed = 9383.622465 and below V0",
+ "body_count": 1
+}
diff --git a/tests/kernel-cases/fillets/896-fillet-edge-tangent-at-one-end-into-cylinder/recipe.json b/tests/kernel-cases/fillets/896-fillet-edge-tangent-at-one-end-into-cylinder/recipe.json
new file mode 100644
index 0000000000..342a18ef3d
--- /dev/null
+++ b/tests/kernel-cases/fillets/896-fillet-edge-tangent-at-one-end-into-cylinder/recipe.json
@@ -0,0 +1,182 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": "XY",
+ "name": "Peg"
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0,
+ 0
+ ],
+ [
+ 40,
+ 0
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.arc.center_point",
+ "params": {
+ "center": [
+ 40,
+ 8
+ ],
+ "start": [
+ 40,
+ 0
+ ],
+ "end": [
+ 40,
+ 16
+ ]
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 40,
+ 16
+ ],
+ [
+ 0,
+ 16
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0,
+ 16
+ ],
+ [
+ 0,
+ 0
+ ]
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "solid.extrude",
+ "params": {
+ "sketch": "Peg",
+ "distance": 10,
+ "body_name": "Peg"
+ }
+ },
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 10
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Top"
+ }
+ },
+ {
+ "command": "sketch.project",
+ "params": {
+ "refs": [
+ {
+ "face": [
+ 2,
+ 8,
+ 10
+ ]
+ }
+ ]
+ }
+ },
+ {
+ "command": "sketch.circle.center",
+ "params": {
+ "center": [
+ 40,
+ 8
+ ],
+ "radius": 8
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "solid.extrude",
+ "params": {
+ "sketch": "Top",
+ "distance": 10,
+ "operation": "join",
+ "targets": [
+ "Peg"
+ ],
+ "profiles": [
+ {
+ "point": [
+ 40,
+ 8
+ ]
+ }
+ ],
+ "exact_regions": true
+ }
+ },
+ {
+ "command": "solid.fillet",
+ "params": {
+ "edges": [
+ [
+ 20,
+ 0,
+ 10
+ ]
+ ],
+ "radius": 2
+ }
+ },
+ {
+ "command": "solid.fillet",
+ "params": {
+ "edges": [
+ [
+ 37.2641,
+ 0.4827,
+ 9.3025
+ ]
+ ],
+ "radius": 2
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/fillets/KNOWN_FAILING b/tests/kernel-cases/fillets/KNOWN_FAILING
index dadf33eb4f..6b72712655 100644
--- a/tests/kernel-cases/fillets/KNOWN_FAILING
+++ b/tests/kernel-cases/fillets/KNOWN_FAILING
@@ -15,13 +15,14 @@
1080-fillet-sloped-basin-1-mm-rim-r4-4-edges not supported yet: a convex round past its face is not yet built by subtraction
1113-chamfer-arc-top-edge-full-wall-height-refused builds the chamfer as tall as the wall where it should be refused as too large
1207-fillet-bar-top-edge-after-boss-arc-round-r0-5 SMLib's check refuses the round: internal coincident control points in a B-spline curve (an internal pole)
+1207-fillet-concave-arc-bar-top-into-cylinder-solver-residues SMLib status 1001: SmFilletNx1Corner cannot make the topology at the arc's end (fillet error 3, corner type 8)
+1207-fillet-corner-after-round-running-into-cylinder-solver-residues SMLib's check refuses the round: its corner's surface of revolution is close to singular at its boundary (SmSurface test 5)
1668-fillet-outer-top-edge-of-thin-wall-r7-past-inside-corner a slit along the hollow, 0.507 mm^3 off: 38458.389 is V0 less the round's whole section along 104, so the section's part over the hollow (0.005068 mm^2 along 100), which is not material, is taken anyway
190-fillet-disc-rim-past-its-2mm-wall SMLib status 1001: a convex round past its face is not yet built by subtraction
2852-fillet-outer-round-r30-past-inner-round-refused refused for another reason: SMLib's result is not a closed solid, not too large naming 25.24
2893-chamfer-distance-and-angle-past-the-wall-refused refused for another reason: SMLib SM_ERR_INVALID_INPUT, not a check saying the angle runs past the wall
2893-chamfer-two-distances-elliptical-rim SMLib status 1001 on the elliptical rim's chamfer
2893-chamfer-two-distances-past-the-bottom-refused refused for another reason: SMLib status 1001, not too large
-1207-fillet-corner-after-round-running-into-cylinder-solver-residues SMLib's check refuses the round: its corner's surface of revolution is close to singular at its boundary (SmSurface test 5)
4782-fillet-bar-edge-wider-than-both-faces SMLib status 1001: a convex round past both its faces is not yet built by subtraction
5158-fillet-round-just-past-a-10mm-face SMLib status 1001: a convex round 0.01 past its face is not yet built by subtraction (10.0001-10.04 open)
5835-chamfer-sloped-basin-1-mm-rim-0-5-4-edges SMLib status 1001 on the chamfers meeting at the rim's re-entrant corners
@@ -33,6 +34,7 @@
851-chamfer-knife-edge-tip-2-box-less-cylinder SMLib SM_ERR_INVALID_INPUT on the knife edge (opposite normals on its two faces)
851-chamfer-knife-edge-tip-2-sketched SMLib SM_ERR_INVALID_INPUT on the knife edge (opposite normals on its two faces)
851-chamfer-knife-edge-tip-5 SMLib SM_ERR_INVALID_INPUT on the knife edge (opposite normals on its two faces)
+896-fillet-edge-tangent-at-one-end-into-cylinder SMLib's check refuses the round that fades out at the edge's tangent end: internal poles, coincident control points, cusps
9-fillet-corner-curvature-with-reduce-fit not supported yet: solid.fillet builds corner g2 with the exact fit only
9-fillet-corner-curvature-with-taper-fit not supported yet: solid.fillet builds corner g2 with the exact fit only
926-chamfer-top-edge-ending-on-boss-wall-above-it not supported yet: the chamfer is refused as larger than its faces where it ends on the boss's wall