Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

Wave 389/509: Kernel rig: one results check, each {step, pointer?, json, rel?, abs_mm?} (and 3 more)

jyviko2b2229ab31eb
diff --git a/crates/doc/src/eval_thread.rs b/crates/doc/src/eval_thread.rs
index 0ceaf87339..b4427be8c5 100644
--- a/crates/doc/src/eval_thread.rs
+++ b/crates/doc/src/eval_thread.rs
@@ -461,21 +461,44 @@ fn thread_grooves(
format!("this {shown} mm shaft is too thin for a modelled {m} thread: {cut}; make the shaft {} mm for {m}{alt}", show_mm(d))
}));
}
- // The section's radial span: from the root out past the surface (external), or from inside
- // the hole wall out to the root (internal), so the cut leaves no skin.
+ // The section: from the root out past the surface (external), or from inside the hole wall
+ // out to the root (internal), so the cut leaves no skin, its flanks the groove's.
// A taper thread's crests are cut by its major cone (external) or minor cone (internal),
- // as the die or tap cuts them ([`taper_envelope`]): its groove reaches just past the crest,
- // by as much as narrows the tooth's crest flat by a quarter (NPT's flat is 0.038 P).
- let past = |g: &crate::thread_forms::GrooveProfile| 0.25 * g.crest_flat / (g.flank_lo.tan() + g.flank_hi.tan());
- let span = |g: &crate::thread_forms::GrooveProfile| match (taper.is_some(), t.internal) {
- (true, true) => (g.crest_r - past(g), g.root_r),
- (true, false) => (g.root_r, g.crest_r + past(g)),
- (false, true) => (radius.min(g.crest_r) - 0.1 * p, g.root_r),
- (false, false) => (g.root_r, radius.max(d / 2.0) + 0.05 * p),
+ // as the die or tap cuts them ([`taper_envelope`]): its groove reaches past the crest by as
+ // much as narrows the tooth's crest flat by a quarter (NPT's flat is 0.038 P). The cone
+ // changes 1 in 32 along the axis (`major_at`) across the section's own width, so its edge
+ // there follows the cone at that margin rather than being cut square: square, its deeper
+ // corner stops short of the cone and leaves a sliver of each flank.
+ let cone = taper.map_or(0.0, |_| (major_at(t.start + 1.0) - major_at(t.start)) / 2.0);
+ let section_of = |g: &crate::thread_forms::GrooveProfile| -> (Vec<Vec2>, f64) {
+ let (tl, th) = (g.flank_lo.tan(), g.flank_hi.tan());
+ if taper.is_none() {
+ let (r0, r1) = if t.internal {
+ (radius.min(g.crest_r) - 0.1 * p, g.root_r)
+ } else {
+ (g.root_r, radius.max(d / 2.0) + 0.05 * p)
+ };
+ let ((lo0, hi0), (lo1, hi1)) = (g.extents(p, r0), g.extents(p, r1));
+ let wide = g.width(p, if t.internal { r0 } else { r1 });
+ return (vec![Vec2::new(r0, -lo0), Vec2::new(r1, -lo1), Vec2::new(r1, hi1), Vec2::new(r0, hi0)], wide);
+ }
+ // Depth from the root, out towards the crest: d(z) = dc + q·z along the edge, which
+ // meets the flanks z = −(h + d·tl) and z = h + d·th.
+ let o = if t.internal { -1.0 } else { 1.0 };
+ let q = o * cone;
+ let h = g.width(p, g.root_r) / 2.0;
+ let dc = o * (g.crest_r - g.root_r) + 0.25 * g.crest_flat / (tl + th);
+ let (z_lo, z_hi) = (-(h + dc * tl) / (1.0 + q * tl), (h + dc * th) / (1.0 - q * th));
+ let r = |z: f64| g.root_r + o * (dc + q * z);
+ let (root, edge) = ([Vec2::new(g.root_r, -h), Vec2::new(g.root_r, h)], [Vec2::new(r(z_lo), z_lo), Vec2::new(r(z_hi), z_hi)]);
+ // In the order the square section has: the inner radius's corners first.
+ let pts = if t.internal { vec![edge[0], root[0], root[1], edge[1]] } else { vec![root[0], edge[0], edge[1], root[1]] };
+ (pts, z_hi - z_lo)
};
- let (r0, r1) = span(&g);
- let wide = if t.internal { r0 } else { r1 };
- if g.width(p, wide) >= p * 0.98 {
+ let (mut section, wide) = section_of(&g);
+ let radii = |s: &[Vec2]| s.iter().fold((f64::INFINITY, f64::NEG_INFINITY), |(a, b), v| (a.min(v.x), b.max(v.x)));
+ let (r0, r1) = radii(&section);
+ if wide >= p * 0.98 {
// The groove would be wider than a pitch: the face is far inside the thread (a hole
// narrower than its minor diameter, a shaft thicker than its major one, #2688).
let (m, dia) = (&t.designation, 2.0 * radius);
@@ -488,9 +511,6 @@ fn thread_grooves(
format!("this {shown} mm shaft is too thick for a modelled {m} thread; make the shaft {} mm for {m}{alt}", show_mm(d))
}));
}
- let (lo0, hi0) = g.extents(p, r0);
- let (lo1, hi1) = g.extents(p, r1);
- let mut section = vec![Vec2::new(r0, -lo0), Vec2::new(r1, -lo1), Vec2::new(r1, hi1), Vec2::new(r0, hi0)];
if !(r0.is_finite() && r1.is_finite() && r0 > 0.0) {
return Err(DocError::Invalid("thread dimensions are out of range".into()));
}
@@ -503,7 +523,8 @@ fn thread_grooves(
// the material (an external thread's away from the axis, past the surface; an internal
// one's towards it, into the hole) as it turns. It lies past the full-form length, up to the
// shoulder's clearance; at a free end, inside the face, the groove reaching nothing there.
- let (w_lo, w_hi) = (lo0.max(lo1), hi0.max(hi1));
+ // How far the section reaches each way along the axis.
+ let (w_lo, w_hi) = section.iter().fold((0.0_f64, 0.0_f64), |(a, b), v| (a.max(-v.y), b.max(v.y)));
let s0 = match (ends[0], ease[0] > 0.0) {
(End::Free, false) => t.start - p,
(End::Free, true) => t.start,
@@ -528,11 +549,8 @@ fn thread_grooves(
let mut r0 = r0;
let taper_rate = match taper {
Some(_) => {
- let gb = profile(major_at(s0));
- let (a, b) = span(&gb);
- let ((l0, h0), (l1, h1)) = (gb.extents(p, a), gb.extents(p, b));
- section = vec![Vec2::new(a, -l0), Vec2::new(b, -l1), Vec2::new(b, h1), Vec2::new(a, h0)];
- r0 = a;
+ section = section_of(&profile(major_at(s0))).0;
+ r0 = radii(&section).0;
(major_at(s0 + lead) - major_at(s0)) / 2.0
}
None => 0.0,
diff --git a/tests/kernel-cases/EXEMPT b/tests/kernel-cases/EXEMPT
index 5bd7ed2b39..8dcef87010 100644
--- a/tests/kernel-cases/EXEMPT
+++ b/tests/kernel-cases/EXEMPT
@@ -39,7 +39,6 @@ component.rename a component name
component.replace_with_link component links
component.unlock component locking
component.update_links component links
-contact.list a listing of contact sets
diagnostics.crash_report crash reports
diagnostics.crash_reports crash reports
diagnostics.crash_reports.clear crash reports
@@ -59,10 +58,8 @@ edit.restore_checkpoint undo, redo and checkpoints: an earlier state r
edit.undo undo, redo and checkpoints: an earlier state restored, no new geometry
engine.commands the command registry itself
engine.describe the command registry itself
-explode.create exploded views: display offsets
explode.delete exploded views: display offsets
explode.list exploded views: display offsets
-explode.show exploded views: display offsets
expr.evaluate expression evaluation
file.open_in_easyprint hands the file to another program
file.save saving the design
@@ -78,7 +75,6 @@ inspect.curvature_map display analysis: shading
inspect.environment_map display analysis: shading
inspect.silhouette display analysis: outline
inspect.zebra display analysis: shading
-joint.list a listing of joints
library.apply material and appearance libraries
library.export material and appearance libraries
library.inspect material and appearance libraries
@@ -97,8 +93,6 @@ motion.delete removes a motion study
motion.export writes a study's results to a file
motion.export_animation writes an animation
motion.list a listing of motion studies
-motion.play plays a study in the view
-occurrence.properties occurrence properties
parameters.comment parameter bookkeeping; a value change that rebuilds is parameters.change, which cases use
parameters.complete parameter bookkeeping; a value change that rebuilds is parameters.change, which cases use
parameters.delete parameter bookkeeping; a value change that rebuilds is parameters.change, which cases use
@@ -111,7 +105,6 @@ parameters.move parameter bookkeeping; a value change that reb
parameters.rename parameter bookkeeping; a value change that rebuilds is parameters.change, which cases use
parameters.users parameter bookkeeping; a value change that rebuilds is parameters.change, which cases use
parts.library a listing of the parts library
-plastic.rules a listing of plastic rules
render.aging.describe rendering: images, cameras, stages
render.backends rendering: images, cameras, stages
render.camera.fit rendering: images, cameras, stages
@@ -265,97 +258,17 @@ view.visual_style the view: camera, layout, display
# that a case uses), and a new geometry command gets a case, not a line here.
[to cover]
body.repair repair: the solid a refused or open part becomes
-component.copy_bodies assemblies: bodies copied into a component
-component.extract assemblies: bodies extracted to a design
-component.from_bodies assemblies: a component made from bodies
-component.insert_design assemblies: a design inserted
-component.move_bodies assemblies: bodies moved between components
component.move_sketches assemblies: sketches moved between components
-component.paste_new assemblies: a pasted new component
component.revert_position assemblies: a placement reverted
-config.activate configurations: a configured part rebuilt per row
-config.column configurations: a configured part rebuilt per row
-config.configure configurations: a configured part rebuilt per row
-config.preview configurations: a configured part rebuilt per row
-config.row configurations: a configured part rebuilt per row
-config.rule configurations: a configured part rebuilt per row
-config.rules configurations: a configured part rebuilt per row
-config.table configurations: a configured part rebuilt per row
-construct.axis.edge construction: the plane, axis or point exactly
-construct.axis.normal_to_face construction: the plane, axis or point exactly
-construct.axis.through_cylinder construction: the plane, axis or point exactly
-construct.axis.two_planes construction: the plane, axis or point exactly
-construct.plane.at_angle construction: the plane, axis or point exactly
-construct.plane.midplane construction: the plane, axis or point exactly
-construct.plane.perpendicular construction: the plane, axis or point exactly
-construct.plane.tangent construction: the plane, axis or point exactly
-construct.plane.three_points construction: the plane, axis or point exactly
-construct.plane.two_edges construction: the plane, axis or point exactly
-construct.point.along_path construction: the plane, axis or point exactly
-construct.point.center construction: the plane, axis or point exactly
-construct.point.edge_plane construction: the plane, axis or point exactly
-construct.point.three_planes construction: the plane, axis or point exactly
-construct.point.two_edges construction: the plane, axis or point exactly
-construct.point.vertex construction: the plane, axis or point exactly
-contact.check assemblies: contact sets and what they report
-contact.create assemblies: contact sets and what they report
-contact.disable_all assemblies: contact sets and what they report
-contact.edit assemblies: contact sets and what they report
-contact.enable_all assemblies: contact sets and what they report
-contact.enable_sets assemblies: contact sets and what they report
file.export_view_dxf drawings: the projection of the model a view DXF holds
-frame.member frames: member bodies
-frame.profile.insert frames: member bodies
-inspect.center_of_mass inspect: the number or curves it reports
-inspect.clearance inspect: the number or curves it reports
-inspect.compare inspect: the number or curves it reports
-inspect.continuity inspect: the number or curves it reports
-inspect.curvature_comb inspect: the number or curves it reports
inspect.draft inspect: the number or curves it reports
-inspect.interference inspect: the number or curves it reports
-inspect.isocurve inspect: the number or curves it reports
-inspect.minimum_radius inspect: the number or curves it reports
inspect.parameter_sweep inspect: results rebuilt over a parameter range
inspect.section inspect: the number or curves it reports
-joint.as_built assemblies: joint placements and values
-joint.cam assemblies: joint placements and values
-joint.create assemblies: joint placements and values
-joint.delete assemblies: joint placements and values
-joint.drive assemblies: joint placements and values
-joint.edit assemblies: joint placements and values
-joint.gear assemblies: joint placements and values
-joint.inspect assemblies: joint placements and values
-joint.limits assemblies: joint placements and values
-joint.motion_link assemblies: joint placements and values
-joint.origin assemblies: joint placements and values
-joint.rack_pinion assemblies: joint placements and values
-joint.reach assemblies: joint placements and values
-joint.rigid_group assemblies: joint placements and values
-joint.screw assemblies: joint placements and values
-joint.solve assemblies: joint placements and values
-joint.sweep assemblies: joint placements and values
-motion.interference assemblies: motion results
-motion.plot assemblies: motion results
-motion.study assemblies: motion results
-motion.trace assemblies: motion results
motion.trace.edit assemblies: motion results
motion.trace.keep assemblies: motion results
-occurrence.copy assemblies: an occurrence copied
-occurrence.drag assemblies: an occurrence dragged to a placement
-occurrence.reparent assemblies: an occurrence moved in the tree
parts.fastener standard parts: a fastener body
parts.insert standard parts: a part body
parts.resize standard parts: a part resized
-plastic.assign_rule plastic: the feature body
-plastic.boss plastic: the feature body
-plastic.lip plastic: the feature body
-plastic.manage_rules plastic: rules that rebuild the features using them
-plastic.rest plastic: the feature body
-sheet.export_bend_table sheet metal: the bend table of a flat pattern
-sheet.export_dxf sheet metal: the flat pattern as DXF
-sheet.hem sheet metal: the feature body
-sheet.path_flange sheet metal: the feature body
-sheet.perforate sheet metal: the feature body
sketch.arc3d sketch: a curve kind no case profiles yet
sketch.auto_project sketch from the model: curves the kernel computes from bodies
sketch.conic sketch: a curve kind no case profiles yet
@@ -364,36 +277,7 @@ sketch.include_3d sketch from the model: curves the kernel compu
sketch.intersect sketch from the model: curves the kernel computes from bodies
sketch.intersection_curve sketch from the model: curves the kernel computes from bodies
sketch.isoparametric_curve sketch from the model: curves the kernel computes from bodies
-sketch.project sketch from the model: curves the kernel computes from bodies
sketch.project_to_surface sketch from the model: curves the kernel computes from bodies
sketch.spline.control_point_5 sketch: a curve kind no case profiles yet
sketch.spline3d sketch: a curve kind no case profiles yet
sketch.spun_profile sketch from the model: curves the kernel computes from bodies
-solid.align solid modelling: the body it makes
-solid.boundary_fill solid modelling: the body it makes
-solid.bounding_solid solid modelling: the body it makes
-solid.cone solid modelling: the body it makes
-solid.pattern.path solid modelling: the body it makes
-solid.replace_face solid modelling: the body it makes
-solid.scale solid modelling: the body it makes
-solid.web solid modelling: the body it makes
-surface.blend surfaces: the surface body it makes
-surface.boundary surfaces: the surface body it makes
-surface.fair surfaces: the surface body it makes
-surface.match surfaces: the surface body it makes
-surface.offset surfaces: the surface body it makes
-surface.reverse_normal surfaces: the surface body it makes
-surface.ruled surfaces: the surface body it makes
-surface.unstitch surfaces: the surface body it makes
-surface.untrim surfaces: the surface body it makes
-timeline.compute_all timeline: the bodies after the rebuild
-timeline.delete timeline: the bodies after the rebuild
-timeline.edit timeline: the bodies after the rebuild
-timeline.group timeline: the bodies after the rebuild
-timeline.move_many timeline: the bodies after the rebuild
-timeline.move_to_group timeline: the bodies after the rebuild
-timeline.reorder timeline: the bodies after the rebuild
-timeline.reorder_many timeline: the bodies after the rebuild
-timeline.roll_to timeline: the bodies after the rebuild
-timeline.suppress timeline: the bodies after the rebuild
-timeline.ungroup timeline: the bodies after the rebuild
diff --git a/tests/kernel-cases/README.md b/tests/kernel-cases/README.md
index 1c2209c6c3..9421d09f12 100644
--- a/tests/kernel-cases/README.md
+++ b/tests/kernel-cases/README.md
@@ -110,9 +110,8 @@ the frozen truck-geometry PRs, a `kernel-paused` PR), for the report's coverage
| `timeout_s` | A longer timeout for this case than the run's (at most 1800 s), for cases that are slow by nature. A case that only needs it on a loaded machine shouldn't set it. |
| `tolerance` | Optional overrides: `rel`, `abs_mm`, `mesh_mm`, `weld_mm`. |
| `files` | The files the case wrote to `$OUT`, each `{path, json \| csv \| dxf}`, matched as a part of what is there: every key the case gives, an array item by item and as long, a whole number exactly, any other number within `rel`. `json`: the file's JSON; `csv`: its rows, as objects keyed by the header row; `dxf`: per layer of its ENTITIES section, how many of each entity (`{"CUT": {"CIRCLE": 1, "ELLIPSE": 0, "length_mm": 31.416}}`; a count may be a range `[min, max]`) and `length_mm`, the total length of its lines, arcs, circles, ellipses and polylines. |
-| `results` | The commands' own answers, each `{step, json}`: the answer of the `step`th command (from 1) matched as `files` matches JSON (a flat pattern's bends, a rule's values). |
+| `results` | The commands' own answers, each `{step, pointer?, json, rel?, abs_mm?}`: the answer of the `step`th command (from 1, base commands included), or its part at the JSON `pointer` (RFC 6901), matched as `files` matches JSON: a whole number exactly (a count), another within `rel` (the case's relative tolerance unless given) or `abs_mm`, lists item by item. |
| `construction` | `{name: spec}`, a spec being `{point: [x,y,z]}`, `{axis: {through, dir}}` or `{plane: {through, normal}}`: each named construction point, axis or plane as the timeline evaluated it. A point within the position tolerance (`tolerance.abs_mm`, else 1e-3 of the box diagonal, of 1 mm where there is no body); an axis whose direction is parallel to `dir` (either way, sine of the angle at most 1e-6) and whose line passes within it of `through`; a plane likewise with `normal`. An axis or plane is graded as the line or plane it is, not by the origin it keeps. |
-| `results` | `[{command, pointer, value, rel?, abs_mm?}]`: values in the commands' own replies (an inspect command's numbers). The reply of the script's `command`-th command (from 0, base commands included), at the JSON `pointer`, is `value`: a number within the relative tolerance, `[x, y, z]` within the position tolerance, anything else (a string, a bool, null, a list) equal. |
| `missing` | A capability SolidCraft has no command or parameter for yet (`"solid.thread has no start count"`): the case is reported **not supported yet** without running, so the gap stays visible. |
## The kernel rig gate
diff --git a/tests/kernel-cases/construction/PATHS b/tests/kernel-cases/construction/PATHS
index cf02657258..e90299883a 100644
--- a/tests/kernel-cases/construction/PATHS
+++ b/tests/kernel-cases/construction/PATHS
@@ -1,7 +1,6 @@
# Source files whose change must rerun the construction area: one git pathspec glob a line.
# The construct.* commands (the plane at an angle and offset plane live in features.rs).
crates/engine/src/cmd/construct.rs
-crates/engine/src/cmd/features.rs
# How a construction reference resolves, and the planes the document resolves.
crates/doc/src/construct.rs
crates/doc/src/document.rs
diff --git a/tests/kernel-cases/frames/PATHS b/tests/kernel-cases/frames/PATHS
index f09de15ae3..affabd44fa 100644
--- a/tests/kernel-cases/frames/PATHS
+++ b/tests/kernel-cases/frames/PATHS
@@ -1,9 +1,6 @@
# Source files whose change must rerun the frames area (frame members, inserted profiles).
-apps/solidcraft-cli/src/kernel_cases.rs
crates/doc/src/eval_frame.rs
crates/doc/src/frame.rs
crates/engine/src/cmd/frame.rs
crates/engine/src/cmd/sketch.rs
-crates/kernel/src/**
-crates/smlib/**
tests/kernel-cases/frames/**
diff --git a/tests/kernel-cases/history/PATHS b/tests/kernel-cases/history/PATHS
index 786e62457a..bdaac7f4c0 100644
--- a/tests/kernel-cases/history/PATHS
+++ b/tests/kernel-cases/history/PATHS
@@ -11,7 +11,5 @@ crates/doc/src/config_rules.rs
crates/doc/src/params.rs
crates/doc/src/expr.rs
# Rebuilding the timeline, and the results it keeps between rebuilds.
-crates/doc/src/eval.rs
-crates/doc/src/model_cache.rs
# The cases themselves.
tests/kernel-cases/history/**
diff --git a/tests/kernel-cases/inspect/PATHS b/tests/kernel-cases/inspect/PATHS
index faec9db6b0..855eccb8ba 100644
--- a/tests/kernel-cases/inspect/PATHS
+++ b/tests/kernel-cases/inspect/PATHS
@@ -10,11 +10,8 @@ crates/engine/src/cmd/compare.rs
crates/engine/src/cmd/inspect.rs
# What they measure with: the comparison of two surfaces, a face's isocurves, seam continuity,
# body distance and mass properties.
-crates/geom/src/compare.rs
-crates/doc/src/eval.rs
crates/kernel/src/iso.rs
crates/kernel/src/continuity.rs
crates/kernel/src/continuity_order.rs
crates/kernel/src/distance.rs
-crates/kernel/src/measure.rs
tests/kernel-cases/inspect/**
diff --git a/tests/kernel-cases/inspect/cov-center-of-mass-box-and-cylinder/expected.json b/tests/kernel-cases/inspect/cov-center-of-mass-box-and-cylinder/expected.json
index ba0e92e090..c20f419e4b 100644
--- a/tests/kernel-cases/inspect/cov-center-of-mass-box-and-cylinder/expected.json
+++ b/tests/kernel-cases/inspect/cov-center-of-mass-box-and-cylinder/expected.json
@@ -5,32 +5,32 @@
"method": "box 40 x 30 x 20 with a corner at the origin (V 24000 at (20,15,10)) and a cylinder r 5, h 10 on (60,0,0) (V 250 pi = 785.40 at (60,0,5)): the volume-weighted mean (21.2675, 14.5247, 9.8416), V = 24000 + 250 pi",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/center",
- "value": [
+ "json": [
21.267517524987444,
14.524680928129708,
9.84156030937657
]
},
{
- "command": 2,
+ "step": 3,
"pointer": "/volume",
- "value": 24785.398163397447
+ "json": 24785.398163397447
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/1/center",
- "value": [
+ "json": [
60,
0,
5
]
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/1/volume",
- "value": 785.3981633974482
+ "json": 785.3981633974482
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-center-of-mass-box/expected.json b/tests/kernel-cases/inspect/cov-center-of-mass-box/expected.json
index a40b16dd73..b6d0289938 100644
--- a/tests/kernel-cases/inspect/cov-center-of-mass-box/expected.json
+++ b/tests/kernel-cases/inspect/cov-center-of-mass-box/expected.json
@@ -5,18 +5,18 @@
"method": "box 40 x 30 x 20 with a corner at the origin: the middle (20,15,10), V = 40 x 30 x 20 = 24000",
"results": [
{
- "command": 1,
+ "step": 2,
"pointer": "/center",
- "value": [
+ "json": [
20,
15,
10
]
},
{
- "command": 1,
+ "step": 2,
"pointer": "/volume",
- "value": 24000.0
+ "json": 24000.0
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-clearance-gap-between-two-spheres/expected.json b/tests/kernel-cases/inspect/cov-clearance-gap-between-two-spheres/expected.json
index af414d55bf..108cd41fb4 100644
--- a/tests/kernel-cases/inspect/cov-clearance-gap-between-two-spheres/expected.json
+++ b/tests/kernel-cases/inspect/cov-clearance-gap-between-two-spheres/expected.json
@@ -5,38 +5,38 @@
"method": "spheres r 5 on (0,0,0) and (20,0,0): 20 - 5 - 5 = 10 apart, from (5,0,0) to (15,0,0)",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/overlaps",
- "value": []
+ "json": []
},
{
- "command": 2,
+ "step": 3,
"pointer": "/near/0/a",
- "value": "A"
+ "json": "A"
},
{
- "command": 2,
+ "step": 3,
"pointer": "/near/0/b",
- "value": "B"
+ "json": "B"
},
{
- "command": 2,
+ "step": 3,
"pointer": "/near/0/distance_mm",
- "value": 10.0
+ "json": 10.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/near/0/from",
- "value": [
+ "json": [
5,
0,
0
]
},
{
- "command": 2,
+ "step": 3,
"pointer": "/near/0/to",
- "value": [
+ "json": [
15,
0,
0
diff --git a/tests/kernel-cases/inspect/cov-clearance-overlapping-spheres/expected.json b/tests/kernel-cases/inspect/cov-clearance-overlapping-spheres/expected.json
index 07c05664d2..16f8a2a5e6 100644
--- a/tests/kernel-cases/inspect/cov-clearance-overlapping-spheres/expected.json
+++ b/tests/kernel-cases/inspect/cov-clearance-overlapping-spheres/expected.json
@@ -5,14 +5,14 @@
"method": "spheres r 5 on (0,0,0) and (8,0,0): the lens pi (4r + d)(2r - d)^2 / 12 = pi 28 4 / 12 = 29.3215, centred on (4,0,0)",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/overlaps/0/volume_mm3",
- "value": 29.321531433504735
+ "json": 29.321531433504735
},
{
- "command": 2,
+ "step": 3,
"pointer": "/overlaps/0/center",
- "value": [
+ "json": [
4,
0,
0
diff --git a/tests/kernel-cases/inspect/cov-clearance-spheres-farther-than-the-clearance/expected.json b/tests/kernel-cases/inspect/cov-clearance-spheres-farther-than-the-clearance/expected.json
index 8f4b8e3afa..71e960ac59 100644
--- a/tests/kernel-cases/inspect/cov-clearance-spheres-farther-than-the-clearance/expected.json
+++ b/tests/kernel-cases/inspect/cov-clearance-spheres-farther-than-the-clearance/expected.json
@@ -5,14 +5,14 @@
"method": "spheres r 5 on (0,0,0) and (20,0,0) are 10 apart; closer than 5 asked: none",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/overlaps",
- "value": []
+ "json": []
},
{
- "command": 2,
+ "step": 3,
"pointer": "/near",
- "value": []
+ "json": []
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-compare-identical-boxes/expected.json b/tests/kernel-cases/inspect/cov-compare-identical-boxes/expected.json
index e1d52a15b7..39a7ac3015 100644
--- a/tests/kernel-cases/inspect/cov-compare-identical-boxes/expected.json
+++ b/tests/kernel-cases/inspect/cov-compare-identical-boxes/expected.json
@@ -5,19 +5,19 @@
"method": "boxes 40 x 30 x 20 on the same corner: identical, no region, B - A = 0",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/identical",
- "value": true
+ "json": true
},
{
- "command": 2,
+ "step": 3,
"pointer": "/regions",
- "value": []
+ "json": []
},
{
- "command": 2,
+ "step": 3,
"pointer": "/difference/volume_mm3",
- "value": 0.0
+ "json": 0.0
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-compare-taller-box/expected.json b/tests/kernel-cases/inspect/cov-compare-taller-box/expected.json
index fb9f6b54ad..016be182f9 100644
--- a/tests/kernel-cases/inspect/cov-compare-taller-box/expected.json
+++ b/tests/kernel-cases/inspect/cov-compare-taller-box/expected.json
@@ -5,49 +5,49 @@
"method": "box A 40 x 30 x 20 and B 40 x 30 x 25 on the same corner: B - A is the slab z 20..25, V 6000, only in B, at most 5 from A",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/a/volume_mm3",
- "value": 24000.0
+ "json": 24000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/b/volume_mm3",
- "value": 30000.0
+ "json": 30000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/difference/volume_mm3",
- "value": 6000.0
+ "json": 6000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/identical",
- "value": false
+ "json": false
},
{
- "command": 2,
+ "step": 3,
"pointer": "/regions/0/side",
- "value": "only_in_b"
+ "json": "only_in_b"
},
{
- "command": 2,
+ "step": 3,
"pointer": "/regions/0/volume_mm3",
- "value": 6000.0
+ "json": 6000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/only_in_b/volume_mm3",
- "value": 6000.0
+ "json": 6000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/only_in_a/volume_mm3",
- "value": 0.0
+ "json": 0.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/deviation/max_mm",
- "value": 5.0
+ "json": 5.0
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-continuity-box-edge-is-sharp/expected.json b/tests/kernel-cases/inspect/cov-continuity-box-edge-is-sharp/expected.json
index 1468968e94..4b9ac2aa85 100644
--- a/tests/kernel-cases/inspect/cov-continuity-box-edge-is-sharp/expected.json
+++ b/tests/kernel-cases/inspect/cov-continuity-box-edge-is-sharp/expected.json
@@ -5,29 +5,29 @@
"method": "box 40 x 30 x 20 with a corner at the origin: the faces y = 0 and z = 0 meet at 90 deg along their edge: g0, sharp, normal angle 90",
"results": [
{
- "command": 1,
+ "step": 2,
"pointer": "/summary/edges",
- "value": 1
+ "json": 1
},
{
- "command": 1,
+ "step": 2,
"pointer": "/bodies/0/edges/0/order",
- "value": "g0"
+ "json": "g0"
},
{
- "command": 1,
+ "step": 2,
"pointer": "/bodies/0/edges/0/verdict",
- "value": "sharp"
+ "json": "sharp"
},
{
- "command": 1,
+ "step": 2,
"pointer": "/bodies/0/edges/0/normal_angle_deg/value",
- "value": 90.0
+ "json": 90.0
},
{
- "command": 1,
+ "step": 2,
"pointer": "/bodies/0/edges/0/gap_mm/value",
- "value": 0.0,
+ "json": 0.0,
"rel": 1e-06
}
]
diff --git a/tests/kernel-cases/inspect/cov-continuity-fillet-seams-are-g1/expected.json b/tests/kernel-cases/inspect/cov-continuity-fillet-seams-are-g1/expected.json
index 9a93b77dcd..a0a667f5fd 100644
--- a/tests/kernel-cases/inspect/cov-continuity-fillet-seams-are-g1/expected.json
+++ b/tests/kernel-cases/inspect/cov-continuity-fillet-seams-are-g1/expected.json
@@ -5,39 +5,39 @@
"method": "box 40 x 30 x 20 with a corner at the origin, its top-front edge (y 0, z 20) rounded r 3: the round meets the top (at y 3) and the front (at z 17) tangent, curvature jumping 0 to 1/3: g1, jump 1/3 per mm",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/summary/edges",
- "value": 2
+ "json": 2
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/0/edges/0/order",
- "value": "g1"
+ "json": "g1"
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/0/edges/1/order",
- "value": "g1"
+ "json": "g1"
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/0/edges/0/curvature_jump_per_mm/value",
- "value": 0.3333333333333333
+ "json": 0.3333333333333333
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/0/edges/1/curvature_jump_per_mm/value",
- "value": 0.3333333333333333
+ "json": 0.3333333333333333
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/0/edges/0/verdict",
- "value": "curvature_jump"
+ "json": "curvature_jump"
},
{
- "command": 2,
+ "step": 3,
"pointer": "/bodies/0/edges/1/verdict",
- "value": "curvature_jump"
+ "json": "curvature_jump"
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-curvature-comb-circle-and-line/expected.json b/tests/kernel-cases/inspect/cov-curvature-comb-circle-and-line/expected.json
index 285efa83e1..e41a902e26 100644
--- a/tests/kernel-cases/inspect/cov-curvature-comb-circle-and-line/expected.json
+++ b/tests/kernel-cases/inspect/cov-curvature-comb-circle-and-line/expected.json
@@ -5,24 +5,24 @@
"method": "circle r 7: curvature 1/7 everywhere, radius 7; a line: straight, no radius",
"results": [
{
- "command": 4,
+ "step": 5,
"pointer": "/combs/0/min_radius",
- "value": 7.0
+ "json": 7.0
},
{
- "command": 4,
+ "step": 5,
"pointer": "/combs/0/max_curvature",
- "value": 0.14285714285714285
+ "json": 0.14285714285714285
},
{
- "command": 4,
+ "step": 5,
"pointer": "/combs/1/min_radius",
- "value": null
+ "json": null
},
{
- "command": 4,
+ "step": 5,
"pointer": "/combs/1/max_curvature",
- "value": 0.0
+ "json": 0.0
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-curvature-comb-cylinder-edge/expected.json b/tests/kernel-cases/inspect/cov-curvature-comb-cylinder-edge/expected.json
index 2af9c42d82..ed69c9e019 100644
--- a/tests/kernel-cases/inspect/cov-curvature-comb-cylinder-edge/expected.json
+++ b/tests/kernel-cases/inspect/cov-curvature-comb-cylinder-edge/expected.json
@@ -5,14 +5,14 @@
"method": "a cylinder r 5 on (60,0,0): its top edge is a circle of r 5, curvature 1/5",
"results": [
{
- "command": 1,
+ "step": 2,
"pointer": "/combs/0/min_radius",
- "value": 5.0
+ "json": 5.0
},
{
- "command": 1,
+ "step": 2,
"pointer": "/combs/0/max_curvature",
- "value": 0.2
+ "json": 0.2
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-interference-box-inside-a-box/expected.json b/tests/kernel-cases/inspect/cov-interference-box-inside-a-box/expected.json
index c56e1ed3e7..3c1afa071e 100644
--- a/tests/kernel-cases/inspect/cov-interference-box-inside-a-box/expected.json
+++ b/tests/kernel-cases/inspect/cov-interference-box-inside-a-box/expected.json
@@ -5,19 +5,19 @@
"method": "box 40 x 30 x 20 with a corner at the origin and a box 10 x 10 x 10 from (5,5,5) inside it: the overlap is the small box: V 1000, centre (10,10,10)",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/count",
- "value": 1
+ "json": 1
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/volume_mm3",
- "value": 1000.0
+ "json": 1000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/center",
- "value": [
+ "json": [
10,
10,
10
diff --git a/tests/kernel-cases/inspect/cov-interference-boxes-touching-face-to-face/expected.json b/tests/kernel-cases/inspect/cov-interference-boxes-touching-face-to-face/expected.json
index 07812ac632..abe4ac5ea5 100644
--- a/tests/kernel-cases/inspect/cov-interference-boxes-touching-face-to-face/expected.json
+++ b/tests/kernel-cases/inspect/cov-interference-boxes-touching-face-to-face/expected.json
@@ -5,14 +5,14 @@
"method": "box 40 x 30 x 20 with a corner at the origin and a box 40 x 30 x 20 from (40,0,0): they share the face x = 40 and no volume: no interference",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/count",
- "value": 0
+ "json": 0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences",
- "value": []
+ "json": []
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-interference-overlapping-boxes/expected.json b/tests/kernel-cases/inspect/cov-interference-overlapping-boxes/expected.json
index f76118d01d..1feba5a2ba 100644
--- a/tests/kernel-cases/inspect/cov-interference-overlapping-boxes/expected.json
+++ b/tests/kernel-cases/inspect/cov-interference-overlapping-boxes/expected.json
@@ -5,42 +5,42 @@
"method": "box 40 x 30 x 20 with a corner at the origin and a box 40 x 30 x 20 from (30,20,10): they share the cube x 30..40, y 20..30, z 10..20: V 1000, A 600, centre (35,25,15)",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/count",
- "value": 1
+ "json": 1
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/volume_mm3",
- "value": 1000.0
+ "json": 1000.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/area_mm2",
- "value": 600.0
+ "json": 600.0
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/center",
- "value": [
+ "json": [
35,
25,
15
]
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/bbox/min",
- "value": [
+ "json": [
30,
20,
10
]
},
{
- "command": 2,
+ "step": 3,
"pointer": "/interferences/0/bbox/max",
- "value": [
+ "json": [
40,
30,
20
diff --git a/tests/kernel-cases/inspect/cov-isocurve-cube-top/expected.json b/tests/kernel-cases/inspect/cov-isocurve-cube-top/expected.json
index 04b6119aa9..46ccc59d75 100644
--- a/tests/kernel-cases/inspect/cov-isocurve-cube-top/expected.json
+++ b/tests/kernel-cases/inspect/cov-isocurve-cube-top/expected.json
@@ -5,24 +5,24 @@
"method": "cube 40 with a corner at the origin: its top is the plane z = 40, 0..40 each way; 3 curves each way, evenly spaced, are x = 10, 20, 30 and y = 10, 20, 30: 3 u-curves and 3 v-curves",
"results": [
{
- "command": 1,
+ "step": 2,
"pointer": "/faces/0/body",
- "value": "Cube"
+ "json": "Cube"
},
{
- "command": 1,
+ "step": 2,
"pointer": "/faces/0/count",
- "value": 3
+ "json": 3
},
{
- "command": 1,
+ "step": 2,
"pointer": "/faces/0/u_curves",
- "value": 3
+ "json": 3
},
{
- "command": 1,
+ "step": 2,
"pointer": "/faces/0/v_curves",
- "value": 3
+ "json": 3
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-minimum-radius-of-a-box-is-none/expected.json b/tests/kernel-cases/inspect/cov-minimum-radius-of-a-box-is-none/expected.json
index 36d5b98c4f..0e459a0c8f 100644
--- a/tests/kernel-cases/inspect/cov-minimum-radius-of-a-box-is-none/expected.json
+++ b/tests/kernel-cases/inspect/cov-minimum-radius-of-a-box-is-none/expected.json
@@ -5,9 +5,9 @@
"method": "box 40 x 30 x 20 with a corner at the origin: every face is flat: no radius (null)",
"results": [
{
- "command": 1,
+ "step": 2,
"pointer": "/min_radius",
- "value": null
+ "json": null
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-minimum-radius-of-a-circular-edge/expected.json b/tests/kernel-cases/inspect/cov-minimum-radius-of-a-circular-edge/expected.json
index c3f5fc8efc..72740f9a10 100644
--- a/tests/kernel-cases/inspect/cov-minimum-radius-of-a-circular-edge/expected.json
+++ b/tests/kernel-cases/inspect/cov-minimum-radius-of-a-circular-edge/expected.json
@@ -5,9 +5,9 @@
"method": "a cylinder r 5 on (60,0,0): its top edge is a circle of r 5",
"results": [
{
- "command": 1,
+ "step": 2,
"pointer": "/min_radius",
- "value": 5.0
+ "json": 5.0
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-minimum-radius-of-a-fillet/expected.json b/tests/kernel-cases/inspect/cov-minimum-radius-of-a-fillet/expected.json
index 72f5a82088..f58d68f9e8 100644
--- a/tests/kernel-cases/inspect/cov-minimum-radius-of-a-fillet/expected.json
+++ b/tests/kernel-cases/inspect/cov-minimum-radius-of-a-fillet/expected.json
@@ -5,9 +5,9 @@
"method": "box 40 x 30 x 20 with a corner at the origin, its top-front edge (y 0, z 20) rounded r 3: the flat faces have none, the round is a cylinder of r 3: the smallest radius is 3",
"results": [
{
- "command": 2,
+ "step": 3,
"pointer": "/min_radius",
- "value": 3.0
+ "json": 3.0
}
]
}
diff --git a/tests/kernel-cases/inspect/cov-minimum-radius-of-an-ellipse/expected.json b/tests/kernel-cases/inspect/cov-minimum-radius-of-an-ellipse/expected.json
index 3c8dd17bfe..c7cbe1043f 100644
--- a/tests/kernel-cases/inspect/cov-minimum-radius-of-an-ellipse/expected.json
+++ b/tests/kernel-cases/inspect/cov-minimum-radius-of-an-ellipse/expected.json
@@ -5,9 +5,9 @@
"method": "ellipse a 10, b 4: tightest at the ends of the major axis, b^2 / a = 1.6, at (+-10, 0)",
"results": [
{
- "command": 3,
+ "step": 4,
"pointer": "/min_radius",
- "value": 1.6
+ "json": 1.6
}
]
}
diff --git a/tests/kernel-cases/plastic/PATHS b/tests/kernel-cases/plastic/PATHS
index 47435b15c8..2f0a648494 100644
--- a/tests/kernel-cases/plastic/PATHS
+++ b/tests/kernel-cases/plastic/PATHS
@@ -4,17 +4,9 @@ crates/engine/src/cmd/plastic.rs
crates/doc/src/plastic.rs
# The features' evaluation (plastic_eval and its helpers) and the join and cut they apply.
crates/doc/src/eval_more.rs
-crates/doc/src/eval.rs
# The kernel operations they build with: extrude, tapered extrude, the lip's raised band and the
# groove's rim band, booleans (ops) and the shell the lip cases
# start from, and SMLib underneath.
-crates/kernel/src/build.rs
crates/kernel/src/lip.rs
-crates/kernel/src/ops.rs
-crates/kernel/src/boolean_record.rs
-crates/kernel/src/native.rs
-crates/kernel/src/shell_groups.rs
-crates/smlib/**
# The cases and the rig itself.
tests/kernel-cases/plastic/**
-apps/solidcraft-cli/src/kernel_cases.rs
diff --git a/tests/kernel-cases/sheet-metal/PATHS b/tests/kernel-cases/sheet-metal/PATHS
index 7bc3beaf43..99fd668cac 100644
--- a/tests/kernel-cases/sheet-metal/PATHS
+++ b/tests/kernel-cases/sheet-metal/PATHS
@@ -13,3 +13,5 @@ crates/engine/src/cmd/sheet.rs
crates/kernel/src/offset_backend.rs
crates/kernel/src/polyhedron.rs
crates/kernel/src/sew.rs
+crates/doc/src/eval_more.rs
+crates/io/src/dxf_out.rs
diff --git a/tests/kernel-cases/solids/PATHS b/tests/kernel-cases/solids/PATHS
index 7b538874c7..a7ec66f0e2 100644
--- a/tests/kernel-cases/solids/PATHS
+++ b/tests/kernel-cases/solids/PATHS
@@ -1,9 +1,4 @@
# Source files whose change must rerun the solids area (cones, scale, align, bounding solids).
-apps/solidcraft-cli/src/kernel_cases.rs
-crates/doc/src/eval.rs
crates/doc/src/eval_more.rs
-crates/engine/src/cmd/features.rs
crates/engine/src/cmd/features_more.rs
-crates/kernel/src/**
-crates/smlib/**
tests/kernel-cases/solids/**
diff --git a/tests/kernel-cases/surfaces/PATHS b/tests/kernel-cases/surfaces/PATHS
index c9f751bb6b..fc93ede835 100644
--- a/tests/kernel-cases/surfaces/PATHS
+++ b/tests/kernel-cases/surfaces/PATHS
@@ -6,7 +6,6 @@ crates/engine/src/cmd/surface_match.rs
crates/engine/src/params.rs
# Their evaluation.
crates/doc/src/eval_surface.rs
-crates/doc/src/eval.rs
# The kernel code they call.
crates/kernel/src/boundary.rs
crates/kernel/src/boundary_network.rs
@@ -15,7 +14,6 @@ crates/kernel/src/fair.rs
crates/kernel/src/fill*.rs
crates/kernel/src/loft*.rs
crates/kernel/src/matchsurf.rs
-crates/kernel/src/native.rs
crates/kernel/src/surface_extend.rs
crates/kernel/src/surface_offset.rs
crates/kernel/src/surface_ruled.rs
@@ -23,10 +21,5 @@ crates/kernel/src/surface_trim.rs
crates/kernel/src/surface_untrim.rs
crates/kernel/src/surfaces.rs
crates/kernel/src/sweep*.rs
-crates/kernel/src/smlib_sweeps.rs
-crates/geom/src/fill*.rs
-crates/geom/src/network*.rs
# SMLib and the rig itself.
-crates/smlib/**
-apps/solidcraft-cli/src/kernel_cases.rs
tests/kernel-cases/surfaces/**
diff --git a/tests/kernel-cases/surfaces/cov-extrude-line-symmetric-legacy-per-side/expected.json b/tests/kernel-cases/surfaces/cov-extrude-line-symmetric-legacy-per-side/expected.json
new file mode 100644
index 0000000000..a936fdfc5c
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-extrude-line-symmetric-legacy-per-side/expected.json
@@ -0,0 +1,26 @@
+{
+ "sources": [],
+ "what": "a line extruded symmetric 10 as a surface with the legacy per-side convention: 10 each way",
+ "source": "analytic",
+ "method": "convention legacy_per_side gives the distance on each side: the plane y = 0, x 0..10, z -10..10, area 200, 4 free edges",
+ "valid": false,
+ "body_count": 1,
+ "faces": 1,
+ "boundary_edges": 4,
+ "area_mm2": 200.0,
+ "surface_types": [
+ "plane"
+ ],
+ "bbox": {
+ "min": [
+ 0,
+ 0,
+ -10
+ ],
+ "max": [
+ 10,
+ 0,
+ 10
+ ]
+ }
+}
diff --git a/tests/kernel-cases/surfaces/cov-extrude-line-symmetric-legacy-per-side/recipe.json b/tests/kernel-cases/surfaces/cov-extrude-line-symmetric-legacy-per-side/recipe.json
new file mode 100644
index 0000000000..feefe2b84f
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-extrude-line-symmetric-legacy-per-side/recipe.json
@@ -0,0 +1,60 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "S"
+ }
+ },
+ {
+ "command": "sketch.line",
+ "params": {
+ "points": [
+ [
+ 0,
+ 0
+ ],
+ [
+ 10,
+ 0
+ ]
+ ],
+ "infer": false
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.extrude",
+ "params": {
+ "sketch": "S",
+ "curves": [
+ "l1"
+ ],
+ "distance": 10,
+ "direction": "symmetric",
+ "body_name": "Wall",
+ "convention": "legacy_per_side"
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/surfaces/cov-extrude-line-symmetric/expected.json b/tests/kernel-cases/surfaces/cov-extrude-line-symmetric/expected.json
index 4538a7ab6b..e70b66fe19 100644
--- a/tests/kernel-cases/surfaces/cov-extrude-line-symmetric/expected.json
+++ b/tests/kernel-cases/surfaces/cov-extrude-line-symmetric/expected.json
@@ -1,13 +1,13 @@
{
"sources": [],
- "what": "a line extruded symmetric 10 as a surface: surface.extrude's distance is per side (its legacy convention, kept by default), so 10 each way",
+ "what": "a line extruded symmetric 10 as a surface with no convention: the total, 5 each side of the sketch plane, as for a solid extrude (#9091)",
"source": "analytic",
- "method": "surface.extrude without `convention` keeps legacy_per_side (crates/engine/src/cmd/features.rs, extrude_convention_tests): the plane y = 0, x 0..10, z -10..10, area 200, 4 free edges",
+ "method": "surface.extrude without `convention` reads the distance as the total (default_extrude_convention): the plane y = 0, x 0..10, z -5..5, area 100, 4 free edges",
"valid": false,
"body_count": 1,
"faces": 1,
"boundary_edges": 4,
- "area_mm2": 200.0,
+ "area_mm2": 100.0,
"surface_types": [
"plane"
],
@@ -15,12 +15,12 @@
"min": [
0,
0,
- -10
+ -5
],
"max": [
10,
0,
- 10
+ 5
]
}
}