Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

test: three ignored tests pass again and run in CI (#679, #562) (#1663)

Philipp Bischoff3087363c4454
diff --git a/apps/solidcraft-cli/tests/action_matrix.rs b/apps/solidcraft-cli/tests/action_matrix.rs
index ac025a4413..35d82d9613 100644
--- a/apps/solidcraft-cli/tests/action_matrix.rs
+++ b/apps/solidcraft-cli/tests/action_matrix.rs
@@ -1519,7 +1519,6 @@ fn sketches_on_loft_and_sweep_faces() {
}
#[test]
-#[ignore = "fails until #562 is fixed"]
fn press_pull_on_the_pi_case_floor() {
reproduces(
Some("tests/action_matrix/designs/pi-case.solidcraft"),
diff --git a/crates/engine/src/cmd/lineage_face_tests.rs b/crates/engine/src/cmd/lineage_face_tests.rs
index 6eac284ea2..70224f98d5 100644
--- a/crates/engine/src/cmd/lineage_face_tests.rs
+++ b/crates/engine/src/cmd/lineage_face_tests.rs
@@ -309,7 +309,6 @@ fn every_flat_face_of_a_block_and_a_flush_step_takes_a_sketch() {
/// #681 as reported: one sketch of a 2 x 2 grid, three cells extruded up (an elbow) and three
/// joined down (the inverse elbow).
#[test]
-#[ignore = "the join of the elbow down fails until #679 is fixed"]
fn every_flat_face_of_an_elbow_up_and_an_elbow_down_takes_a_sketch() {
let mut s = Session::default();
run(&mut s, "sketch.create", json!({"plane": "XY", "name": "Grid"}));
diff --git a/crates/kernel/src/curvecorner_tests.rs b/crates/kernel/src/curvecorner_tests.rs
index 7773a2b9ff..3153d107ce 100644
--- a/crates/kernel/src/curvecorner_tests.rs
+++ b/crates/kernel/src/curvecorner_tests.rs
@@ -244,10 +244,9 @@ fn a_round_ending_in_an_earlier_round_matches_both_together() {
}
}
-/// The back edge rounded first, then the arc's top edge: the arc's round leaves 0.05 mm³ more at
-/// the knife-edge tip than both together, or the other order.
+/// The back edge rounded first, then the arc's top edge: the same solid as both together, or the
+/// other order (the arc's round once left 0.05 mm³ more at the knife-edge tip).
#[test]
-#[ignore = "not yet: the arc's round after the back edge's leaves 0.05 mm³ more at the tip"]
fn the_arc_rounded_after_the_back_edge_matches_both_together() {
one_then_the_other(BACK, arc_top());
}