Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

Merge pull request #124 from CypherNaught-0x/fix/shell-four-face-corner

bherbruck420ee723eec6
diff --cc ROADMAP.md
index d71f17063d,f40f324753..8df8b640de
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@@ -100,97 -95,15 +100,98 @@@ headline counts in-scope tabs only and
- Persistent naming (plan/adr/0002) names faces from their history and edges by their faces;
references resolve by name first and warn when the entity split or vanished. Kernel-reported
face history (exact through coincident surfaces) is not wired in yet.
+ New planar sketch attachments use exact box, extrusion cap/side and immutable imported-face
+ source certificates with checked target and author occurrence paths. A missing or changed
+ source fails explicitly; Redefine Sketch Plane previews reattachment or a fixed plane while
+ retaining current geometry and dimension identities. Unsupported modified faces need an
+ explicit fixed plane. Legacy attachments retain their original resolver behavior.
- Modelled threads are cut as a faceted body (curved faces within 1/200 of the pitch); Extrude
and Revolve To Object on a curved face cut the tool back to the target's surface.
-- Free-form curves cut at a tangent touch (no clean crossing) enter that profile as polylines.
+- Explicit sketch breaks preserve exact ellipses, fit/control splines (including high degrees)
+ and conics; analytic trim/break also sees free-form cutters. Free-form curves cut at a tangent
+ touch (no clean crossing) enter that profile as polylines.
Sweeps along 3D sketch curves follow their polyline (smooth walls when the path is smooth).
+- Extend intersects exact ellipses and rational/high-degree splines without moving the line or
+ circular support. Associative free-form offsets have a whole-span 0.002 mm normal-distance
+ certificate and refine within bounded node limits while retaining existing IDs. Singular,
+ self-intersecting and ambiguous curves refuse atomically; mixed junctions and nonsmooth
+ closed natural-spline seams remain limitations. New explicitly closed fit splines and closed
+ offset outputs use periodic C2 interpolation, supporting repeated certified offsets; older
+ natural splines are preserved. Clicking the starting fit point deliberately closes a new loop.
+ Projected analytic boundaries follow nested loop identities through resizing, including
+ stationary holes and rounded corners. An inset that consumes a corner arc still reports
+ a collapse error; changing the associated output topology remains unfinished.
+- Extrude and Revolve editors retain original direction, extent expressions, explicit targets,
+ axes, From/To inputs and All-profile intent. No-op edits preserve downstream dimension names
+ and selected occurrence frames; cancel and successful edits preserve one-step undo history.
+ Placed feature edits preview through the edited timeline entry, and cylindrical Emboss guides
+ use the sketch's actual target, author or uniquely placed third-component frame.
+ Revolve rotators follow the actual signed axis and support symmetric and two-sided extents;
+ dragging a To Object extent converts its derived value to an explicit angle. Legacy reversed-axis
+ symmetric geometry is preserved through format 11's explicit legacy convention. New revolves
+ use the sketch-normal direction for each selected profile, including To Object and curved
+ target trimming, independently of the selected axis sign.
+- Cylindrical emboss/deboss wraps bounded orthogonal line profiles, including holes, concave
+ outlines and nested islands, onto complete exterior cylinders or coaxial sleeves with exact
+ radial walls. New features infer a unique eligible cylinder when the face field is empty;
+ ambiguous targets require an explicit face. Saved target
+ and author occurrence paths retain the chosen placements; missing/split faces refuse rather
+ than retarget. General free-form profiles, seams, stepped cylinders and other curved surfaces
+ remain unsupported. STEP round-trip and independent radial/volume checks cover this subset.
- Shell and offset faces work on bodies of planes, cylinders, cones and spheres (convex or not:
- filleted boxes, bosses, domes, countersinks); draft on convex planar bodies and on walls (planes, cylinders → cones) between caps; lofts through three or more sections are smooth (B-spline sides through every section), two
+ filleted boxes, bosses, domes, countersinks; corners where four or more planes meet, such as a
+ floor falling to a drain, as long as the corner's edges are all convex or all concave); draft on convex planar bodies and on walls (planes, cylinders → cones) between caps; lofts through three or more sections are smooth (B-spline sides through every section), two
sections ruled.
+- Sketch corner tools: fillet and all three chamfer modes pick a connected corner even when
+ its endpoint overlaps the fixed origin or a loose point. Ordinary drawing still snaps to
+ the origin; clicked UI regressions verify geometry, closed profiles and undo.
+- Face projection: closed boundaries have a deterministic outer-first order. Refresh matches
+ existing geometry before assigning positions, retaining saved curve IDs and constraints
+ across enumeration changes and resize, including concentric circles. Ambiguous identities
+ retain the last geometry and report a lost reference; permutation matching is bounded.
+- Inline sketch dimensions: Tab and Shift+Tab cycle within the active shape's value boxes,
+ selecting visited values for replacement. Expression completion retains forward-Tab
+ priority; real keyboard regressions cover rectangles, lines and single-value circles.
+ Typed lengths, radii, line angles, signed arc sweeps and slot lengths persist as constraints
+ and expressions through save/reopen. Shape creation and its dimensions form one undo step;
+ rejected values keep the editable field focused.
+- Repeated components: Browser selection, visibility, properties, copy and Move/Copy use
+ checked occurrence paths. Active nested occurrences author planar sketches and solids in
+ their selected frame. Pending moves compose through parents; dialog cancellation restores
+ its selected move. Source materials and body/face appearances follow transformed instances.
+ Shared nested definitions remain shared. Deep Paste New copies reachable definition graphs,
+ independent feature/input histories, styles and internal motion records, with bounded geometry
+ checks and explicit external-link notices. Paste New selects the copy while preserving the active
+ authoring context. Imported periodic STEP seams survive placement and reexport with shared
+ topology and appearances intact. Recorded body transfers preserve historical Join/Cut membership,
+ material, placements and machining data through edits, copying, undo and reopen. New 3D wires
+ record their coordinate frame; legacy wires migrate from known provenance without changing
+ coordinates. Broken legacy links with missing provenance can require explicit refresh or relink.
+ See [occurrence workflows](docs/occurrence-workflows.md).
+- Configuration rules: ordered typed conditions can drive parameters and suppressions or
+ restrict values. Preview explains effective values without modifying the document; applying
+ rules validates rows atomically. Length expressions retain their authoring units across
+ document-unit changes. The UI supports structured All/Any/Not conditions and rule ordering.
+ Component styles and certified semantic face styles are available; unsupported lineage refuses
+ atomically, and stale certified face paint cannot jump to another surface. See [configurations](docs/configurations.md).
+- Sheet-metal material: inherited holes, crossing edge notches, overlapping cuts and retained
+ islands share the same boundaries in flat preview, DXF and unfolded solids. Detached material
+ pieces survive unfold/refold as one logical sheet group, including split flanged sheets.
+ Circular cuts crossing bends remain unsupported; free-form bases use bounded sampling.
+ Parallel prismatic partial-depth cuts retain pocket side and depth through transfer and
+ unfold/refold, with separate pocket contours in preview and DXF. Planar Intersect preserves
+ exact holes and retained islands, including the union of multiple selected profiles. Unsupported
+ tapered or bend-crossing machining refuses atomically instead of restoring material later.
+- Rolling-ball fillet accuracy: independent offset-cylinder tee references check surface
+ distance, actual trimmed tessellation, supporting-cylinder contacts and tangency at two
+ scales. The measured trimmed-part error is below 0.0001 mm; this is an analytic geometry
+ check, not a new Fusion oracle result. Under-resolved fits return an error.
+- Contact driving checks the trajectory between clear endpoints, including linked joints,
+ playback and sparse motion exports. Checks use bounded tessellation samples, not exact
+ continuous collision detection; local thin walls and small details remain limitations.
+ See [contact-set limits and recovery](docs/contact-sets.md).
+
## Kernel
truck (Apache-2.0) behind our own `kernel` crate, with our own blend operation and boolean