Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

STEP conformance sweep: the cones to a point read right now (#258) (#3901)

bherbruck438abbcf827d
diff --git a/ATTRIBUTION.md b/ATTRIBUTION.md
index aee34d11d8..90a7decfa9 100644
--- a/ATTRIBUTION.md
+++ b/ATTRIBUTION.md
@@ -57,6 +57,8 @@ Editable drawing code, native projects and shipped exports are collected under `
| docs/book/src/generated/tool-preview.png | SolidCraft contributors | rendered by `cargo xtask book` (`solidcraft-cli snapshot docs/book/scripts/tool-preview.json`; gitignored) | MIT OR Apache-2.0 |
| assets/fonts/liberation-sans/LiberationSans-Regular.ttf | Red Hat, Inc. (Liberation Fonts 2.x; digitized data Google) | https://github.com/liberationfonts (Debian fonts-liberation), unmodified; licence text in assets/fonts/liberation-sans/OFL.txt; used for sketch Text outlines | SIL OFL 1.1 |
| assets/fonts/biz-udp-gothic/BIZUDPGothic-Regular.ttf | The BIZ UDGothic Project Authors | https://github.com/googlefonts/morisawa-biz-ud-gothic (Google Fonts), unmodified; licence text in assets/fonts/biz-udp-gothic/OFL.txt; used for web UI Japanese font | SIL OFL 1.1 |
+| tests/step-conformance/cone_point.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
+| tests/step-conformance/cone_point_vertex.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
| tests/step-conformance/cylinder.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
| tests/step-conformance/cylinder_inch.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
| tests/step-conformance/cylinder_nurbs.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
diff --git a/crates/kernel/src/step_in/tests.rs b/crates/kernel/src/step_in/tests.rs
index 65bbb7e01a..34aa60be78 100644
--- a/crates/kernel/src/step_in/tests.rs
+++ b/crates/kernel/src/step_in/tests.rs
@@ -1775,13 +1775,14 @@ fn extruded_ellipse_patch_crossing_profile_seam_stays_trimmed() {
/// from formulas by https://github.com/dan335/step-conformance at 96f30bb, CC0 1.0):
/// each reads back with its exact volume (from the generator's own profile), its box and its
/// face count. Left out: `torus_ring` (meshes below its equator, a meshing issue for the
-/// tessellation work), `cone_point` and `cone_point_vertex` (#258, #3871) and the
-/// 1.4 MB `plate_900_holes`.
+/// tessellation work) and the 1.4 MB `plate_900_holes`.
#[test]
fn step_conformance_parts_read_back_their_exact_shape() {
// (file, exact volume (mm³), box (min, max), kernel faces, bodies)
#[rustfmt::skip]
- let parts: [(&str, &str, f64, [f64; 6], usize, usize); 15] = [
+ let parts: [(&str, &str, f64, [f64; 6], usize, usize); 17] = [
+ ("cone_point", include_str!("../../../../tests/step-conformance/cone_point.step"), 1000.0 * std::f64::consts::PI, [-10.0, -10.0, 0.0, 10.0, 10.0, 30.0], 2, 1),
+ ("cone_point_vertex", include_str!("../../../../tests/step-conformance/cone_point_vertex.step"), 1000.0 * std::f64::consts::PI, [-10.0, -10.0, 0.0, 10.0, 10.0, 30.0], 2, 1),
("cylinder", include_str!("../../../../tests/step-conformance/cylinder.step"), 9424.778, [-10.0, -10.0, 0.0, 10.0, 10.0, 30.0], 3, 1),
("cylinder_inch", include_str!("../../../../tests/step-conformance/cylinder_inch.step"), 9424.778, [-10.0, -10.0, 0.0, 10.0, 10.0, 30.0], 3, 1),
("cylinder_nurbs", include_str!("../../../../tests/step-conformance/cylinder_nurbs.step"), 9424.778, [-10.0, -10.0, 0.0, 10.0, 10.0, 30.0], 3, 1),
diff --git a/tests/step-conformance/cone_point.step b/tests/step-conformance/cone_point.step
new file mode 100644
index 0000000000..4be1def483
--- /dev/null
+++ b/tests/step-conformance/cone_point.step
@@ -0,0 +1,56 @@
+ISO-10303-21;
+HEADER;
+FILE_DESCRIPTION(('step-conformance generated part'),'2;1');
+FILE_NAME('cone_point.step','2026-10-12T00:00:00',(''),(''),'step-conformance generate','step-conformance generate','');
+FILE_SCHEMA(('AUTOMOTIVE_DESIGN { 1 0 10303 214 1 1 1 1 }'));
+ENDSEC;
+DATA;
+#1=( LENGTH_UNIT() NAMED_UNIT(*) SI_UNIT(.MILLI.,.METRE.) );
+#2=( NAMED_UNIT(*) PLANE_ANGLE_UNIT() SI_UNIT($,.RADIAN.) );
+#3=( NAMED_UNIT(*) SI_UNIT($,.STERADIAN.) SOLID_ANGLE_UNIT() );
+#4=UNCERTAINTY_MEASURE_WITH_UNIT(LENGTH_MEASURE(1.E-7),#1,'distance_accuracy_value','confusion accuracy');
+#5=( GEOMETRIC_REPRESENTATION_CONTEXT(3) GLOBAL_UNCERTAINTY_ASSIGNED_CONTEXT((#4)) GLOBAL_UNIT_ASSIGNED_CONTEXT((#1,#2,#3)) REPRESENTATION_CONTEXT('','3D') );
+#6=APPLICATION_CONTEXT('automotive design');
+#7=APPLICATION_PROTOCOL_DEFINITION('international standard','automotive_design',2000,#6);
+#8=PRODUCT_CONTEXT('',#6,'mechanical');
+#9=PRODUCT_DEFINITION_CONTEXT('part definition',#6,'design');
+#10=PRODUCT('cone_point','cone_point','',(#8));
+#11=PRODUCT_DEFINITION_FORMATION('','',#10);
+#12=PRODUCT_DEFINITION('design','',#11,#9);
+#13=PRODUCT_DEFINITION_SHAPE('','',#12);
+#14=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#15=DIRECTION('',(0.0,0.0,1.0));
+#16=DIRECTION('',(1.0,0.0,0.0));
+#17=AXIS2_PLACEMENT_3D('',#14,#15,#16);
+#18=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#19=DIRECTION('',(0.0,0.0,1.0));
+#20=DIRECTION('',(1.0,0.0,0.0));
+#21=AXIS2_PLACEMENT_3D('',#18,#19,#20);
+#22=CIRCLE('',#21,10.0);
+#23=CARTESIAN_POINT('',(10.0,0.0,0.0));
+#24=VERTEX_POINT('',#23);
+#25=EDGE_CURVE('',#24,#24,#22,.T.);
+#26=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#27=DIRECTION('',(0.0,0.0,1.0));
+#28=DIRECTION('',(1.0,0.0,0.0));
+#29=AXIS2_PLACEMENT_3D('',#26,#27,#28);
+#30=PLANE('',#29);
+#31=ORIENTED_EDGE('',*,*,#25,.F.);
+#32=EDGE_LOOP('',(#31));
+#33=FACE_OUTER_BOUND('',#32,.T.);
+#34=ADVANCED_FACE('',(#33),#30,.F.);
+#35=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#36=DIRECTION('',(0.0,0.0,-1.0));
+#37=DIRECTION('',(1.0,0.0,0.0));
+#38=AXIS2_PLACEMENT_3D('',#35,#36,#37);
+#39=CONICAL_SURFACE('',#38,10.0,0.3217505543966422);
+#40=ORIENTED_EDGE('',*,*,#25,.T.);
+#41=EDGE_LOOP('',(#40));
+#42=FACE_OUTER_BOUND('',#41,.T.);
+#43=ADVANCED_FACE('',(#42),#39,.T.);
+#44=CLOSED_SHELL('',(#34,#43));
+#45=MANIFOLD_SOLID_BREP('',#44);
+#46=ADVANCED_BREP_SHAPE_REPRESENTATION('',(#17,#45),#5);
+#47=SHAPE_DEFINITION_REPRESENTATION(#13,#46);
+ENDSEC;
+END-ISO-10303-21;
diff --git a/tests/step-conformance/cone_point_vertex.step b/tests/step-conformance/cone_point_vertex.step
new file mode 100644
index 0000000000..a0a44ffa2f
--- /dev/null
+++ b/tests/step-conformance/cone_point_vertex.step
@@ -0,0 +1,60 @@
+ISO-10303-21;
+HEADER;
+FILE_DESCRIPTION(('step-conformance generated part'),'2;1');
+FILE_NAME('cone_point_vertex.step','2026-10-12T00:00:00',(''),(''),'step-conformance generate','step-conformance generate','');
+FILE_SCHEMA(('AUTOMOTIVE_DESIGN { 1 0 10303 214 1 1 1 1 }'));
+ENDSEC;
+DATA;
+#1=( LENGTH_UNIT() NAMED_UNIT(*) SI_UNIT(.MILLI.,.METRE.) );
+#2=( NAMED_UNIT(*) PLANE_ANGLE_UNIT() SI_UNIT($,.RADIAN.) );
+#3=( NAMED_UNIT(*) SI_UNIT($,.STERADIAN.) SOLID_ANGLE_UNIT() );
+#4=UNCERTAINTY_MEASURE_WITH_UNIT(LENGTH_MEASURE(1.E-7),#1,'distance_accuracy_value','confusion accuracy');
+#5=( GEOMETRIC_REPRESENTATION_CONTEXT(3) GLOBAL_UNCERTAINTY_ASSIGNED_CONTEXT((#4)) GLOBAL_UNIT_ASSIGNED_CONTEXT((#1,#2,#3)) REPRESENTATION_CONTEXT('','3D') );
+#6=APPLICATION_CONTEXT('automotive design');
+#7=APPLICATION_PROTOCOL_DEFINITION('international standard','automotive_design',2000,#6);
+#8=PRODUCT_CONTEXT('',#6,'mechanical');
+#9=PRODUCT_DEFINITION_CONTEXT('part definition',#6,'design');
+#10=PRODUCT('cone_point_vertex','cone_point_vertex','',(#8));
+#11=PRODUCT_DEFINITION_FORMATION('','',#10);
+#12=PRODUCT_DEFINITION('design','',#11,#9);
+#13=PRODUCT_DEFINITION_SHAPE('','',#12);
+#14=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#15=DIRECTION('',(0.0,0.0,1.0));
+#16=DIRECTION('',(1.0,0.0,0.0));
+#17=AXIS2_PLACEMENT_3D('',#14,#15,#16);
+#18=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#19=DIRECTION('',(0.0,0.0,1.0));
+#20=DIRECTION('',(1.0,0.0,0.0));
+#21=AXIS2_PLACEMENT_3D('',#18,#19,#20);
+#22=CIRCLE('',#21,10.0);
+#23=CARTESIAN_POINT('',(10.0,0.0,0.0));
+#24=VERTEX_POINT('',#23);
+#25=EDGE_CURVE('',#24,#24,#22,.T.);
+#26=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#27=DIRECTION('',(0.0,0.0,1.0));
+#28=DIRECTION('',(1.0,0.0,0.0));
+#29=AXIS2_PLACEMENT_3D('',#26,#27,#28);
+#30=PLANE('',#29);
+#31=ORIENTED_EDGE('',*,*,#25,.F.);
+#32=EDGE_LOOP('',(#31));
+#33=FACE_OUTER_BOUND('',#32,.T.);
+#34=ADVANCED_FACE('',(#33),#30,.F.);
+#35=CARTESIAN_POINT('',(0.0,0.0,0.0));
+#36=DIRECTION('',(0.0,0.0,-1.0));
+#37=DIRECTION('',(1.0,0.0,0.0));
+#38=AXIS2_PLACEMENT_3D('',#35,#36,#37);
+#39=CONICAL_SURFACE('',#38,10.0,0.3217505543966422);
+#40=ORIENTED_EDGE('',*,*,#25,.T.);
+#41=EDGE_LOOP('',(#40));
+#42=CARTESIAN_POINT('',(0.0,0.0,30.0));
+#43=VERTEX_POINT('',#42);
+#44=VERTEX_LOOP('',#43);
+#45=FACE_OUTER_BOUND('',#41,.T.);
+#46=FACE_BOUND('',#44,.T.);
+#47=ADVANCED_FACE('',(#45,#46),#39,.T.);
+#48=CLOSED_SHELL('',(#34,#47));
+#49=MANIFOLD_SOLID_BREP('',#48);
+#50=ADVANCED_BREP_SHAPE_REPRESENTATION('',(#17,#49),#5);
+#51=SHAPE_DEFINITION_REPRESENTATION(#13,#50);
+ENDSEC;
+END-ISO-10303-21;