Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

smlib: a volume's accuracy is clamped to 1e-8..1e-1, as mass_properties clamps it

jyvikod2882754faff
diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs
index a004039437..bdba1de15e 100644
--- a/crates/smlib/src/core.rs
+++ b/crates/smlib/src/core.rs
@@ -533,11 +533,10 @@ pub(crate) fn make_torus(center: [f64; 3], major_radius: f64, minor_radius: f64)
run("create_torus", |k| primitives::create_torus(k, o, major_radius, minor_radius)).map(Body::new)
}
-/// The enclosed volume (`SmApiBrepComputeVolume`).
+/// The enclosed volume (`SmApiBrepComputeVolume`), its accuracy clamped as [`mass_properties`]
+/// clamps it.
pub(crate) fn volume(body: &Body, relative_accuracy: f64) -> Result<f64> {
- if !relative_accuracy.is_finite() {
- return Err(Error::Argument);
- }
+ let relative_accuracy = measure::accuracy(relative_accuracy)?;
with_body("brep_volume", body, |k, b| {
let store = AttributeStore::default();
let attrs = PropertyAttributes { store: &store, key_of: &|_| ObjectKey(0) };
diff --git a/crates/smlib/src/core/measure.rs b/crates/smlib/src/core/measure.rs
index ffeb034d63..012c23d1a9 100644
--- a/crates/smlib/src/core/measure.rs
+++ b/crates/smlib/src/core/measure.rs
@@ -30,7 +30,7 @@ use crate::{Error, Result};
const OP: &str = "smlib_measure";
/// The accuracy the C API passes on: finite, clamped to [1e-8, 1e-1].
-fn accuracy(relative_accuracy: f64) -> Result<f64> {
+pub(super) fn accuracy(relative_accuracy: f64) -> Result<f64> {
if !relative_accuracy.is_finite() {
return Err(Error::Argument);
}