Skip to content

SolidCraft: an open-source parametric 3D CAD application built in pure Rust. Desktop, web, and automation through MCP.

Wave 368/509: Kernel rig: thicken a sheet into a slab and a tube, trim by a plane and by a circle, and refuse a stray keep_with (and 3 more)

jyvikof6f2f0bc38b8
diff --git a/apps/solidcraft-cli/src/kernel_cases.rs b/apps/solidcraft-cli/src/kernel_cases.rs
index 2b6921b883..5632947596 100644
--- a/apps/solidcraft-cli/src/kernel_cases.rs
+++ b/apps/solidcraft-cli/src/kernel_cases.rs
@@ -262,13 +262,13 @@ fn continuity_order(
/// matching, an array element by element and as long, a whole number exactly, any other number
/// within `rel` of it (relative, at least 1 absolute), anything else equal. `None` where it
/// matches; else the path to the first difference with both values.
-fn json_mismatch(got: &Value, want: &Value, rel: f64, path: &str) -> Option<String> {
+fn json_mismatch(got: &Value, want: &Value, rel: f64, abs: f64, path: &str) -> Option<String> {
let differ = || Some(format!("{path}: got {got}, want {want}"));
match (got, want) {
(_, Value::Object(w)) => {
let Value::Object(g) = got else { return differ() };
w.iter().find_map(|(k, wv)| match g.get(k) {
- Some(gv) => json_mismatch(gv, wv, rel, &format!("{path}.{k}")),
+ Some(gv) => json_mismatch(gv, wv, rel, abs, &format!("{path}.{k}")),
None => Some(format!("{path}.{k}: missing, want {wv}")),
})
}
@@ -277,12 +277,12 @@ fn json_mismatch(got: &Value, want: &Value, rel: f64, path: &str) -> Option<Stri
if g.len() != w.len() {
return Some(format!("{path}: {} items, want {}", g.len(), w.len()));
}
- g.iter().zip(w).enumerate().find_map(|(i, (gv, wv))| json_mismatch(gv, wv, rel, &format!("{path}[{i}]")))
+ g.iter().zip(w).enumerate().find_map(|(i, (gv, wv))| json_mismatch(gv, wv, rel, abs, &format!("{path}[{i}]")))
}
(_, Value::Number(w)) if w.is_i64() || w.is_u64() => (got.as_f64() != w.as_f64()).then(differ).flatten(),
(_, Value::Number(w)) => {
let (g, w) = (got.as_f64(), w.as_f64().unwrap_or(f64::NAN));
- (!g.is_some_and(|g| g.is_finite() && (g - w).abs() <= rel * w.abs().max(1.0))).then(differ).flatten()
+ (!g.is_some_and(|g| g.is_finite() && (g - w).abs() <= (rel * w.abs().max(1.0)).max(abs))).then(differ).flatten()
}
_ => (got != want).then(differ).flatten(),
}
@@ -387,7 +387,9 @@ fn dxf_layers(text: &str) -> Value {
/// read and matched as [`json_mismatch`] does: `json` against the file's JSON, `csv` against its
/// rows ([`csv_rows`]), `dxf` against its layers ([`dxf_layers`]), a count there exact or an
/// inclusive range `[min, max]`. And the `results` check of the commands' own answers: each
-/// `{step, json}`, the answer of the `step`th command (from 1) matched against `json`.
+/// `{step, pointer?, json, rel?, abs_mm?}`, the answer of the `step`th command (from 1, base
+/// commands included), or its part at the JSON `pointer` (RFC 6901), matched against `json`,
+/// a number within the entry's `rel` (or the case's) or its `abs_mm`.
fn output_checks(c: &mut Checks, want: &Value, out: &str, results: &[Value], rel: f64) {
for f in want["files"].as_array().into_iter().flatten() {
let path = f["path"].as_str().unwrap_or_default();
@@ -435,15 +437,18 @@ fn output_checks(c: &mut Checks, want: &Value, out: &str, results: &[Value], rel
c.push(&what, json!(f), json!("json, csv or dxf"), false);
continue;
};
- let miss = json_mismatch(&got, &wanted, rel, "");
+ let miss = json_mismatch(&got, &wanted, rel, 0.0, "");
c.push(&what, json!(miss.clone().unwrap_or_else(|| "matches".into())), wanted, miss.is_none());
}
for r in want["results"].as_array().into_iter().flatten() {
let step = r["step"].as_u64().unwrap_or(0);
- let what = format!("result of step {step}");
+ let pointer = r["pointer"].as_str().unwrap_or("");
+ let what = format!("result of step {step}{pointer}");
+ let (rel, abs) = (r["rel"].as_f64().unwrap_or(rel), r["abs_mm"].as_f64().unwrap_or(0.0));
let got = step.checked_sub(1).and_then(|i| results.get(i as usize));
- let miss = match got {
- Some(g) => json_mismatch(g, &r["json"], rel, ""),
+ let miss = match got.map(|g| g.pointer(pointer)) {
+ Some(Some(g)) => json_mismatch(g, &r["json"], rel, abs, ""),
+ Some(None) => Some(format!("no {pointer} in step {step}'s answer")),
None => Some(format!("no step {step} of {}", results.len())),
};
c.push(&what, json!(miss.clone().unwrap_or_else(|| "matches".into())), r["json"].clone(), miss.is_none());
@@ -514,6 +519,55 @@ fn splines_match(faces: &[[[u64; 2]; 2]], want: &Value) -> Result<(Value, bool),
Ok((json!(got), ok && left.is_empty()))
}
+/// Largest sine of the angle between a construction's direction (an axis's, a plane's normal)
+/// and the case's: either way along it.
+const CONSTRUCT_DIR_TOL: f64 = 1e-6;
+
+/// The `construction` check: each named construction plane, axis or point, as the timeline
+/// evaluated it, is the case's: a point within `tol` (mm); an axis whose direction is parallel to
+/// `dir` (either way) and whose line passes within `tol` of `through`; a plane whose normal is
+/// parallel to `normal` (either way) and which passes within `tol` of `through`. An axis or plane
+/// is graded as the line or plane it is, never by the origin it happens to keep.
+fn check_construction(s: &solidcraft_engine::Session, want: &Value, tol: f64, c: &mut Checks) {
+ use solidcraft_engine::geom::Vec3;
+ use solidcraft_engine::view::{construction_axes, construction_planes, construction_points};
+ let Some(named) = want.as_object() else {
+ c.push("construction", json!("`construction` must map names to {point} | {axis} | {plane}"), json!("an object"), false);
+ return;
+ };
+ let vec = |v: &Value| v3(v).map(Vec3::from);
+ let parallel = |a: Vec3, b: Vec3| a.normalized().zip(b.normalized()).is_some_and(|(a, b)| a.cross(b).len() <= CONSTRUCT_DIR_TOL);
+ for (name, w) in named {
+ let what = format!("construction {name}");
+ let (got, ok) = if let Some(p) = w.get("point").and_then(vec) {
+ match construction_points(s).into_iter().find(|x| &x.1 == name) {
+ Some((_, _, q)) => (json!({"point": q}), q.dist(p) <= tol),
+ None => (json!("no such construction point"), false),
+ }
+ } else if let Some((through, dir)) = w.get("axis").and_then(|a| vec(&a["through"]).zip(vec(&a["dir"]))) {
+ match construction_axes(s).into_iter().find(|x| &x.1 == name) {
+ Some((_, _, o, d)) => {
+ let off = d.normalized().map(|u| (through - o) - u * (through - o).dot(u)).map_or(f64::INFINITY, Vec3::len);
+ (json!({"axis": {"origin": o, "dir": d, "through_off_mm": off}}), parallel(d, dir) && off <= tol)
+ }
+ None => (json!("no such construction axis"), false),
+ }
+ } else if let Some((through, normal)) = w.get("plane").and_then(|p| vec(&p["through"]).zip(vec(&p["normal"]))) {
+ match construction_planes(s).into_iter().find(|x| &x.1 == name) {
+ Some((_, _, pl)) => {
+ let n = pl.normal();
+ let off = n.normalized().map_or(f64::INFINITY, |u| (through - pl.origin).dot(u).abs());
+ (json!({"plane": {"origin": pl.origin, "normal": n, "through_off_mm": off}}), parallel(n, normal) && off <= tol)
+ }
+ None => (json!("no such construction plane"), false),
+ }
+ } else {
+ (json!("give {point: [x,y,z]}, {axis: {through, dir}} or {plane: {through, normal}}"), false)
+ };
+ c.push(&what, got, w.clone(), ok);
+ }
+}
+
fn unsupported(e: &str) -> bool {
e.contains("not supported yet")
}
@@ -793,6 +847,11 @@ fn check_case(dir: &str, dumps: Option<&std::path::Path>) -> Value {
Err(e) => c.push("splines", json!(e), want["splines"].clone(), false),
}
}
+ // With no body and no `bbox` the diagonal is not finite: positions then take ABS_FRAC of 1 mm.
+ let pos_tol = if abs.is_finite() { abs } else { ABS_FRAC };
+ if has("construction") {
+ check_construction(&s, &want["construction"], pos_tol, &mut c);
+ }
out["status"] = json!(if c.pass { "pass" } else { "fail" });
out["checks"] = json!(c.list);
out
@@ -904,11 +963,11 @@ mod tests {
#[test]
fn json_parts_match_within_tolerance_and_whole_numbers_exactly() {
let got = json!({"bends": [{"angle_deg": 90.00001, "direction": "up", "count": 3}], "extra": 1});
- assert_eq!(json_mismatch(&got, &json!({"bends": [{"angle_deg": 90.0, "direction": "up"}]}), 1e-3, ""), None);
- assert!(json_mismatch(&got, &json!({"bends": [{"count": 4}]}), 1e-3, "").is_some_and(|m| m.contains(".bends[0].count")));
- assert!(json_mismatch(&got, &json!({"bends": []}), 1e-3, "").is_some_and(|m| m.contains("1 items, want 0")));
- assert!(json_mismatch(&got, &json!({"missing": 1}), 1e-3, "").is_some_and(|m| m.contains("missing")));
- assert!(json_mismatch(&got, &json!({"bends": [{"direction": "down"}]}), 1e-3, "").is_some());
+ assert_eq!(json_mismatch(&got, &json!({"bends": [{"angle_deg": 90.0, "direction": "up"}]}), 1e-3, 0.0, ""), None);
+ assert!(json_mismatch(&got, &json!({"bends": [{"count": 4}]}), 1e-3, 0.0, "").is_some_and(|m| m.contains(".bends[0].count")));
+ assert!(json_mismatch(&got, &json!({"bends": []}), 1e-3, 0.0, "").is_some_and(|m| m.contains("1 items, want 0")));
+ assert!(json_mismatch(&got, &json!({"missing": 1}), 1e-3, 0.0, "").is_some_and(|m| m.contains("missing")));
+ assert!(json_mismatch(&got, &json!({"bends": [{"direction": "down"}]}), 1e-3, 0.0, "").is_some());
}
#[test]
@@ -985,6 +1044,64 @@ mod tests {
let _ = std::fs::remove_dir_all(&out);
}
+ #[test]
+ fn construction_is_graded_as_the_point_line_or_plane_it_is() {
+ let mut s = solidcraft_engine::Session::default();
+ let script = json!({"commands": [
+ {"command": "construct.point.three_planes", "params": {"a": "XY", "b": "XZ", "c": "YZ", "name": "Pin"}},
+ {"command": "construct.axis.two_planes", "params": {"a": "XZ", "b": "YZ", "name": "Spine"}},
+ {"command": "construct.plane.offset", "params": {"base": "XY", "offset": "5 mm", "name": "Shelf"}},
+ ]});
+ s.run_script(&script).unwrap();
+ let grade = |want: Value| {
+ let mut c = Checks { list: Vec::new(), pass: true };
+ check_construction(&s, &want, 1e-3, &mut c);
+ c.pass
+ };
+ // An axis is its line, either way along it, through any point of it; a plane likewise.
+ assert!(grade(json!({
+ "Pin": {"point": [0, 0, 0]},
+ "Spine": {"axis": {"through": [0, 0, 40], "dir": [0, 0, -1]}},
+ "Shelf": {"plane": {"through": [7, -3, 5], "normal": [0, 0, 2]}},
+ })));
+ assert!(!grade(json!({"Pin": {"point": [0, 0, 0.01]}})));
+ assert!(!grade(json!({"Spine": {"axis": {"through": [0.01, 0, 0], "dir": [0, 0, 1]}}})));
+ assert!(!grade(json!({"Spine": {"axis": {"through": [0, 0, 0], "dir": [0, 0.01, 1]}}})));
+ assert!(!grade(json!({"Shelf": {"plane": {"through": [0, 0, 5.01], "normal": [0, 0, 1]}}})));
+ assert!(!grade(json!({"Shelf": {"plane": {"through": [0, 0, 5], "normal": [1, 0, 0]}}})));
+ // A name the timeline has not got, or of another kind, fails.
+ assert!(!grade(json!({"Pin": {"plane": {"through": [0, 0, 0], "normal": [0, 0, 1]}}})));
+ assert!(!grade(json!({"Nothing": {"point": [0, 0, 0]}})));
+ assert!(!grade(json!({"Pin": {"centre": [0, 0, 0]}})));
+ }
+
+ #[test]
+ fn results_are_read_from_each_commands_reply() {
+ let replies = [json!({"center": [1.0, 2.0, 3.0], "volume": 24000.0}), json!({"summary": {"worst": "g1"}, "count": 1})];
+ let grade = |results: Value| {
+ let mut c = Checks { list: Vec::new(), pass: true };
+ output_checks(&mut c, &json!({ "results": results }), "", &replies, 1e-3);
+ c.pass
+ };
+ assert!(grade(json!([
+ {"step": 1, "pointer": "/center", "json": [1.0, 2.0, 3.0]},
+ {"step": 1, "pointer": "/volume", "json": 24010.0},
+ {"step": 2, "pointer": "/summary/worst", "json": "g1"},
+ {"step": 2, "json": {"count": 1}},
+ ])));
+ assert!(!grade(json!([{"step": 1, "pointer": "/volume", "json": 24100.0}])));
+ assert!(grade(json!([{"step": 1, "pointer": "/volume", "json": 24100.0, "rel": 0.01}])));
+ assert!(!grade(json!([{"step": 1, "pointer": "/center", "json": [1.0, 2.0, 3.01]}])));
+ assert!(grade(json!([{"step": 1, "pointer": "/center", "json": [1.0, 2.0, 3.01], "abs_mm": 0.02}])));
+ assert!(!grade(json!([{"step": 2, "pointer": "/summary/worst", "json": "g2"}])));
+ // A whole number is exact: a count.
+ assert!(!grade(json!([{"step": 2, "pointer": "/count", "json": 2}])));
+ // A step or a part that is not there fails, as does an entry without a step.
+ assert!(!grade(json!([{"step": 3, "pointer": "/count", "json": 1}])));
+ assert!(!grade(json!([{"step": 2, "pointer": "/missing", "json": null}])));
+ assert!(!grade(json!([{"pointer": "/count", "json": 1}])));
+ }
+
#[test]
fn a_base_cycle_is_an_error_not_a_hang() {
let root = std::env::temp_dir().join(format!("kernel-cases-cycle-{}", std::process::id()));
diff --git a/tests/kernel-cases/README.md b/tests/kernel-cases/README.md
index fdcb2824d0..6ffe10fb4a 100644
--- a/tests/kernel-cases/README.md
+++ b/tests/kernel-cases/README.md
@@ -41,6 +41,8 @@ One directory per area, one per case: `tests/kernel-cases/<area>/<id>/`.
| `frames` (frame members, inserted profiles) | tool coverage |
| `plastic` (boss, lip and groove, rest, snap fit, plastic rules) | tool coverage rig |
| `surfaces` (every `surface.*` tool: offset, ruled, untrim, unstitch, reverse normal, boundary, blend, match, fair, and a normal and an edge case of each of the others) | surfaces rig |
+| `construction` (construction planes, axes and points: `construct.*`) | tool coverage rig |
+| `inspect` (the inspect commands that return numbers) | tool coverage rig |
Each area also has its gate files: `KNOWN_FAILING` and `PATHS` (see [the gate](#the-kernel-rig-gate)).
@@ -106,6 +108,8 @@ the frozen truck-geometry PRs, a `kernel-paused` PR), for the report's coverage
| `tolerance` | Optional overrides: `rel`, `abs_mm`, `mesh_mm`, `weld_mm`. |
| `files` | The files the case wrote to `$OUT`, each `{path, json \| csv \| dxf}`, matched as a part of what is there: every key the case gives, an array item by item and as long, a whole number exactly, any other number within `rel`. `json`: the file's JSON; `csv`: its rows, as objects keyed by the header row; `dxf`: per layer of its ENTITIES section, how many of each entity (`{"CUT": {"CIRCLE": 1, "ELLIPSE": 0, "length_mm": 31.416}}`; a count may be a range `[min, max]`) and `length_mm`, the total length of its lines, arcs, circles, ellipses and polylines. |
| `results` | The commands' own answers, each `{step, json}`: the answer of the `step`th command (from 1) matched as `files` matches JSON (a flat pattern's bends, a rule's values). |
+| `construction` | `{name: spec}`, a spec being `{point: [x,y,z]}`, `{axis: {through, dir}}` or `{plane: {through, normal}}`: each named construction point, axis or plane as the timeline evaluated it. A point within the position tolerance (`tolerance.abs_mm`, else 1e-3 of the box diagonal, of 1 mm where there is no body); an axis whose direction is parallel to `dir` (either way, sine of the angle at most 1e-6) and whose line passes within it of `through`; a plane likewise with `normal`. An axis or plane is graded as the line or plane it is, not by the origin it keeps. |
+| `results` | `[{command, pointer, value, rel?, abs_mm?}]`: values in the commands' own replies (an inspect command's numbers). The reply of the script's `command`-th command (from 0, base commands included), at the JSON `pointer`, is `value`: a number within the relative tolerance, `[x, y, z]` within the position tolerance, anything else (a string, a bool, null, a list) equal. |
| `missing` | A capability SolidCraft has no command or parameter for yet (`"solid.thread has no start count"`): the case is reported **not supported yet** without running, so the gap stays visible. |
## The kernel rig gate
diff --git a/tests/kernel-cases/construction/KNOWN_FAILING b/tests/kernel-cases/construction/KNOWN_FAILING
new file mode 100644
index 0000000000..1a34c42e76
--- /dev/null
+++ b/tests/kernel-cases/construction/KNOWN_FAILING
@@ -0,0 +1,4 @@
+# The construction cases that fail today, one a line: `<case> <why it fails today>`. Sorted. A run
+# with --known-failing fails on a case that fails and is not listed here, and on a listed case
+# that passes: a fix removes its line in the same pull request.
+# Baseline: rig-cases-construction-inspect 45f69c0e5 with SMLib 60b1c6a, aarch64 Linux.
diff --git a/tests/kernel-cases/construction/PATHS b/tests/kernel-cases/construction/PATHS
new file mode 100644
index 0000000000..cf02657258
--- /dev/null
+++ b/tests/kernel-cases/construction/PATHS
@@ -0,0 +1,10 @@
+# Source files whose change must rerun the construction area: one git pathspec glob a line.
+# The construct.* commands (the plane at an angle and offset plane live in features.rs).
+crates/engine/src/cmd/construct.rs
+crates/engine/src/cmd/features.rs
+# How a construction reference resolves, and the planes the document resolves.
+crates/doc/src/construct.rs
+crates/doc/src/document.rs
+# The constructions as evaluated, which the grader reads.
+crates/engine/src/view.rs
+tests/kernel-cases/construction/**
diff --git a/tests/kernel-cases/construction/cov-axis-edge-on-a-box-edge/expected.json b/tests/kernel-cases/construction/cov-axis-edge-on-a-box-edge/expected.json
new file mode 100644
index 0000000000..b61cb93491
--- /dev/null
+++ b/tests/kernel-cases/construction/cov-axis-edge-on-a-box-edge/expected.json
@@ -0,0 +1,22 @@
+{
+ "sources": [],
+ "what": "an axis on the straight top-back edge of a box",
+ "source": "analytic",
+ "method": "box 40 x 30 x 20 with a corner at the origin (x 0..40, y 0..30, z 0..20): the edge at y 30, z 20 runs along X: the line through (0,30,20) along X",
+ "construction": {
+ "A": {
+ "axis": {
+ "through": [
+ 0,
+ 30,
+ 20
+ ],
+ "dir": [
+ 1,
+ 0,
+ 0
+ ]
+ }
+ }
+ }
+}
diff --git a/tests/kernel-cases/construction/cov-axis-edge-on-a-box-edge/recipe.json b/tests/kernel-cases/construction/cov-axis-edge-on-a-box-edge/recipe.json
new file mode 100644
index 0000000000..56cc1c75d9
--- /dev/null
+++ b/tests/kernel-cases/construction/cov-axis-edge-on-a-box-edge/recipe.json
@@ -0,0 +1,26 @@
+{
+ "commands": [
+ {
+ "command": "solid.box",
+ "params": {
+ "length": 40,
+ "width": 30,
+ "height": 20,
+ "body_name": "Box"
+ }
+ },
+ {
+ "command": "construct.axis.edge",
+ "params": {
+ "edge": {
+ "edge": [
+ 20,
+ 30,
+ 20
+ ]
+ },
+ "name": "A"
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/construction/cov-axis-edge-refuses-a-circular-edge/expected.json b/tests/kernel-cases/construction/cov-axis-edge-refuses-a-circular-edge/expected.json
new file mode 100644
index 0000000000..24177397ee
--- /dev/null
+++ b/tests/kernel-cases/construction/cov-axis-edge-refuses-a-circular-edge/expected.json
@@ -0,0 +1,8 @@
+{
+ "sources": [],
+ "what": "an axis on a circular edge, which is not straight",
+ "source": "analytic",
+ "method": "cylinder r 5, h 10 on (60,0,0) along +Z: its top edge is a circle, no line: refused",
+ "outcome": "refused",
+ "refusal": "the edge is not straight"
+}
diff --git a/tests/kernel-cases/construction/cov-axis-edge-refuses-a-circular-edge/recipe.json b/tests/kernel-cases/construction/cov-axis-edge-refuses-a-circular-edge/recipe.json
new file mode 100644
index 0000000000..fd4d3c507e
--- /dev/null
+++ b/tests/kernel-cases/construction/cov-axis-edge-refuses-a-circular-edge/recipe.json
@@ -0,0 +1,31 @@
+{
+ "commands": [
+ {
+ "command": "solid.cylinder",
+ "params": {
+ "base": [
+ 60,
+ 0,
+ 0
+ ],
+ "radius": 5,
+ "height": 10,
+ "body_name": "Cyl",
+ "operation": "new"
+ }
+ },
+ {
+ "command": "construct.axis.edge",
+ "params": {
+ "edge": {
+ "edge": [
+ 65,
+ 0,
+ 10
+ ]
+ },
+ "name": "A"
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/surfaces/KNOWN_FAILING b/tests/kernel-cases/surfaces/KNOWN_FAILING
index a514c68f37..a0d907a737 100644
--- a/tests/kernel-cases/surfaces/KNOWN_FAILING
+++ b/tests/kernel-cases/surfaces/KNOWN_FAILING
@@ -4,3 +4,4 @@
# line in the same pull request.
# Baseline: rig-cases-surfaces 45f69c0e5 with SMLib 60b1c6a, aarch64 Linux.
cov-fair-single-span-face-has-nothing-free-to-move surface.fair refuses a face of degree 1 one way ("a fairness term does not fit the net's degrees"): kernel/src/fair.rs checks its second-derivative terms against the net's degrees instead of fairing only the direction that has them
+cov-thicken-cylinder-sheet-symmetric-tube the tube's two flat end rings come back as B-spline faces, not planes (surface_types bspline, cylinder): volume, faces and box are right; the exact plane is lost in SMLib's thicken or in its record conversion
diff --git a/tests/kernel-cases/surfaces/cov-thicken-cylinder-sheet-symmetric-tube/expected.json b/tests/kernel-cases/surfaces/cov-thicken-cylinder-sheet-symmetric-tube/expected.json
new file mode 100644
index 0000000000..0695c45787
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-thicken-cylinder-sheet-symmetric-tube/expected.json
@@ -0,0 +1,25 @@
+{
+ "sources": [],
+ "what": "a cylinder wall r 10, 20 high, thickened 2 symmetric: a tube r 9..11",
+ "source": "analytic",
+ "method": "symmetric splits the thickness 1 each side: V = pi (11^2 - 9^2) 20 = 800 pi = 2513.27; faces: outer and inner cylinders and two flat rings, 4",
+ "body_count": 1,
+ "faces": 4,
+ "volume_mm3": 2513.2741228718346,
+ "surface_types": [
+ "cylinder",
+ "plane"
+ ],
+ "bbox": {
+ "min": [
+ -11,
+ -11,
+ 0
+ ],
+ "max": [
+ 11,
+ 11,
+ 20
+ ]
+ }
+}
diff --git a/tests/kernel-cases/surfaces/cov-thicken-cylinder-sheet-symmetric-tube/recipe.json b/tests/kernel-cases/surfaces/cov-thicken-cylinder-sheet-symmetric-tube/recipe.json
new file mode 100644
index 0000000000..faffe6c08d
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-thicken-cylinder-sheet-symmetric-tube/recipe.json
@@ -0,0 +1,72 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Ring"
+ }
+ },
+ {
+ "command": "sketch.circle.center",
+ "params": {
+ "center": [
+ 0,
+ 0
+ ],
+ "radius": 10
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.extrude",
+ "params": {
+ "sketch": "Ring",
+ "curves": [
+ "c1"
+ ],
+ "distance": 20,
+ "body_name": "Wall"
+ }
+ },
+ {
+ "command": "surface.thicken",
+ "params": {
+ "bodies": [
+ "Wall"
+ ],
+ "thickness": 2,
+ "symmetric": true,
+ "operation": "new",
+ "body_name": "Tube"
+ }
+ },
+ {
+ "command": "solid.remove",
+ "params": {
+ "bodies": [
+ "Wall"
+ ]
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/surfaces/cov-thicken-square-sheet-into-a-slab/expected.json b/tests/kernel-cases/surfaces/cov-thicken-square-sheet-into-a-slab/expected.json
new file mode 100644
index 0000000000..8822690f24
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-thicken-square-sheet-into-a-slab/expected.json
@@ -0,0 +1,22 @@
+{
+ "sources": [],
+ "what": "a 10 x 10 sheet on XY thickened 2 along its normal: a slab",
+ "source": "analytic",
+ "method": "the box 10 x 10 x 2 at z 0..2 (the patch faces +z): V = 200, A = 280, 6 faces",
+ "body_count": 1,
+ "faces": 6,
+ "volume_mm3": 200.0,
+ "area_mm2": 280.0,
+ "bbox": {
+ "min": [
+ 0,
+ 0,
+ 0
+ ],
+ "max": [
+ 10,
+ 10,
+ 2
+ ]
+ }
+}
diff --git a/tests/kernel-cases/surfaces/cov-thicken-square-sheet-into-a-slab/recipe.json b/tests/kernel-cases/surfaces/cov-thicken-square-sheet-into-a-slab/recipe.json
new file mode 100644
index 0000000000..5de833e663
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-thicken-square-sheet-into-a-slab/recipe.json
@@ -0,0 +1,70 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Sheet sketch"
+ }
+ },
+ {
+ "command": "sketch.rectangle.two_point",
+ "params": {
+ "p0": [
+ 0,
+ 0
+ ],
+ "p1": [
+ 10,
+ 10
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.patch",
+ "params": {
+ "sketch": "Sheet sketch",
+ "body_name": "Sheet"
+ }
+ },
+ {
+ "command": "surface.thicken",
+ "params": {
+ "bodies": [
+ "Sheet"
+ ],
+ "thickness": 2,
+ "operation": "new",
+ "body_name": "Slab"
+ }
+ },
+ {
+ "command": "solid.remove",
+ "params": {
+ "bodies": [
+ "Sheet"
+ ]
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/surfaces/cov-trim-keep-with-without-with-refused/expected.json b/tests/kernel-cases/surfaces/cov-trim-keep-with-without-with-refused/expected.json
new file mode 100644
index 0000000000..43e0846c66
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-trim-keep-with-without-with-refused/expected.json
@@ -0,0 +1,8 @@
+{
+ "sources": [],
+ "what": "a plane trim given keep_with, which only a mutual trim takes: refused",
+ "source": "invariants",
+ "method": "keep_with names what to keep of the other surface of a mutual trim; with no other surface it means nothing",
+ "outcome": "refused",
+ "refusal": "belong to a mutual trim"
+}
diff --git a/tests/kernel-cases/surfaces/cov-trim-keep-with-without-with-refused/recipe.json b/tests/kernel-cases/surfaces/cov-trim-keep-with-without-with-refused/recipe.json
new file mode 100644
index 0000000000..2645aefd84
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-trim-keep-with-without-with-refused/recipe.json
@@ -0,0 +1,79 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Sheet sketch"
+ }
+ },
+ {
+ "command": "sketch.rectangle.two_point",
+ "params": {
+ "p0": [
+ 0,
+ 0
+ ],
+ "p1": [
+ 20,
+ 20
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.patch",
+ "params": {
+ "sketch": "Sheet sketch",
+ "body_name": "Sheet"
+ }
+ },
+ {
+ "command": "surface.trim",
+ "params": {
+ "body": "Sheet",
+ "plane": {
+ "origin": [
+ 10,
+ 0,
+ 0
+ ],
+ "normal": [
+ 1,
+ 0,
+ 0
+ ]
+ },
+ "keep": [
+ 5,
+ 5,
+ 0
+ ],
+ "keep_with": [
+ 1,
+ 1,
+ 0
+ ]
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/surfaces/cov-trim-sheet-by-a-circle-keeps-the-outside/expected.json b/tests/kernel-cases/surfaces/cov-trim-sheet-by-a-circle-keeps-the-outside/expected.json
new file mode 100644
index 0000000000..7322bcd3e8
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-trim-sheet-by-a-circle-keeps-the-outside/expected.json
@@ -0,0 +1,26 @@
+{
+ "sources": [],
+ "what": "a 20 x 20 sheet trimmed by a circle r 4 drawn on it, keeping the outside: a sheet with a hole",
+ "source": "analytic",
+ "method": "A = 400 - 16 pi = 349.73, one plane face, free edges the 4 sides and the circle",
+ "valid": false,
+ "body_count": 1,
+ "faces": 1,
+ "boundary_edges": 5,
+ "area_mm2": 349.7345175425633,
+ "surface_types": [
+ "plane"
+ ],
+ "bbox": {
+ "min": [
+ 0,
+ 0,
+ 0
+ ],
+ "max": [
+ 20,
+ 20,
+ 0
+ ]
+ }
+}
diff --git a/tests/kernel-cases/surfaces/cov-trim-sheet-by-a-circle-keeps-the-outside/recipe.json b/tests/kernel-cases/surfaces/cov-trim-sheet-by-a-circle-keeps-the-outside/recipe.json
new file mode 100644
index 0000000000..67b9bed265
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-trim-sheet-by-a-circle-keeps-the-outside/recipe.json
@@ -0,0 +1,102 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Sheet sketch"
+ }
+ },
+ {
+ "command": "sketch.rectangle.two_point",
+ "params": {
+ "p0": [
+ 0,
+ 0
+ ],
+ "p1": [
+ 20,
+ 20
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.patch",
+ "params": {
+ "sketch": "Sheet sketch",
+ "body_name": "Sheet"
+ }
+ },
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Cut"
+ }
+ },
+ {
+ "command": "sketch.circle.center",
+ "params": {
+ "center": [
+ 10,
+ 10
+ ],
+ "radius": 4
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.trim",
+ "params": {
+ "body": "Sheet",
+ "curves": {
+ "sketch": "Cut"
+ },
+ "keep": [
+ 1,
+ 1,
+ 0
+ ]
+ }
+ }
+ ]
+}
diff --git a/tests/kernel-cases/surfaces/cov-trim-square-sheet-by-a-plane/expected.json b/tests/kernel-cases/surfaces/cov-trim-square-sheet-by-a-plane/expected.json
new file mode 100644
index 0000000000..26b827235c
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-trim-square-sheet-by-a-plane/expected.json
@@ -0,0 +1,26 @@
+{
+ "sources": [],
+ "what": "a 20 x 20 sheet trimmed by the plane x = 10, keeping x < 10",
+ "source": "analytic",
+ "method": "the half x 0..10: area 200, one plane face, 4 free edges",
+ "valid": false,
+ "body_count": 1,
+ "faces": 1,
+ "boundary_edges": 4,
+ "area_mm2": 200.0,
+ "surface_types": [
+ "plane"
+ ],
+ "bbox": {
+ "min": [
+ 0,
+ 0,
+ 0
+ ],
+ "max": [
+ 10,
+ 20,
+ 0
+ ]
+ }
+}
diff --git a/tests/kernel-cases/surfaces/cov-trim-square-sheet-by-a-plane/recipe.json b/tests/kernel-cases/surfaces/cov-trim-square-sheet-by-a-plane/recipe.json
new file mode 100644
index 0000000000..c349330131
--- /dev/null
+++ b/tests/kernel-cases/surfaces/cov-trim-square-sheet-by-a-plane/recipe.json
@@ -0,0 +1,74 @@
+{
+ "commands": [
+ {
+ "command": "sketch.create",
+ "params": {
+ "plane": {
+ "origin": [
+ 0,
+ 0,
+ 0
+ ],
+ "x_dir": [
+ 1,
+ 0,
+ 0
+ ],
+ "y_dir": [
+ 0,
+ 1,
+ 0
+ ]
+ },
+ "name": "Sheet sketch"
+ }
+ },
+ {
+ "command": "sketch.rectangle.two_point",
+ "params": {
+ "p0": [
+ 0,
+ 0
+ ],
+ "p1": [
+ 20,
+ 20
+ ]
+ }
+ },
+ {
+ "command": "sketch.finish",
+ "params": {}
+ },
+ {
+ "command": "surface.patch",
+ "params": {
+ "sketch": "Sheet sketch",
+ "body_name": "Sheet"
+ }
+ },
+ {
+ "command": "surface.trim",
+ "params": {
+ "body": "Sheet",
+ "plane": {
+ "origin": [
+ 10,
+ 0,
+ 0
+ ],
+ "normal": [
+ 1,
+ 0,
+ 0
+ ]
+ },
+ "keep": [
+ 5,
+ 5,
+ 0
+ ]
+ }
+ }
+ ]
+}