Skip to content

Speakr is a personal, self-hosted web application designed for transcribing audio recordings

Python

Validate folder ownership in recording-session finalize to close IDOR where an attacker could finalize into another user's personal or group folder (#287 c/d)

Murtaza Nasir20f1048495dd
diff --git a/src/api/recording_sessions.py b/src/api/recording_sessions.py
index 0a758ba6..37d3e29c 100644
--- a/src/api/recording_sessions.py
+++ b/src/api/recording_sessions.py
@@ -303,12 +303,34 @@ def finalize_session(session_id):
if folder_id in ('', 'none', 'null'):
folder_id = None
+ # Authorize folder access (#287 c/d, mirrors update_recording in
+ # src/api/api_v1.py). Without this check, an attacker could finalize
+ # a session targeting another user's folder, and the resulting
+ # recording would be linked to it. Personal folders require
+ # ownership; group folders require membership.
+ resolved_folder_id = None
+ if isinstance(folder_id, int):
+ from src.models.organization import Folder, GroupMembership
+ target = db.session.get(Folder, folder_id)
+ if not target:
+ return jsonify({'error': f'Folder {folder_id} not found'}), 404
+ if target.group_id is None:
+ if target.user_id != current_user.id:
+ return jsonify({'error': 'No access to target folder'}), 403
+ else:
+ membership = GroupMembership.query.filter_by(
+ user_id=current_user.id, group_id=target.group_id
+ ).first()
+ if not membership:
+ return jsonify({'error': 'No access to target folder'}), 403
+ resolved_folder_id = target.id
+
recording = Recording(
user_id=current_user.id,
title=title[:200],
status='STITCHING',
notes=notes,
- folder_id=folder_id if isinstance(folder_id, int) else None,
+ folder_id=resolved_folder_id,
processing_source='recording_session',
mime_type=session.mime_type,
)
diff --git a/tests/test_recording_sessions.py b/tests/test_recording_sessions.py
index 230bc58a..a279e3fd 100644
--- a/tests/test_recording_sessions.py
+++ b/tests/test_recording_sessions.py
@@ -233,6 +233,98 @@ def test_finalize_creates_recording_and_enqueues_stitch_job():
shutil.rmtree(upload_folder, ignore_errors=True)
+def test_finalize_rejects_finalizing_into_other_users_personal_folder():
+ """IDOR regression. Without folder-access validation in finalize,
+ user A could submit a personal folder_id belonging to user B and the
+ new recording would be linked to B's folder. Mirrors the validation
+ in update_recording (src/api/api_v1.py). Reported by the background
+ security review on 2026-06-05."""
+ from src.models.organization import Folder
+
+ upload_folder = _make_tmp_upload_folder()
+ with app.app_context():
+ app.config["UPLOAD_FOLDER"] = upload_folder
+ victim = _setup_user("sess_idor_victim")
+ attacker = _setup_user("sess_idor_attacker")
+ victim_folder = Folder(name="victim-private", user_id=victim.id)
+ db.session.add(victim_folder)
+ db.session.commit()
+
+ client = app.test_client()
+ _login(client, attacker)
+ sid = client.post("/upload/session", json={"mime_type": "audio/webm"}).get_json()["session_id"]
+ client.post(
+ f"/upload/session/{sid}/chunks/1",
+ data=b"\x00" * 100,
+ content_type="application/octet-stream",
+ )
+
+ r = client.post(
+ f"/upload/session/{sid}/finalize",
+ json={"title": "exploit", "folder_id": victim_folder.id},
+ )
+ assert r.status_code == 403, (
+ f"Cross-tenant folder finalize must be rejected; got "
+ f"{r.status_code} body={r.data!r}"
+ )
+
+ # The victim's folder must still belong to the victim; no
+ # recording from the attacker may exist with folder_id set.
+ from sqlalchemy import select
+ attacker_recs = db.session.execute(
+ select(Recording).where(
+ Recording.user_id == attacker.id,
+ Recording.folder_id == victim_folder.id,
+ )
+ ).scalars().all()
+ assert not attacker_recs
+
+ # Cleanup
+ sess = db.session.get(RecordingSession, sid)
+ if sess:
+ sess.status = "aborted"
+ db.session.commit()
+ client.delete(f"/upload/session/{sid}")
+ db.session.delete(victim_folder)
+ db.session.delete(victim)
+ db.session.delete(attacker)
+ db.session.commit()
+ shutil.rmtree(upload_folder, ignore_errors=True)
+
+
+def test_finalize_returns_404_for_nonexistent_folder():
+ """The folder-access check uses 404 vs 403 to distinguish missing
+ from forbidden, matching update_recording's behaviour. A made-up
+ folder_id should 404, not silently succeed."""
+ upload_folder = _make_tmp_upload_folder()
+ with app.app_context():
+ app.config["UPLOAD_FOLDER"] = upload_folder
+ user = _setup_user("sess_bad_folder")
+ client = app.test_client()
+ _login(client, user)
+ sid = client.post("/upload/session", json={"mime_type": "audio/webm"}).get_json()["session_id"]
+ client.post(
+ f"/upload/session/{sid}/chunks/1",
+ data=b"\x00" * 100,
+ content_type="application/octet-stream",
+ )
+
+ r = client.post(
+ f"/upload/session/{sid}/finalize",
+ json={"folder_id": 999_999_999},
+ )
+ assert r.status_code == 404
+
+ sess = db.session.get(RecordingSession, sid)
+ if sess:
+ sess.status = "aborted"
+ db.session.commit()
+ client.delete(f"/upload/session/{sid}")
+ db.session.delete(user)
+ db.session.commit()
+ shutil.rmtree(upload_folder, ignore_errors=True)
+
+
def test_finalize_rejects_when_no_chunks():
upload_folder = _make_tmp_upload_folder()
with app.app_context():