Skip to content

Speakr is a personal, self-hosted web application designed for transcribing audio recordings

Python

Cleanup audit: mobile editor + dark-mode --speaker-fg consistency — (1) mobile-summary-panel.html and mobile-notes-panel.html had the same missing .markdown-editor-container wrapper as the desktop tabs did before commit 47c0bec; their textareas were wrapped in 'h-full flex flex-col' but no editor-container class, so the existing themed EasyMDE CSS (.markdown-editor-container .EasyMDEContainer + the mobile-specific .mobile-content-box variants) was scoped to a class that wasn't in the DOM and the editors fell back to un-themed default appearance with auto-grow height; both mobile panels now wrap the textarea in <div class='markdown-editor-container flex-1 min-h-0 flex flex-col'> just like the desktop fix; (2) the dark mode .speaker-color-N rules at line 2055+ didn't set --speaker-fg, so anything reading var(--speaker-fg) in dark mode would inherit the LIGHT-mode value (the saturated colour from the un-overridden .speaker-color-N rule above) instead of the dark equivalent; the current .speaker-tablet-time dark-mode rule uses the overlay path and doesn't read it so this is currently latent, but exposing --speaker-fg on the dark rules keeps the variable consistent for any future consumer; the dark --speaker-fg is set to the same dark surface colour used as the bg, since the dark-mode design philosophy is bg-as-identity rather than fg-as-identity

Murtaza Nasir48d698fa58c1
diff --git a/static/css/styles.css b/static/css/styles.css
index a0b5b594..a6ac86ae 100644
--- a/static/css/styles.css
+++ b/static/css/styles.css
@@ -2052,23 +2052,30 @@ body {
.speaker-color-15 { background-color: #E0F2F1; color: #00695C; --speaker-fg: #00695C; } /* Teal */
.speaker-color-16 { background-color: #FBE9E7; color: #BF360C; --speaker-fg: #BF360C; } /* Deep Orange */
-/* Dark mode speaker colors - tasteful muted pastels with 16 colors */
-.dark .speaker-color-1 { background-color: #1E3A5F; color: #A5C9EA; } /* Blue */
-.dark .speaker-color-2 { background-color: #4A2C5A; color: #D4A5D4; } /* Purple */
-.dark .speaker-color-3 { background-color: #1F4A3C; color: #A8D5A8; } /* Green */
-.dark .speaker-color-4 { background-color: #5A3A1F; color: #E6B366; } /* Orange */
-.dark .speaker-color-5 { background-color: #5A2C3E; color: #E6A5C4; } /* Pink */
-.dark .speaker-color-6 { background-color: #1F4A47; color: #A5D5D0; } /* Cyan */
-.dark .speaker-color-7 { background-color: #4A4A1F; color: #E6E266; } /* Yellow */
-.dark .speaker-color-8 { background-color: #3E2723; color: #D7CCC8; } /* Brown */
-.dark .speaker-color-9 { background-color: #1A237E; color: #9FA8DA; } /* Indigo */
-.dark .speaker-color-10 { background-color: #33691E; color: #C5E1A5; } /* Lime */
-.dark .speaker-color-11 { background-color: #5A1F1F; color: #EF9A9A; } /* Red */
-.dark .speaker-color-12 { background-color: #263238; color: #B0BEC5; } /* Blue Grey */
-.dark .speaker-color-13 { background-color: #4A3F1F; color: #FFE082; } /* Amber */
-.dark .speaker-color-14 { background-color: #311B92; color: #B39DDB; } /* Deep Purple */
-.dark .speaker-color-15 { background-color: #004D40; color: #80CBC4; } /* Teal */
-.dark .speaker-color-16 { background-color: #4E2C1F; color: #FFAB91; } /* Deep Orange */
+/* Dark mode speaker colors - tasteful muted pastels with 16 colors.
+ --speaker-fg is set to the same dark surface colour used as the
+ speaker-color background so consumers that read it (e.g. the
+ speaker-tablet-time half) get the matching dark-mode hue rather
+ than inheriting the unrelated light-mode value. The current
+ .speaker-tablet-time dark-mode rule doesn't read it (uses an
+ overlay path), but exposing it keeps the variable consistent
+ between modes so any future consumer behaves correctly. */
+.dark .speaker-color-1 { background-color: #1E3A5F; color: #A5C9EA; --speaker-fg: #1E3A5F; } /* Blue */
+.dark .speaker-color-2 { background-color: #4A2C5A; color: #D4A5D4; --speaker-fg: #4A2C5A; } /* Purple */
+.dark .speaker-color-3 { background-color: #1F4A3C; color: #A8D5A8; --speaker-fg: #1F4A3C; } /* Green */
+.dark .speaker-color-4 { background-color: #5A3A1F; color: #E6B366; --speaker-fg: #5A3A1F; } /* Orange */
+.dark .speaker-color-5 { background-color: #5A2C3E; color: #E6A5C4; --speaker-fg: #5A2C3E; } /* Pink */
+.dark .speaker-color-6 { background-color: #1F4A47; color: #A5D5D0; --speaker-fg: #1F4A47; } /* Cyan */
+.dark .speaker-color-7 { background-color: #4A4A1F; color: #E6E266; --speaker-fg: #4A4A1F; } /* Yellow */
+.dark .speaker-color-8 { background-color: #3E2723; color: #D7CCC8; --speaker-fg: #3E2723; } /* Brown */
+.dark .speaker-color-9 { background-color: #1A237E; color: #9FA8DA; --speaker-fg: #1A237E; } /* Indigo */
+.dark .speaker-color-10 { background-color: #33691E; color: #C5E1A5; --speaker-fg: #33691E; } /* Lime */
+.dark .speaker-color-11 { background-color: #5A1F1F; color: #EF9A9A; --speaker-fg: #5A1F1F; } /* Red */
+.dark .speaker-color-12 { background-color: #263238; color: #B0BEC5; --speaker-fg: #263238; } /* Blue Grey */
+.dark .speaker-color-13 { background-color: #4A3F1F; color: #FFE082; --speaker-fg: #4A3F1F; } /* Amber */
+.dark .speaker-color-14 { background-color: #311B92; color: #B39DDB; --speaker-fg: #311B92; } /* Deep Purple */
+.dark .speaker-color-15 { background-color: #004D40; color: #80CBC4; --speaker-fg: #004D40; } /* Teal */
+.dark .speaker-color-16 { background-color: #4E2C1F; color: #FFAB91; --speaker-fg: #4E2C1F; } /* Deep Orange */
/* Meeting/Created time styling improvements */
.recording-metadata {
diff --git a/templates/components/detail/mobile-notes-panel.html b/templates/components/detail/mobile-notes-panel.html
index 3e637dcb..eea57a1a 100644
--- a/templates/components/detail/mobile-notes-panel.html
+++ b/templates/components/detail/mobile-notes-panel.html
@@ -7,10 +7,12 @@
</div>
<div class="flex-grow overflow-y-auto px-3 pb-3">
<div v-if="editingNotes" class="h-full flex flex-col">
- <textarea ref="notesMarkdownEditor"
- v-model="selectedRecording.notes"
- class="field flex-1"
- style="resize: none; padding: var(--sp-3);"></textarea>
+ <!-- See mobile-summary-panel.html for the rationale behind
+ the .markdown-editor-container wrapper. -->
+ <div class="markdown-editor-container flex-1 min-h-0 flex flex-col">
+ <textarea ref="notesMarkdownEditor"
+ v-model="selectedRecording.notes"></textarea>
+ </div>
<div class="flex justify-end gap-2 mt-2">
<button @click="cancelEditNotes" class="btn btn--sm btn--ghost" v-text="t('common.cancel')"></button>
<button @click="saveEditNotes" class="btn btn--sm btn--primary" v-text="t('common.save')"></button>
diff --git a/templates/components/detail/mobile-summary-panel.html b/templates/components/detail/mobile-summary-panel.html
index 55d10913..f81b1922 100644
--- a/templates/components/detail/mobile-summary-panel.html
+++ b/templates/components/detail/mobile-summary-panel.html
@@ -8,10 +8,16 @@
</div>
<div class="flex-grow overflow-y-auto px-3 pb-3">
<div v-if="editingSummary" class="h-full flex flex-col">
- <textarea ref="summaryMarkdownEditor"
- v-model="selectedRecording.summary"
- class="field flex-1"
- style="resize: none; padding: var(--sp-3);"></textarea>
+ <!-- EasyMDE replaces this textarea with its toolbar +
+ CodeMirror DOM. The .markdown-editor-container
+ wrapper is what hooks the editor's theme + height
+ CSS at styles.css line 3498+ (and the mobile-specific
+ overrides at line 2348+); without it the editor
+ renders un-themed and auto-grows past the viewport. -->
+ <div class="markdown-editor-container flex-1 min-h-0 flex flex-col">
+ <textarea ref="summaryMarkdownEditor"
+ v-model="selectedRecording.summary"></textarea>
+ </div>
<div class="flex justify-end gap-2 mt-2">
<button @click="cancelEditSummary" class="btn btn--sm btn--ghost" v-text="t('common.cancel')"></button>
<button @click="saveEditSummary" class="btn btn--sm btn--primary" v-text="t('common.save')"></button>